From 38582eed845cd91f267e54799d58f02a2b564153 Mon Sep 17 00:00:00 2001
From: Florian Schmaus <flo@geekplace.eu>
Date: Sun, 12 Oct 2014 16:52:49 +0200
Subject: [PATCH] Make getServiceNames() return List

instead of Collection. Return types should always be as specific as
possible. Because e.g. Collection does not allow 'get(0)', but List
does.
---
 .../main/java/org/jivesoftware/smackx/muc/MultiUserChat.java  | 2 +-
 .../org/jivesoftware/smackx/search/UserSearchManager.java     | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/muc/MultiUserChat.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/muc/MultiUserChat.java
index b5de7411b..2b6312607 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/muc/MultiUserChat.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/muc/MultiUserChat.java
@@ -261,7 +261,7 @@ public class MultiUserChat {
      * @throws NoResponseException 
      * @throws NotConnectedException 
      */
-    public static Collection<String> getServiceNames(XMPPConnection connection) throws NoResponseException, XMPPErrorException, NotConnectedException  {
+    public static List<String> getServiceNames(XMPPConnection connection) throws NoResponseException, XMPPErrorException, NotConnectedException  {
         ServiceDiscoveryManager sdm = ServiceDiscoveryManager.getInstanceFor(connection);
         return sdm.findServices(MUCInitialPresence.NAMESPACE, false, false);
     }
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/search/UserSearchManager.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/search/UserSearchManager.java
index 26152abc0..4b3bcaf6a 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/search/UserSearchManager.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/search/UserSearchManager.java
@@ -23,7 +23,7 @@ import org.jivesoftware.smack.XMPPException.XMPPErrorException;
 import org.jivesoftware.smackx.disco.ServiceDiscoveryManager;
 import org.jivesoftware.smackx.xdata.Form;
 
-import java.util.Collection;
+import java.util.List;
 
 /**
  * The UserSearchManager is a facade built upon Jabber Search Services (XEP-055) to allow for searching
@@ -95,7 +95,7 @@ public class UserSearchManager {
      * @throws NoResponseException 
      * @throws NotConnectedException 
      */
-    public Collection<String> getSearchServices() throws NoResponseException, XMPPErrorException, NotConnectedException  {
+    public List<String> getSearchServices() throws NoResponseException, XMPPErrorException, NotConnectedException  {
         ServiceDiscoveryManager discoManager = ServiceDiscoveryManager.getInstanceFor(con);
         return discoManager.findServices(UserSearch.NAMESPACE, false, false);
     }