From 451eb4c826abe698930b2a03e2c4feab409f65bd Mon Sep 17 00:00:00 2001 From: Florian Schmaus Date: Mon, 23 Mar 2015 09:52:01 +0100 Subject: [PATCH] Add missing break statements --- .../java/org/jivesoftware/smack/AbstractXMPPConnection.java | 1 + .../java/org/jivesoftware/smack/util/PacketParserUtils.java | 1 + .../jivesoftware/smackx/forward/provider/ForwardedProvider.java | 1 + .../org/jivesoftware/smackx/iqlast/LastActivityManager.java | 1 + .../org/jivesoftware/smackx/muc/provider/MUCParserUtils.java | 1 + .../jivesoftware/smackx/vcardtemp/provider/VCardProvider.java | 2 ++ .../jivesoftware/smackx/xdata/provider/DataFormProvider.java | 1 + 7 files changed, 8 insertions(+) diff --git a/smack-core/src/main/java/org/jivesoftware/smack/AbstractXMPPConnection.java b/smack-core/src/main/java/org/jivesoftware/smack/AbstractXMPPConnection.java index 8502357ec..f8cb376cf 100644 --- a/smack-core/src/main/java/org/jivesoftware/smack/AbstractXMPPConnection.java +++ b/smack-core/src/main/java/org/jivesoftware/smack/AbstractXMPPConnection.java @@ -1070,6 +1070,7 @@ public abstract class AbstractXMPPConnection implements XMPPConnection { // desired behavior. return; } + break; default: break; } diff --git a/smack-core/src/main/java/org/jivesoftware/smack/util/PacketParserUtils.java b/smack-core/src/main/java/org/jivesoftware/smack/util/PacketParserUtils.java index f1c709c60..6a7e8d9ab 100644 --- a/smack-core/src/main/java/org/jivesoftware/smack/util/PacketParserUtils.java +++ b/smack-core/src/main/java/org/jivesoftware/smack/util/PacketParserUtils.java @@ -580,6 +580,7 @@ public class PacketParserUtils { } break; } + break; case XmlPullParser.END_TAG: if (parser.getDepth() == initialDepth) { break outerloop; diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/forward/provider/ForwardedProvider.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/forward/provider/ForwardedProvider.java index 0e1b96769..9e2397c9c 100644 --- a/smack-extensions/src/main/java/org/jivesoftware/smackx/forward/provider/ForwardedProvider.java +++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/forward/provider/ForwardedProvider.java @@ -66,6 +66,7 @@ public class ForwardedProvider extends ExtensionElementProvider { default: LOGGER.warning("Unsupported forwarded packet type: " + name); } + break; case XmlPullParser.END_TAG: if (parser.getDepth() == initialDepth) { break outerloop; diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/iqlast/LastActivityManager.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/iqlast/LastActivityManager.java index 7ae775b08..f73f1cbaf 100644 --- a/smack-extensions/src/main/java/org/jivesoftware/smackx/iqlast/LastActivityManager.java +++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/iqlast/LastActivityManager.java @@ -145,6 +145,7 @@ public class LastActivityManager extends Manager { // We assume that only a switch to available and chat indicates user activity // since other mode changes could be also a result of some sort of automatism resetIdleTime(); + break; default: break; } diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/muc/provider/MUCParserUtils.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/muc/provider/MUCParserUtils.java index c3f3f85fa..e0ae2b64f 100644 --- a/smack-extensions/src/main/java/org/jivesoftware/smackx/muc/provider/MUCParserUtils.java +++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/muc/provider/MUCParserUtils.java @@ -47,6 +47,7 @@ public class MUCParserUtils { reason = parser.nextText(); break; } + break; case XmlPullParser.END_TAG: if (parser.getDepth() == initialDepth) { break outerloop; diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/vcardtemp/provider/VCardProvider.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/vcardtemp/provider/VCardProvider.java index 92549f699..753805dd2 100644 --- a/smack-extensions/src/main/java/org/jivesoftware/smackx/vcardtemp/provider/VCardProvider.java +++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/vcardtemp/provider/VCardProvider.java @@ -254,10 +254,12 @@ public class VCardProvider extends IQProvider { default: break; } + break; case XmlPullParser.END_TAG: if (parser.getDepth() == initialDepth) { break outerloop; } + break; default: break; } diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/xdata/provider/DataFormProvider.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/xdata/provider/DataFormProvider.java index 3c44e3b8e..ec8f69947 100644 --- a/smack-extensions/src/main/java/org/jivesoftware/smackx/xdata/provider/DataFormProvider.java +++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/xdata/provider/DataFormProvider.java @@ -132,6 +132,7 @@ public class DataFormProvider extends ExtensionElementProvider { } break; } + break; case XmlPullParser.END_TAG: if (parser.getDepth() == initialDepth) { break outerloop;