Mercury-IM/Smack
Mercury-IM/Smack
1
0
Fork 0
mirror of https://codeberg.org/Mercury-IM/Smack synced 2024-11-21 22:02:06 +01:00
Code Issues Releases Wiki Activity

[tcp] Add code comment why we have to copy the ByteBuffer

Browse source
This commit is contained in:
Florian Schmaus 2020-09-20 13:11:29 +02:00
parent 08fc0ba0b4
commit 4db7d787f7
1 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
smack-tcp/src/main/java/org/jivesoftware/smack/tcp/XmppTcpTransportModule.java
View file

@ -1030,12 +1030,15 @@ public class XmppTcpTransportModule extends ModularXmppClientToServerConnectionM
} }
} }
@SuppressWarnings("ReferenceEquality")
@Override @Override
public ByteBuffer input(ByteBuffer inputData) throws SSLException { public ByteBuffer input(ByteBuffer inputData) throws SSLException {
ByteBuffer accumulatedData; ByteBuffer accumulatedData;
if (pendingInputData == null) { if (pendingInputData == null) {
accumulatedData = inputData; accumulatedData = inputData;
} else { } else {
assert pendingInputData != inputData;
int accumulatedDataBytes = pendingInputData.remaining() + inputData.remaining(); int accumulatedDataBytes = pendingInputData.remaining() + inputData.remaining();
accumulatedData = ByteBuffer.allocate(accumulatedDataBytes); accumulatedData = ByteBuffer.allocate(accumulatedDataBytes);
accumulatedData.put(pendingInputData) accumulatedData.put(pendingInputData)
@ -1116,9 +1119,11 @@ public class XmppTcpTransportModule extends ModularXmppClientToServerConnectionM
} }
private void addAsPendingInputData(ByteBuffer byteBuffer) { private void addAsPendingInputData(ByteBuffer byteBuffer) {
// TODO: Why doeesn't simply // Note that we can not simply write
// pendingInputData = byteBuffer; // pendingInputData = byteBuffer;
// work? // we have to copy the provided byte buffer, because it is possible that this byteBuffer is re-used by some
// higher layer. That is, here 'byteBuffer' is typically 'incomingBuffer', which is a direct buffer only
// allocated once per connection for performance reasons and hence re-used for read() calls.
pendingInputData = ByteBuffer.allocate(byteBuffer.remaining()); pendingInputData = ByteBuffer.allocate(byteBuffer.remaining());
pendingInputData.put(byteBuffer).flip(); pendingInputData.put(byteBuffer).flip();