Mercury-IM/Smack
Mercury-IM/Smack
1
0
Fork 0
mirror of https://codeberg.org/Mercury-IM/Smack synced 2024-11-22 06:12:05 +01:00
Code Issues Releases Wiki Activity

Don't log whole exceptions in VCardProvider

Browse source 
when trying to harden the parser.
This commit is contained in:
Florian Schmaus 2015-01-10 01:46:09 +01:00
parent 6a43bab4f5
commit 50c7d0bc2c
1 changed files with 3 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
smack-extensions/src/main/java/org/jivesoftware/smackx/vcardtemp/provider/VCardProvider.java
View file

@ -60,7 +60,7 @@ public class VCardProvider extends IQProvider<VCard> {
try { try {
documentBuilderFactory.setFeature("http://apache.org/xml/features/disallow-doctype-decl", true); documentBuilderFactory.setFeature("http://apache.org/xml/features/disallow-doctype-decl", true);
} catch (ParserConfigurationException e) { } catch (ParserConfigurationException e) {
LOGGER.log(Level.FINER, "Could not disallow doctype decl", e); LOGGER.finer("Could not disallow doctype decl: " + e.getMessage());
// If we can't disable DTDs, then at least try the following // If we can't disable DTDs, then at least try the following
// Xerces 1 - http://xerces.apache.org/xerces-j/features.html#external-general-entities // Xerces 1 - http://xerces.apache.org/xerces-j/features.html#external-general-entities
// Xerces 2 - http://xerces.apache.org/xerces2-j/features.html#external-general-entities // Xerces 2 - http://xerces.apache.org/xerces2-j/features.html#external-general-entities
@ -68,7 +68,7 @@ public class VCardProvider extends IQProvider<VCard> {
documentBuilderFactory.setFeature( "http://xml.org/sax/features/external-general-entities", false); documentBuilderFactory.setFeature( "http://xml.org/sax/features/external-general-entities", false);
documentBuilderFactory.setFeature( "http://xml.org/sax/features/external-parameter-entities", false); documentBuilderFactory.setFeature( "http://xml.org/sax/features/external-parameter-entities", false);
} catch (ParserConfigurationException e1) { } catch (ParserConfigurationException e1) {
LOGGER.log(Level.FINER, "Could not disallow external entities for xerces parser", e1); LOGGER.finer("Could not disallow external entities for xerces parser: " + e1.getMessage());
} }
} }
// Android throws an UnsupportedOperationException when calling setXIncludeAware() and for some dumb reason also // Android throws an UnsupportedOperationException when calling setXIncludeAware() and for some dumb reason also
@ -93,7 +93,7 @@ public class VCardProvider extends IQProvider<VCard> {
try { try {
documentBuilderFactory.setFeature(XMLConstants.FEATURE_SECURE_PROCESSING, true); documentBuilderFactory.setFeature(XMLConstants.FEATURE_SECURE_PROCESSING, true);
} catch (ParserConfigurationException e) { } catch (ParserConfigurationException e) {
LOGGER.log(Level.INFO, "Could not enable secure processing parsing feature", e); LOGGER.info("Could not enable secure processing parsing feature: " + e.getMessage());
} }
DOCUMENT_BUILDER_FACTORY = documentBuilderFactory; DOCUMENT_BUILDER_FACTORY = documentBuilderFactory;