Mercury-IM/Smack
Mercury-IM/Smack
1
0
Fork 0
mirror of https://codeberg.org/Mercury-IM/Smack synced 2024-11-26 08:12:05 +01:00
Code Issues Releases Wiki Activity

Fix NPE in IoTDiscoveryManager

Browse source
This commit is contained in:
Florian Schmaus 2016-07-31 14:30:23 +02:00
parent 8810f17460
commit 5b137616bb
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
smack-experimental/src/main/java/org/jivesoftware/smackx/iot/discovery/IoTDiscoveryManager.java
View file

@ -36,6 +36,7 @@ import org.jivesoftware.smack.XMPPException.XMPPErrorException;
import org.jivesoftware.smack.iqrequest.AbstractIqRequestHandler; import org.jivesoftware.smack.iqrequest.AbstractIqRequestHandler;
import org.jivesoftware.smack.iqrequest.IQRequestHandler.Mode; import org.jivesoftware.smack.iqrequest.IQRequestHandler.Mode;
import org.jivesoftware.smack.packet.IQ; import org.jivesoftware.smack.packet.IQ;
import org.jivesoftware.smack.util.Objects;
import org.jivesoftware.smackx.disco.ServiceDiscoveryManager; import org.jivesoftware.smackx.disco.ServiceDiscoveryManager;
import org.jivesoftware.smackx.disco.packet.DiscoverInfo; import org.jivesoftware.smackx.disco.packet.DiscoverInfo;
import org.jivesoftware.smackx.iot.Thing; import org.jivesoftware.smackx.iot.Thing;
@ -202,7 +203,7 @@ public final class IoTDiscoveryManager extends Manager {
/** /**
* Try to find an XMPP IoT registry. * Try to find an XMPP IoT registry.
* *
* @return the JID of a Thing Registry if one could be found. * @return the JID of a Thing Registry if one could be found, <code>null</code> otherwise.
* @throws InterruptedException * @throws InterruptedException
* @throws NotConnectedException * @throws NotConnectedException
* @throws XMPPErrorException * @throws XMPPErrorException
@ -373,9 +374,11 @@ public final class IoTDiscoveryManager extends Manager {
// Registry utility methods // Registry utility methods
public boolean isRegistry(BareJid jid) throws NoResponseException, XMPPErrorException, NotConnectedException, InterruptedException { public boolean isRegistry(BareJid jid) throws NoResponseException, XMPPErrorException, NotConnectedException, InterruptedException {
Objects.requireNonNull(jid, "JID argument must not be null");
// At some point 'usedRegistries' will also contain the registry returned by findRegistry(), but since this is // At some point 'usedRegistries' will also contain the registry returned by findRegistry(), but since this is
// not the case from the beginning, we perform findRegistry().equals(jid) too. // not the case from the beginning, we perform findRegistry().equals(jid) too.
if (findRegistry().equals(jid)) { Jid registry = findRegistry();
if (jid.equals(registry)) {
return true; return true;
} }
if (usedRegistries.contains(jid)) { if (usedRegistries.contains(jid)) {