Mercury-IM/Smack
Mercury-IM/Smack
1
0
Fork 0
mirror of https://codeberg.org/Mercury-IM/Smack synced 2024-11-22 22:32:06 +01:00
Code Issues Releases Wiki Activity

Improve XmlStringBuilder usage in Bytestream

Browse source
This commit is contained in:
Florian Schmaus 2014-08-19 12:43:21 +02:00
parent 6021f8a8ce
commit 650da55b23
1 changed files with 6 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/socks5/packet/Bytestream.java
View file

@ -221,17 +221,13 @@ public class Bytestream extends IQ {
@Override @Override
public XmlStringBuilder getChildElementXML() { public XmlStringBuilder getChildElementXML() {
XmlStringBuilder xml = new XmlStringBuilder(); XmlStringBuilder xml = new XmlStringBuilder();
xml.halfOpenElement(IQ.QUERY_ELEMENT); xml.halfOpenElement(QUERY_ELEMENT);
xml.xmlnsAttribute(NAMESPACE); xml.xmlnsAttribute(NAMESPACE);
switch(getType()) { switch(getType()) {
case set: case set:
if (getSessionID() != null) { xml.optAttribute("sid", getSessionID());
xml.attribute("sid", getSessionID()); xml.optAttribute("mode", getMode());
}
if (getMode() != null) {
xml.attribute("mode", getMode());
}
xml.rightAngelBracket(); xml.rightAngelBracket();
if (getToActivate() == null) { if (getToActivate() == null) {
for (StreamHost streamHost : getStreamHosts()) { for (StreamHost streamHost : getStreamHosts()) {
@ -256,11 +252,13 @@ public class Bytestream extends IQ {
break; break;
case get: case get:
xml.closeEmptyElement(); xml.closeEmptyElement();
// Return here so that we don't run into the
// closeElement(QUERY_ELEMNT) section
return xml; return xml;
default: default:
throw new IllegalStateException(); throw new IllegalStateException();
} }
xml.closeElement(IQ.QUERY_ELEMENT); xml.closeElement(QUERY_ELEMENT);
return xml; return xml;
} }