From 89b64fbf0c3c2a609ede89ee2093a05227e0bbc9 Mon Sep 17 00:00:00 2001 From: Florian Schmaus Date: Wed, 29 May 2019 11:50:25 +0200 Subject: [PATCH] Add TODO comment to XmppNioTcpConnection --- .../java/org/jivesoftware/smack/tcp/XmppNioTcpConnection.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/smack-tcp/src/main/java/org/jivesoftware/smack/tcp/XmppNioTcpConnection.java b/smack-tcp/src/main/java/org/jivesoftware/smack/tcp/XmppNioTcpConnection.java index 8cc7287df..d0ae8d351 100644 --- a/smack-tcp/src/main/java/org/jivesoftware/smack/tcp/XmppNioTcpConnection.java +++ b/smack-tcp/src/main/java/org/jivesoftware/smack/tcp/XmppNioTcpConnection.java @@ -1117,6 +1117,8 @@ public class XmppNioTcpConnection extends AbstractXmppNioConnection { // session resumption may would need or at least benefit from B. Variant A would also be required if the // String is used for certificate verification. And it appears at least likely that TLS session resumption // would not be hurt by using variant A. Therefore we currently use variant A. + // TODO: Should we use the ACE representation of the XMPP service domain? Compare with f60e4055ec529f0b8160acedf13275592ab10a4b + // If yes, then we should probably introduce getXmppServiceDomainAceEncodedIfPossible(). engine = smackTlsContext.sslContext.createSSLEngine(config.getXMPPServiceDomain().toString(), remoteAddress.getPort()); engine.setUseClientMode(true);