From ce8ccf3647972be4179b209bd8256ab32a458b1f Mon Sep 17 00:00:00 2001 From: Florian Schmaus Date: Fri, 24 Oct 2014 11:14:41 +0200 Subject: [PATCH] Make Message and Presence class final In order to prevent users from trying to subclass those two, trying to add their custom attributes (or attribute values) in the element of those two, instead of using extension elements aka. PacketExtension. See - http://stackoverflow.com/q/26516386/ - http://stackoverflow.com/q/26507753/ - http://stackoverflow.com/q/26542601/ --- .../src/main/java/org/jivesoftware/smack/packet/Message.java | 2 +- .../src/main/java/org/jivesoftware/smack/packet/Presence.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/smack-core/src/main/java/org/jivesoftware/smack/packet/Message.java b/smack-core/src/main/java/org/jivesoftware/smack/packet/Message.java index cc7b8432b..6c2900dcb 100644 --- a/smack-core/src/main/java/org/jivesoftware/smack/packet/Message.java +++ b/smack-core/src/main/java/org/jivesoftware/smack/packet/Message.java @@ -51,7 +51,7 @@ import org.jivesoftware.smack.util.XmlStringBuilder; * * @author Matt Tucker */ -public class Message extends Packet { +public final class Message extends Packet { public static final String ELEMENT = "message"; public static final String BODY = "body"; diff --git a/smack-core/src/main/java/org/jivesoftware/smack/packet/Presence.java b/smack-core/src/main/java/org/jivesoftware/smack/packet/Presence.java index 9c12d2061..56d042eba 100644 --- a/smack-core/src/main/java/org/jivesoftware/smack/packet/Presence.java +++ b/smack-core/src/main/java/org/jivesoftware/smack/packet/Presence.java @@ -55,7 +55,7 @@ import org.jivesoftware.smack.util.XmlStringBuilder; * @see RosterPacket * @author Matt Tucker */ -public class Presence extends Packet { +public final class Presence extends Packet { public static final String ELEMENT = "presence";