From e0b85779309c9a6ad719439320c3686e89f40725 Mon Sep 17 00:00:00 2001 From: Florian Schmaus Date: Sun, 11 May 2014 10:15:14 +0200 Subject: [PATCH] Make IQ attributes final in parseIQ() --- .../org/jivesoftware/smack/util/PacketParserUtils.java | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/smack-core/src/main/java/org/jivesoftware/smack/util/PacketParserUtils.java b/smack-core/src/main/java/org/jivesoftware/smack/util/PacketParserUtils.java index 32570de4d..8adfd8164 100644 --- a/smack-core/src/main/java/org/jivesoftware/smack/util/PacketParserUtils.java +++ b/smack-core/src/main/java/org/jivesoftware/smack/util/PacketParserUtils.java @@ -254,13 +254,13 @@ public class PacketParserUtils { */ public static IQ parseIQ(XmlPullParser parser, XMPPConnection connection) throws Exception { IQ iqPacket = null; - - String id = parser.getAttributeValue("", "id"); - String to = parser.getAttributeValue("", "to"); - String from = parser.getAttributeValue("", "from"); - IQ.Type type = IQ.Type.fromString(parser.getAttributeValue("", "type")); XMPPError error = null; + final String id = parser.getAttributeValue("", "id"); + final String to = parser.getAttributeValue("", "to"); + final String from = parser.getAttributeValue("", "from"); + final IQ.Type type = IQ.Type.fromString(parser.getAttributeValue("", "type")); + boolean done = false; while (!done) { int eventType = parser.next();