Mercury-IM/Smack
Mercury-IM/Smack
1
0
Fork 0
mirror of https://codeberg.org/Mercury-IM/Smack synced 2024-12-22 20:47:57 +01:00
Code Issues Releases Wiki Activity

muc: synchronize Stats.create(Integer)

Browse source 
Since this method is used by the MUCUserProvider, it is potentially
invoked concurrently and the access to the statusMap must be
synchronized then.
This commit is contained in:
Florian Schmaus 2020-04-16 21:20:53 +02:00
parent fa643f12d5
commit e2e228fc93
1 changed files with 8 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
smack-extensions/src/main/java/org/jivesoftware/smackx/muc/packet/MUCUser.java
View file

@ -420,10 +420,14 @@ public class MUCUser implements ExtensionElement {
}
public static Status create(Integer i) {
Status status = statusMap.get(i);
if (status == null) {
status = new Status(i);
statusMap.put(i, status);
Status status;
// TODO: Use computeIfAbsent once Smack's minimum required Android SDK level is 24 or higher.
synchronized (statusMap) {
status = statusMap.get(i);
if (status == null) {
status = new Status(i);
statusMap.put(i, status);
}
}
return status;
}