From 2065b4e4edf8b09c7ba7e1ddb321e140922ae6fc Mon Sep 17 00:00:00 2001 From: Paul Schaub Date: Mon, 4 Apr 2022 13:08:24 +0200 Subject: [PATCH] Document planned removal of BCUtil.constantTimeAreEquals(char[], char[]) --- .../src/main/java/org/pgpainless/util/BCUtil.java | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/pgpainless-core/src/main/java/org/pgpainless/util/BCUtil.java b/pgpainless-core/src/main/java/org/pgpainless/util/BCUtil.java index 78e604c8..bb811cea 100644 --- a/pgpainless-core/src/main/java/org/pgpainless/util/BCUtil.java +++ b/pgpainless-core/src/main/java/org/pgpainless/util/BCUtil.java @@ -15,6 +15,11 @@ public final class BCUtil { * test will fail. For best results always pass the expected value * as the first parameter. * + * TODO: This method was proposed as a patch to BC: + * https://github.com/bcgit/bc-java/pull/1141 + * Replace usage of this method with upstream eventually. + * Remove once BC 172 gets released, given it contains the patch. + * * @param expected first array * @param supplied second array * @return true if arrays equal, false otherwise.