From 32e1b0c838c29e293baad5150dfb91627eeac644 Mon Sep 17 00:00:00 2001 From: Paul Schaub Date: Wed, 12 May 2021 12:56:07 +0200 Subject: [PATCH] KeyRingBuilder: Do not info-log exception when generated key has wrong length --- .../java/org/pgpainless/key/generation/KeyRingBuilder.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/pgpainless-core/src/main/java/org/pgpainless/key/generation/KeyRingBuilder.java b/pgpainless-core/src/main/java/org/pgpainless/key/generation/KeyRingBuilder.java index c732f487..ac0d8574 100644 --- a/pgpainless-core/src/main/java/org/pgpainless/key/generation/KeyRingBuilder.java +++ b/pgpainless-core/src/main/java/org/pgpainless/key/generation/KeyRingBuilder.java @@ -489,7 +489,8 @@ public class KeyRingBuilder implements KeyRingBuilderInterface { } catch (PGPException e) { // When generating EdDSA keys, the private key has an encoding length of 33 instead of 34, which results // in an exception. Therefore we just try again as a workaround. - LOGGER.log(Level.INFO, "Private key has wrong length. Try again.", e); + LOGGER.log(Level.INFO, "Generated private key encoding has incorrect length. Trying again."); + LOGGER.log(Level.FINER, "Incorrect private key encoding length is caused by a bug in Bouncycastle. See https://github.com/bcgit/bc-java/issues/887", e); pgpKeyPair = generateKeyPair(spec); } return pgpKeyPair;