From 4afc30c462c84492d8bb43698decdbca2d6a3ea5 Mon Sep 17 00:00:00 2001
From: Paul Schaub <vanitasvitae@fsfe.org>
Date: Wed, 21 Feb 2024 14:33:18 +0100
Subject: [PATCH] More tests

---
 .../key/generation/OpenPgpKeyGeneratorTest.kt | 25 +++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/pgpainless-core/src/test/kotlin/org/pgpainless/key/generation/OpenPgpKeyGeneratorTest.kt b/pgpainless-core/src/test/kotlin/org/pgpainless/key/generation/OpenPgpKeyGeneratorTest.kt
index 53411857..40a96dc2 100644
--- a/pgpainless-core/src/test/kotlin/org/pgpainless/key/generation/OpenPgpKeyGeneratorTest.kt
+++ b/pgpainless-core/src/test/kotlin/org/pgpainless/key/generation/OpenPgpKeyGeneratorTest.kt
@@ -414,4 +414,29 @@ class OpenPgpKeyGeneratorTest {
             .setPrimaryKey(KeyType.EDDSA(EdDSACurve._Ed25519))
             .addSubkey(KeyType.XDH(XDHSpec._X25519)) { addBindingSignature(bindingTime = t0) }
     }
+
+    @Test
+    fun `opinionated add subkey with weak binding signature hash algorithm fails`() {
+        val policy = Policy()
+
+        assertThrows<IllegalArgumentException> {
+            OpenPgpKeyGenerator.buildV4Key(policy)
+                .setPrimaryKey(KeyType.EDDSA(EdDSACurve._Ed25519))
+                .addSubkey(KeyType.XDH(XDHSpec._X25519)) {
+                    addBindingSignature(hashAlgorithm = HashAlgorithm.SHA1)
+                }
+        }
+    }
+
+    @Test
+    fun `unopinionated add subkey with weak binding signature hash algorithm is okay`() {
+        val policy = Policy()
+
+        OpenPgpKeyGenerator.buildV4Key(policy)
+            .setPrimaryKey(KeyType.EDDSA(EdDSACurve._Ed25519))
+            .unopinionated()
+            .addSubkey(KeyType.XDH(XDHSpec._X25519)) {
+                addBindingSignature(hashAlgorithm = HashAlgorithm.SHA1)
+            }
+    }
 }