From 620deaa1f9f63918c8de8a674f203b51da21af51 Mon Sep 17 00:00:00 2001 From: Paul Schaub Date: Sun, 27 Mar 2022 17:34:24 +0200 Subject: [PATCH] Deprecate ProducerOptions.setEncoding() The reason is that values other than BINARY oftentimes cause issues (see https://github.com/pgpainless/pgpainless/issues/264), and further experts recommended to ignore the metadata of the LiteralData packet and only produce with ('b'/0/) as metadata values. --- .../org/pgpainless/encryption_signing/ProducerOptions.java | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/pgpainless-core/src/main/java/org/pgpainless/encryption_signing/ProducerOptions.java b/pgpainless-core/src/main/java/org/pgpainless/encryption_signing/ProducerOptions.java index 3fe284c8..77901e34 100644 --- a/pgpainless-core/src/main/java/org/pgpainless/encryption_signing/ProducerOptions.java +++ b/pgpainless-core/src/main/java/org/pgpainless/encryption_signing/ProducerOptions.java @@ -230,7 +230,11 @@ public final class ProducerOptions { * * @param encoding encoding * @return this + * + * @deprecated this option will be removed in the near future, as values other than {@link StreamEncoding#BINARY} + * are causing issues. See https://github.com/pgpainless/pgpainless/issues/264 for details */ + @Deprecated public ProducerOptions setEncoding(@Nonnull StreamEncoding encoding) { this.streamEncoding = encoding; return this; @@ -239,6 +243,7 @@ public final class ProducerOptions { public StreamEncoding getEncoding() { return streamEncoding; } + /** * Override which compression algorithm shall be used. *