From 992432fc593d59481e9abecfb91526107d9b4902 Mon Sep 17 00:00:00 2001 From: Paul Schaub Date: Sun, 10 Jun 2018 17:55:51 +0200 Subject: [PATCH] Rename InputStreamFactory -> DecryptionStreamFactory --- .../DecryptionBuilder.java | 2 +- ...tory.java => DecryptionStreamFactory.java} | 15 +++-- .../crypto/pgpainless/EncryptDecryptTest.java | 57 +++++++++---------- 3 files changed, 36 insertions(+), 38 deletions(-) rename src/main/java/de/vanitasvitae/crypto/pgpainless/decryption_verification/{InputStreamFactory.java => DecryptionStreamFactory.java} (94%) diff --git a/src/main/java/de/vanitasvitae/crypto/pgpainless/decryption_verification/DecryptionBuilder.java b/src/main/java/de/vanitasvitae/crypto/pgpainless/decryption_verification/DecryptionBuilder.java index 72280036..86223e89 100644 --- a/src/main/java/de/vanitasvitae/crypto/pgpainless/decryption_verification/DecryptionBuilder.java +++ b/src/main/java/de/vanitasvitae/crypto/pgpainless/decryption_verification/DecryptionBuilder.java @@ -90,7 +90,7 @@ public class DecryptionBuilder implements DecryptionBuilderInterface { @Override public PainlessResult.ResultAndInputStream build() throws IOException, PGPException { - return InputStreamFactory.create(inputStream, + return DecryptionStreamFactory.create(inputStream, decryptionKeys, decryptionKeyDecryptor, verificationKeys, trustedKeyIds, missingPublicKeyCallback); } } diff --git a/src/main/java/de/vanitasvitae/crypto/pgpainless/decryption_verification/InputStreamFactory.java b/src/main/java/de/vanitasvitae/crypto/pgpainless/decryption_verification/DecryptionStreamFactory.java similarity index 94% rename from src/main/java/de/vanitasvitae/crypto/pgpainless/decryption_verification/InputStreamFactory.java rename to src/main/java/de/vanitasvitae/crypto/pgpainless/decryption_verification/DecryptionStreamFactory.java index 98d5c13e..1cfd8ba7 100644 --- a/src/main/java/de/vanitasvitae/crypto/pgpainless/decryption_verification/InputStreamFactory.java +++ b/src/main/java/de/vanitasvitae/crypto/pgpainless/decryption_verification/DecryptionStreamFactory.java @@ -35,7 +35,7 @@ import org.bouncycastle.openpgp.operator.bc.BcKeyFingerprintCalculator; import org.bouncycastle.openpgp.operator.bc.BcPGPContentVerifierBuilderProvider; import org.bouncycastle.openpgp.operator.bc.BcPublicKeyDataDecryptorFactory; -public class InputStreamFactory { +public class DecryptionStreamFactory { private final PGPSecretKeyRingCollection decryptionKeys; private final SecretKeyRingProtector decryptionKeyDecryptor; @@ -48,12 +48,11 @@ public class InputStreamFactory { private final KeyFingerPrintCalculator fingerCalc = new BcKeyFingerprintCalculator(); private final Map verifiableOnePassSignatures = new HashMap<>(); - private InputStreamFactory(PGPSecretKeyRingCollection decryptionKeys, - SecretKeyRingProtector decryptor, - Set verificationKeys, - Set trustedKeyIds, - MissingPublicKeyCallback missingPublicKeyCallback) - throws IOException { + private DecryptionStreamFactory(PGPSecretKeyRingCollection decryptionKeys, + SecretKeyRingProtector decryptor, + Set verificationKeys, + Set trustedKeyIds, + MissingPublicKeyCallback missingPublicKeyCallback) { this.decryptionKeys = decryptionKeys; this.decryptionKeyDecryptor = decryptor; this.verificationKeys.addAll(verificationKeys != null ? verificationKeys : Collections.emptyList()); @@ -69,7 +68,7 @@ public class InputStreamFactory { MissingPublicKeyCallback missingPublicKeyCallback) throws IOException, PGPException { - InputStreamFactory factory = new InputStreamFactory(decryptionKeys, + DecryptionStreamFactory factory = new DecryptionStreamFactory(decryptionKeys, decryptor, verificationKeys, trustedKeyIds, diff --git a/src/test/java/de/vanitasvitae/crypto/pgpainless/EncryptDecryptTest.java b/src/test/java/de/vanitasvitae/crypto/pgpainless/EncryptDecryptTest.java index 27380957..6a5e2d80 100644 --- a/src/test/java/de/vanitasvitae/crypto/pgpainless/EncryptDecryptTest.java +++ b/src/test/java/de/vanitasvitae/crypto/pgpainless/EncryptDecryptTest.java @@ -32,51 +32,50 @@ public class EncryptDecryptTest extends AbstractPGPainlessTest { private static final Charset UTF8 = Charset.forName("UTF-8"); @Test - public void freshRsaTest() + public void freshKeysRsaToRsaTest() throws PGPException, NoSuchAlgorithmException, NoSuchProviderException, InvalidAlgorithmParameterException, IOException { - PGPSecretKeyRing aliceSec = PGPainless.generateKeyRing().simpleRsaKeyRing("alice@wonderland.lit", RsaLength._4096); - PGPSecretKeyRing hatterSec = PGPainless.generateKeyRing().simpleRsaKeyRing("hatter@wonderland.lit", RsaLength._4096); + PGPSecretKeyRing sender = PGPainless.generateKeyRing().simpleRsaKeyRing("hatter@wonderland.lit", RsaLength._4096); + PGPSecretKeyRing recipient = PGPainless.generateKeyRing().simpleRsaKeyRing("alice@wonderland.lit", RsaLength._4096); - encryptDecryptForSecretKeyRings(aliceSec, hatterSec); + encryptDecryptForSecretKeyRings(sender, recipient); } @Test - public void freshEcTest() throws IOException, PGPException, NoSuchAlgorithmException, NoSuchProviderException, + public void freshKeysEcToEcTest() throws IOException, PGPException, NoSuchAlgorithmException, NoSuchProviderException, InvalidAlgorithmParameterException { - PGPSecretKeyRing aliceSec = PGPainless.generateKeyRing().simpleEcKeyRing("alice@wonderland.lit"); - PGPSecretKeyRing hatterSec = PGPainless.generateKeyRing().simpleEcKeyRing("hatter@wonderland.lit"); + PGPSecretKeyRing sender = PGPainless.generateKeyRing().simpleEcKeyRing("hatter@wonderland.lit"); + PGPSecretKeyRing recipient = PGPainless.generateKeyRing().simpleEcKeyRing("alice@wonderland.lit"); - encryptDecryptForSecretKeyRings(aliceSec, hatterSec); + encryptDecryptForSecretKeyRings(sender, recipient); } @Test - public void freshRsaEcTest() + public void freshKeysEcToRsaTest() throws PGPException, NoSuchAlgorithmException, NoSuchProviderException, InvalidAlgorithmParameterException, IOException { - PGPSecretKeyRing aliceSec = PGPainless.generateKeyRing().simpleRsaKeyRing("alice@wonderland.lit", RsaLength._4096); - PGPSecretKeyRing hatterSec = PGPainless.generateKeyRing().simpleEcKeyRing("hatter@wonderland.lit"); + PGPSecretKeyRing sender = PGPainless.generateKeyRing().simpleEcKeyRing("hatter@wonderland.lit"); + PGPSecretKeyRing recipient = PGPainless.generateKeyRing().simpleRsaKeyRing("alice@wonderland.lit", RsaLength._4096); - encryptDecryptForSecretKeyRings(aliceSec, hatterSec); + encryptDecryptForSecretKeyRings(sender, recipient); } @Test - public void freshEcRsaTest() + public void freshKeysRsaToEcTest() throws PGPException, NoSuchAlgorithmException, NoSuchProviderException, InvalidAlgorithmParameterException, IOException { - PGPSecretKeyRing aliceSec = PGPainless.generateKeyRing().simpleEcKeyRing("alice@wonderland.lit"); - PGPSecretKeyRing hatterSec = PGPainless.generateKeyRing().simpleRsaKeyRing("hatter@wonderland.lit", RsaLength._4096); + PGPSecretKeyRing sender = PGPainless.generateKeyRing().simpleRsaKeyRing("hatter@wonderland.lit", RsaLength._4096); + PGPSecretKeyRing recipient = PGPainless.generateKeyRing().simpleEcKeyRing("alice@wonderland.lit"); - - encryptDecryptForSecretKeyRings(aliceSec, hatterSec); + encryptDecryptForSecretKeyRings(sender, recipient); } @Ignore - private void encryptDecryptForSecretKeyRings(PGPSecretKeyRing aliceSec, PGPSecretKeyRing hatterSec) + private void encryptDecryptForSecretKeyRings(PGPSecretKeyRing sender, PGPSecretKeyRing recipient) throws PGPException, IOException { - PGPPublicKeyRing alicePub = BCUtil.publicKeyRingFromSecretKeyRing(aliceSec); - PGPPublicKeyRing hatterPub = BCUtil.publicKeyRingFromSecretKeyRing(hatterSec); + PGPPublicKeyRing recipientPub = BCUtil.publicKeyRingFromSecretKeyRing(recipient); + PGPPublicKeyRing senderPub = BCUtil.publicKeyRingFromSecretKeyRing(sender); SecretKeyRingProtector keyDecryptor = new UnprotectedKeysProtector(); @@ -87,16 +86,13 @@ public class EncryptDecryptTest extends AbstractPGPainlessTest { "Unfold the imagined happiness that both\n" + "Receive in either by this dear encounter.").getBytes(UTF8); - Logger.getLogger(EncryptDecryptTest.class.getName()) - .log(Level.INFO, " " + secretMessage.length); - ByteArrayOutputStream envelope = new ByteArrayOutputStream(); OutputStream encryptor = PGPainless.createEncryptor() .onOutputStream(envelope) - .toRecipients(Collections.singleton(alicePub)) + .toRecipients(Collections.singleton(recipientPub)) .usingSecureAlgorithms() - .signWith(hatterSec, keyDecryptor) + .signWith(sender, keyDecryptor) .noArmor(); Streams.pipeAll(new ByteArrayInputStream(secretMessage), encryptor); @@ -108,8 +104,8 @@ public class EncryptDecryptTest extends AbstractPGPainlessTest { ByteArrayInputStream envelopeIn = new ByteArrayInputStream(encryptedSecretMessage); PainlessResult.ResultAndInputStream resultAndInputStream = PGPainless.createDecryptor() .onInputStream(envelopeIn) - .decryptWith(BCUtil.keyRingsToKeyRingCollection(aliceSec), keyDecryptor) - .verifyWith(Collections.singleton(TestKeys.ROMEO_KEY_ID), BCUtil.keyRingsToKeyRingCollection(hatterPub)) + .decryptWith(BCUtil.keyRingsToKeyRingCollection(recipient), keyDecryptor) + .verifyWith(Collections.singleton(TestKeys.ROMEO_KEY_ID), BCUtil.keyRingsToKeyRingCollection(senderPub)) .ignoreMissingPublicKeys() .build(); @@ -120,8 +116,11 @@ public class EncryptDecryptTest extends AbstractPGPainlessTest { decryptor.close(); assertTrue(Arrays.equals(secretMessage, ((ByteArrayOutputStream) decryptedSecretMessage).toByteArray())); - PainlessResult result = resultAndInputStream.getResult(); - assertTrue(result.containsVerifiedSignatureFrom(hatterPub)); + assertTrue(result.containsVerifiedSignatureFrom(senderPub)); + assertTrue(result.isIntegrityProtected()); + assertTrue(result.isSigned()); + assertTrue(result.isEncrypted()); + assertTrue(result.isVerified()); } }