From fed3080ae8275305b396bbaedcfe37ed669c3ce9 Mon Sep 17 00:00:00 2001 From: Paul Schaub Date: Mon, 20 Jun 2022 18:19:24 +0200 Subject: [PATCH] Add tests to increase coverage of v5 fingerprint class --- .../key/OpenPgpV5FingerprintTest.java | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/pgpainless-core/src/test/java/org/pgpainless/key/OpenPgpV5FingerprintTest.java b/pgpainless-core/src/test/java/org/pgpainless/key/OpenPgpV5FingerprintTest.java index 2e657d72..b8c74b8b 100644 --- a/pgpainless-core/src/test/java/org/pgpainless/key/OpenPgpV5FingerprintTest.java +++ b/pgpainless-core/src/test/java/org/pgpainless/key/OpenPgpV5FingerprintTest.java @@ -8,6 +8,7 @@ import org.bouncycastle.util.encoders.Hex; import org.junit.jupiter.api.Test; import static org.junit.jupiter.api.Assertions.assertEquals; +import static org.junit.jupiter.api.Assertions.assertNotEquals; import static org.junit.jupiter.api.Assertions.assertThrows; import static org.junit.jupiter.api.Assertions.assertTrue; @@ -34,6 +35,7 @@ public class OpenPgpV5FingerprintTest { assertTrue(parsed instanceof OpenPgpV5Fingerprint); OpenPgpV5Fingerprint v5fp = (OpenPgpV5Fingerprint) parsed; assertEquals(prettyPrint, v5fp.prettyPrint()); + assertEquals(5, v5fp.getVersion()); } @Test @@ -44,6 +46,9 @@ public class OpenPgpV5FingerprintTest { OpenPgpFingerprint fingerprint = OpenPgpFingerprint.parseFromBinary(binary); assertTrue(fingerprint instanceof OpenPgpV5Fingerprint); assertEquals(hex, fingerprint.toString()); + + OpenPgpV5Fingerprint constructed = new OpenPgpV5Fingerprint(binary); + assertEquals(fingerprint, constructed); } @Test @@ -73,4 +78,18 @@ public class OpenPgpV5FingerprintTest { assertThrows(IllegalArgumentException.class, () -> OpenPgpFingerprint.parseFromBinary(binary)); } + + @Test + public void equalsTest() { + String prettyPrint = "76543210 ABCDEFAB 01AB23CD 1C0FFEE1 1EEFF0C1 DC32BA10 BAFEDCBA 01234567"; + OpenPgpFingerprint parsed = OpenPgpFingerprint.parse(prettyPrint); + + assertNotEquals(parsed, null); + assertNotEquals(parsed, new Object()); + assertEquals(parsed, parsed.toString()); + + OpenPgpFingerprint parsed2 = new OpenPgpV5Fingerprint(prettyPrint); + assertEquals(parsed.hashCode(), parsed2.hashCode()); + assertEquals(0, parsed.compareTo(parsed2)); + } }