From aa88904711becc0ae087e1be47251b3780bb416c Mon Sep 17 00:00:00 2001
From: Paul Schaub <vanitasvitae@fsfe.org>
Date: Thu, 27 Apr 2023 14:24:59 +0200
Subject: [PATCH] Add tests for Verification parsing

---
 .../java/sop/{util => }/VerificationTest.java | 20 ++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)
 rename sop-java/src/test/java/sop/{util => }/VerificationTest.java (83%)

diff --git a/sop-java/src/test/java/sop/util/VerificationTest.java b/sop-java/src/test/java/sop/VerificationTest.java
similarity index 83%
rename from sop-java/src/test/java/sop/util/VerificationTest.java
rename to sop-java/src/test/java/sop/VerificationTest.java
index c4f864e..c0b0cbc 100644
--- a/sop-java/src/test/java/sop/util/VerificationTest.java
+++ b/sop-java/src/test/java/sop/VerificationTest.java
@@ -2,17 +2,19 @@
 //
 // SPDX-License-Identifier: Apache-2.0
 
-package sop.util;
+package sop;
 
 import org.junit.jupiter.api.Test;
 import sop.Verification;
 import sop.enums.SignatureMode;
 import sop.testsuite.assertions.VerificationAssert;
+import sop.util.UTCUtil;
 
 import java.text.ParseException;
 import java.util.Date;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
+import static org.junit.jupiter.api.Assertions.assertThrows;
 
 public class VerificationTest {
 
@@ -89,4 +91,20 @@ public class VerificationTest {
                 .hasMode(null)
                 .hasDescription("certificate from dkg.asc");
     }
+
+    @Test
+    public void missingFingerprintFails() {
+        String string = "2022-11-07T15:01:24Z F9E6F53F7201C60A87064EAB0B27F2B0760A1209";
+        assertThrows(IllegalArgumentException.class, () -> Verification.fromString(string));
+    }
+
+    @Test
+    public void malformedTimestampFails() {
+        String shorter = "'99-11-07T15:01:24Z F9E6F53F7201C60A87064EAB0B27F2B0760A1209 4E2C78519512C2AE9A8BFE7EB3298EB2FBE5F51B";
+        assertThrows(IllegalArgumentException.class, () -> Verification.fromString(shorter));
+
+        String longer = "'99-11-07T15:01:24Z F9E6F53F7201C60A87064EAB0B27F2B0760A1209 4E2C78519512C2AE9A8BFE7EB3298EB2FBE5F51B mode:binary certificate from dkg.asc";
+        assertThrows(IllegalArgumentException.class, () -> Verification.fromString(longer));
+
+    }
 }