diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/filetransfer/FaultTolerantNegotiator.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/filetransfer/FaultTolerantNegotiator.java index 597e744ed..fe2639060 100644 --- a/smack-extensions/src/main/java/org/jivesoftware/smackx/filetransfer/FaultTolerantNegotiator.java +++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/filetransfer/FaultTolerantNegotiator.java @@ -40,13 +40,12 @@ public class FaultTolerantNegotiator extends StreamNegotiator { private final StreamNegotiator primaryNegotiator; private final StreamNegotiator secondaryNegotiator; - private final XMPPConnection connection; public FaultTolerantNegotiator(XMPPConnection connection, StreamNegotiator primary, StreamNegotiator secondary) { + super(connection); this.primaryNegotiator = primary; this.secondaryNegotiator = secondary; - this.connection = connection; } @Override @@ -64,7 +63,7 @@ public class FaultTolerantNegotiator extends StreamNegotiator { @Override public InputStream createIncomingStream(final StreamInitiation initiation) throws SmackException, XMPPErrorException, InterruptedException { // This could be either an xep47 ibb 'open' iq or an xep65 streamhost iq - IQ initationSet = initiateIncomingStream(connection, initiation); + IQ initationSet = initiateIncomingStream(connection(), initiation); StreamNegotiator streamNegotiator = determineNegotiator(initationSet); diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/filetransfer/IBBTransferNegotiator.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/filetransfer/IBBTransferNegotiator.java index 2e28455fa..17c46f515 100644 --- a/smack-extensions/src/main/java/org/jivesoftware/smackx/filetransfer/IBBTransferNegotiator.java +++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/filetransfer/IBBTransferNegotiator.java @@ -44,8 +44,6 @@ import org.jxmpp.jid.Jid; */ public class IBBTransferNegotiator extends StreamNegotiator { - private XMPPConnection connection; - private InBandBytestreamManager manager; /** @@ -54,7 +52,7 @@ public class IBBTransferNegotiator extends StreamNegotiator { * @param connection The connection which this negotiator works on. */ protected IBBTransferNegotiator(XMPPConnection connection) { - this.connection = connection; + super(connection); this.manager = InBandBytestreamManager.getByteStreamManager(connection); } @@ -75,7 +73,7 @@ public class IBBTransferNegotiator extends StreamNegotiator { */ this.manager.ignoreBytestreamRequestOnce(initiation.getSessionID()); - Stanza streamInitiation = initiateIncomingStream(this.connection, initiation); + Stanza streamInitiation = initiateIncomingStream(connection(), initiation); return negotiateIncomingStream(streamInitiation); } diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/filetransfer/Socks5TransferNegotiator.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/filetransfer/Socks5TransferNegotiator.java index 830812524..828c1b366 100644 --- a/smack-extensions/src/main/java/org/jivesoftware/smackx/filetransfer/Socks5TransferNegotiator.java +++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/filetransfer/Socks5TransferNegotiator.java @@ -43,13 +43,11 @@ import org.jxmpp.jid.Jid; */ public class Socks5TransferNegotiator extends StreamNegotiator { - private XMPPConnection connection; - private Socks5BytestreamManager manager; Socks5TransferNegotiator(XMPPConnection connection) { - this.connection = connection; - this.manager = Socks5BytestreamManager.getBytestreamManager(this.connection); + super(connection); + this.manager = Socks5BytestreamManager.getBytestreamManager(connection); } @Override @@ -75,7 +73,7 @@ public class Socks5TransferNegotiator extends StreamNegotiator { */ this.manager.ignoreBytestreamRequestOnce(initiation.getSessionID()); - Stanza streamInitiation = initiateIncomingStream(this.connection, initiation); + Stanza streamInitiation = initiateIncomingStream(connection(), initiation); return negotiateIncomingStream(streamInitiation); } diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/filetransfer/StreamNegotiator.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/filetransfer/StreamNegotiator.java index 0590d7aa8..da43866c9 100644 --- a/smack-extensions/src/main/java/org/jivesoftware/smackx/filetransfer/StreamNegotiator.java +++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/filetransfer/StreamNegotiator.java @@ -16,6 +16,7 @@ */ package org.jivesoftware.smackx.filetransfer; +import org.jivesoftware.smack.Manager; import org.jivesoftware.smack.SmackException; import org.jivesoftware.smack.SmackException.NoResponseException; import org.jivesoftware.smack.SmackException.NotConnectedException; @@ -42,7 +43,11 @@ import java.io.OutputStream; * * @author Alexander Wenckus */ -public abstract class StreamNegotiator { +public abstract class StreamNegotiator extends Manager { + + protected StreamNegotiator(XMPPConnection connection) { + super(connection); + } /** * A event manager for stream initiation requests send to us.