vanitasvitae/Smack
1
0
Fork 0
mirror of https://github.com/vanitasvitae/Smack.git synced 2024-11-23 04:22:05 +01:00
Code Issues Releases Wiki Activity

Remove PacketExtensionFilter(Class) constructor

Browse source 
as it's potential error prone, because most PacketExtension's don't
have a non-argument constructor required for this to work.

Also add some javadoc.
This commit is contained in:
Florian Schmaus 2014-12-09 13:58:23 +01:00
parent 9e9241c0b9
commit 1c08d1c594
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
smack-core/src/main/java/org/jivesoftware/smack/filter/PacketExtensionFilter.java
View file

@ -57,14 +57,15 @@ public class PacketExtensionFilter implements PacketFilter {
this(null, namespace); this(null, namespace);
} }
/**
* Creates a new packet extension filter for the given packet extension.
*
* @param packetExtension
*/
public PacketExtensionFilter(PacketExtension packetExtension) { public PacketExtensionFilter(PacketExtension packetExtension) {
this(packetExtension.getElementName(), packetExtension.getNamespace()); this(packetExtension.getElementName(), packetExtension.getNamespace());
} }
public PacketExtensionFilter(Class<? extends PacketExtension> packetExtensionClass) throws InstantiationException, IllegalAccessException {
this(packetExtensionClass.newInstance());
}
public boolean accept(Packet packet) { public boolean accept(Packet packet) {
return packet.hasExtension(elementName, namespace); return packet.hasExtension(elementName, namespace);
} }