From 1c0bdfae40f9c2f068795f023bbd0f31f0132a8d Mon Sep 17 00:00:00 2001 From: Florian Schmaus Date: Sun, 24 May 2020 18:01:00 +0200 Subject: [PATCH] [experimental] Delcare methods as static when possible --- .../smackx/fallback_indication/FallbackIndicationManager.java | 4 ++-- .../smackx/message_retraction/MessageRetractionManager.java | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/smack-experimental/src/main/java/org/jivesoftware/smackx/fallback_indication/FallbackIndicationManager.java b/smack-experimental/src/main/java/org/jivesoftware/smackx/fallback_indication/FallbackIndicationManager.java index da58e6ae9..25829bd63 100644 --- a/smack-experimental/src/main/java/org/jivesoftware/smackx/fallback_indication/FallbackIndicationManager.java +++ b/smack-experimental/src/main/java/org/jivesoftware/smackx/fallback_indication/FallbackIndicationManager.java @@ -139,7 +139,7 @@ public final class FallbackIndicationManager extends Manager { * @param fallbackMessageBody fallback message body * @return builder with set body and added fallback element */ - public MessageBuilder addFallbackIndicationWithBody(MessageBuilder messageBuilder, String fallbackMessageBody) { + public static MessageBuilder addFallbackIndicationWithBody(MessageBuilder messageBuilder, String fallbackMessageBody) { return addFallbackIndication(messageBuilder).setBody(fallbackMessageBody); } @@ -149,7 +149,7 @@ public final class FallbackIndicationManager extends Manager { * @param messageBuilder message builder * @return message builder with added fallback element */ - public MessageBuilder addFallbackIndication(MessageBuilder messageBuilder) { + public static MessageBuilder addFallbackIndication(MessageBuilder messageBuilder) { return messageBuilder.addExtension(new FallbackIndicationElement()); } diff --git a/smack-experimental/src/main/java/org/jivesoftware/smackx/message_retraction/MessageRetractionManager.java b/smack-experimental/src/main/java/org/jivesoftware/smackx/message_retraction/MessageRetractionManager.java index e5d211161..7fcac31de 100644 --- a/smack-experimental/src/main/java/org/jivesoftware/smackx/message_retraction/MessageRetractionManager.java +++ b/smack-experimental/src/main/java/org/jivesoftware/smackx/message_retraction/MessageRetractionManager.java @@ -102,7 +102,7 @@ public final class MessageRetractionManager extends Manager { * @param retractedMessageId {@link OriginIdElement OriginID} of the message that the user wants to retract * @param carrierMessageBuilder message used to transmit the message retraction to the recipient */ - public void addRetractionElementToMessage(OriginIdElement retractedMessageId, MessageBuilder carrierMessageBuilder) { + public static void addRetractionElementToMessage(OriginIdElement retractedMessageId, MessageBuilder carrierMessageBuilder) { FasteningElement fasteningElement = FasteningElement.builder() .setOriginId(retractedMessageId) .addWrappedPayload(new RetractElement())