From 1dae0c0c32e73035b47fd9efcf0e8695addf910b Mon Sep 17 00:00:00 2001 From: Florian Schmaus Date: Sat, 22 Jan 2022 11:08:35 +0100 Subject: [PATCH] [core] Use Enum.toString() in XmlStringBuilder.attribute(String, Enum) All other enum-using methods of XmlStringBuilder already use Enum.toString(), as opposed to Enum.name(), this was the only left. I do not remember why I did not to change this method too, probably because of its plenty call sites. But since this method already broke Jingle XML serializaton, JingleAction was e.g., 'session_accept' when it should be 'session-accept', we change it now. Fixes SMACK-921. --- .../java/org/jivesoftware/smack/util/XmlStringBuilder.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/smack-core/src/main/java/org/jivesoftware/smack/util/XmlStringBuilder.java b/smack-core/src/main/java/org/jivesoftware/smack/util/XmlStringBuilder.java index 5a1fae11f..20891c838 100644 --- a/smack-core/src/main/java/org/jivesoftware/smack/util/XmlStringBuilder.java +++ b/smack-core/src/main/java/org/jivesoftware/smack/util/XmlStringBuilder.java @@ -289,8 +289,7 @@ public class XmlStringBuilder implements Appendable, CharSequence, Element { public XmlStringBuilder attribute(String name, Enum value) { assert value != null; - // TODO: Should use toString() instead of name(). - attribute(name, value.name()); + attribute(name, value.toString()); return this; }