1
0
Fork 0
mirror of https://github.com/vanitasvitae/Smack.git synced 2024-12-22 10:37:59 +01:00

Fix getPresence ConcurrentModificationException

Fix for SMACK-841

Since Smack 4.2.4, the getPresencesInternal method in the Roster class
can return a LruCache object, which is a LinkedHashMap with access
order. This means that any access using get or getOrDefault will be a
modification of the Map. If you loop over the keySet of the Map and
there are more than one, the second call to get will throw a
ConcurrentModificationException!

Since the keys are only used here to obtain the corresponding
values, the simplest solution is to just loop over the values instead.
This commit is contained in:
spslinger 2018-10-11 12:29:32 +02:00 committed by GitHub
parent 1aa35bc957
commit 1e21ab763c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -951,8 +951,7 @@ public final class Roster extends Manager {
// This is used in case no available presence is found
Presence unavailable = null;
for (Resourcepart resource : userPresences.keySet()) {
Presence p = userPresences.get(resource);
for (Presence p : userPresences.values()) {
if (!p.isAvailable()) {
unavailable = p;
continue;