vanitasvitae/Smack
1
0
Fork 0
mirror of https://github.com/vanitasvitae/Smack.git synced 2024-11-26 05:52:06 +01:00
Code Issues Releases Wiki Activity

Deprecate setLegacySessionDisabled(boolean)

Browse source
This commit is contained in:
Florian Schmaus 2015-01-17 12:34:22 +01:00
parent 9ec7d628c8
commit 25bcb6b891
2 changed files with 13 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
smack-core/src/main/java/org/jivesoftware/smack/AbstractXMPPConnection.java
View file

@ -466,6 +466,8 @@ public abstract class AbstractXMPPConnection implements XMPPConnection {
return user; return user;
} }
// TODO remove this suppression once "disable legacy session" code has been removed from Smack
@SuppressWarnings("deprecation")
protected void bindResourceAndEstablishSession(String resource) throws XMPPErrorException, protected void bindResourceAndEstablishSession(String resource) throws XMPPErrorException,
IOException, SmackException { IOException, SmackException {

11
smack-core/src/main/java/org/jivesoftware/smack/ConnectionConfiguration.java
View file

@ -258,7 +258,10 @@ public abstract class ConnectionConfiguration {
* even mention this part of the protocol. * even mention this part of the protocol.
* *
* @return true if a session has to be requested when logging in. * @return true if a session has to be requested when logging in.
* @deprecated Smack processes the 'optional' element of the session stream feature.
* @see Builder#setLegacySessionDisabled(boolean)
*/ */
@Deprecated
public boolean isLegacySessionDisabled() { public boolean isLegacySessionDisabled() {
return legacySessionDisabled; return legacySessionDisabled;
} }
@ -581,10 +584,18 @@ public abstract class ConnectionConfiguration {
* Sets if a {@link Session} will be requested on login if the server supports * Sets if a {@link Session} will be requested on login if the server supports
* it. Although this was mandatory on RFC 3921, RFC 6120/6121 don't even * it. Although this was mandatory on RFC 3921, RFC 6120/6121 don't even
* mention this part of the protocol. * mention this part of the protocol.
* <p>
* Deprecation notice: This setting is no longer required in most cases because Smack processes the 'optional'
* element eventually found in the session stream feature. See also <a
* href="https://tools.ietf.org/html/draft-cridland-xmpp-session-01">Here Lies Extensible Messaging and Presence
* Protocol (XMPP) Session Establishment</a>
* </p>
* *
* @param legacySessionDisabled if a session has to be requested when logging in. * @param legacySessionDisabled if a session has to be requested when logging in.
* @return a reference to this builder. * @return a reference to this builder.
* @deprecated Smack processes the 'optional' element of the session stream feature.
*/ */
@Deprecated
public B setLegacySessionDisabled(boolean legacySessionDisabled) { public B setLegacySessionDisabled(boolean legacySessionDisabled) {
this.legacySessionDisabled = legacySessionDisabled; this.legacySessionDisabled = legacySessionDisabled;
return getThis(); return getThis();