[github ci] Build also with Java 21

.github/workflows/ci.yml

@@ -11,8 +11,9 @@ jobs:
       matrix:
         java:
           - 17
+          - 21
     env:
-      PRIMARY_JAVA_VERSION: 17
+      PRIMARY_JAVA_VERSION: 21
 
     steps:
       - name: Checkout

smack-core/src/main/java/org/jivesoftware/smack/AbstractXMPPConnection.java

@@ -388,6 +388,7 @@ public abstract class AbstractXMPPConnection implements XMPPConnection {
      *
      * @param configuration The configuration which is used to establish the connection.
      */
+    @SuppressWarnings("this-escape")
     protected AbstractXMPPConnection(ConnectionConfiguration configuration) {
         saslAuthentication = new SASLAuthentication(this, configuration);
         config = configuration;

smack-core/src/main/java/org/jivesoftware/smack/ConnectionConfiguration.java

@@ -672,6 +672,7 @@ public abstract class ConnectionConfiguration {
         private boolean compressionEnabled = false;
         private StanzaIdSourceFactory stanzaIdSourceFactory = new StandardStanzaIdSource.Factory();
 
+        @SuppressWarnings("this-escape")
         protected Builder() {
             if (SmackConfiguration.DEBUG) {
                 enableDefaultDebugger();

smack-core/src/main/java/org/jivesoftware/smack/c2s/ModularXmppClientToServerConnection.java

@@ -658,6 +658,7 @@ public final class ModularXmppClientToServerConnection extends AbstractXMPPConne
         updateOutgoingStreamXmlEnvironmentOnStreamOpen(streamOpen);
     }
 
+    @SuppressWarnings("this-escape")
     public static class DisconnectedStateDescriptor extends StateDescriptor {
         protected DisconnectedStateDescriptor() {
             super(DisconnectedState.class, StateDescriptor.Property.finalState);

smack-core/src/main/java/org/jivesoftware/smack/packet/EmptyResultIQ.java

@@ -1,6 +1,6 @@
 /**
  *
- * Copyright © 2014-2023 Florian Schmaus
+ * Copyright © 2014-2024 Florian Schmaus
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -23,6 +23,7 @@ public class EmptyResultIQ extends IQ {
     }
 
     // TODO: Deprecate when stanza builder and parsing logic is ready.
+    @SuppressWarnings("this-escape")
     public EmptyResultIQ() {
         super((String) null, null);
         setType(IQ.Type.result);

smack-core/src/main/java/org/jivesoftware/smack/packet/IQ.java

@@ -88,7 +88,7 @@ public abstract class IQ extends Stanza implements IqView {
     }
 
     @Override
-    public Type getType() {
+    public final Type getType() {
         return type;
     }
 

smack-core/src/main/java/org/jivesoftware/smack/packet/Session.java

@@ -39,6 +39,7 @@ public class Session extends SimpleIQ {
     public static final String ELEMENT = "session";
     public static final String NAMESPACE = "urn:ietf:params:xml:ns:xmpp-session";
 
+    @SuppressWarnings("this-escape")
     public Session() {
         super(ELEMENT, NAMESPACE);
         setType(IQ.Type.set);

smack-core/src/main/java/org/jivesoftware/smack/packet/Stanza.java

@@ -203,7 +203,7 @@ public abstract class Stanza implements StanzaView, TopLevelStreamElement {
      * @param to who the packet is being sent to.
      */
     // TODO: Mark this as deprecated once StanzaBuilder is ready and all call sites are gone.
-    public void setTo(Jid to) {
+    public final void setTo(Jid to) {
         this.to = to;
     }
 

smack-core/src/main/java/org/jivesoftware/smack/proxy/ProxyInfo.java

@@ -41,6 +41,7 @@ public class ProxyInfo {
     private ProxyType proxyType;
     private final ProxySocketConnection proxySocketConnection;
 
+    @SuppressWarnings("this-escape")
     public ProxyInfo(ProxyType pType, String pHost, int pPort, String pUser,
                         String pPass) {
         this.proxyType = pType;

smack-core/src/main/java/org/jivesoftware/smack/util/XmlStringBuilder.java

@@ -47,6 +47,7 @@ public class XmlStringBuilder implements Appendable, CharSequence, Element {
         this(pe, null);
     }
 
+    @SuppressWarnings("this-escape")
     public XmlStringBuilder(NamedElement e) {
         this();
         halfOpenElement(e.getElementName());
@@ -56,6 +57,7 @@ public class XmlStringBuilder implements Appendable, CharSequence, Element {
         this(element.getElementName(), element.getNamespace(), element.getLanguage(), enclosingXmlEnvironment);
     }
 
+    @SuppressWarnings("this-escape")
     public XmlStringBuilder(String elementName, String xmlNs, String xmlLang, XmlEnvironment enclosingXmlEnvironment) {
         sb = new LazyStringBuilder();
         halfOpenElement(elementName);

smack-core/src/testFixtures/java/org/jivesoftware/smack/DummyConnection.java

@@ -1,6 +1,6 @@
 /**
  *
- * Copyright 2010 Jive Software, 2022 Florian Schmaus.
+ * Copyright 2010 Jive Software, 2022-2024 Florian Schmaus.
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -82,6 +82,7 @@ public class DummyConnection extends AbstractXMPPConnection {
         }
     }
 
+    @SuppressWarnings("this-escape")
     public DummyConnection(DummyConnectionConfiguration configuration) {
         super(configuration);
 

smack-debug/src/main/java/org/jivesoftware/smackx/debugger/EnhancedDebugger.java

@@ -178,6 +178,7 @@ public class EnhancedDebugger extends SmackDebugger {
 
     JTabbedPane tabbedPane;
 
+    @SuppressWarnings("this-escape")
     public EnhancedDebugger(XMPPConnection connection) {
         super(connection);
 

smack-experimental/src/main/java/org/jivesoftware/smackx/carbons/packet/Carbon.java

@@ -1,6 +1,6 @@
 /**
  *
- * Copyright © 2014 Florian Schmaus
+ * Copyright © 2014-2024 Florian Schmaus
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -27,6 +27,7 @@ public class Carbon {
     public static class Enable extends SimpleIQ {
         public static final String ELEMENT = "enable";
 
+        @SuppressWarnings("this-escape")
         public Enable() {
             super(ELEMENT, NAMESPACE);
             setType(Type.set);
@@ -37,6 +38,7 @@ public class Carbon {
     public static class Disable extends SimpleIQ {
         public static final String ELEMENT = "disable";
 
+        @SuppressWarnings("this-escape")
         public Disable() {
             super(ELEMENT, NAMESPACE);
             setType(Type.set);

smack-experimental/src/main/java/org/jivesoftware/smackx/dox/element/DnsIq.java

@@ -1,6 +1,6 @@
 /**
  *
- * Copyright 2019 Florian Schmaus
+ * Copyright 2019-2024 Florian Schmaus
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -43,6 +43,7 @@ public class DnsIq extends IQ {
         this(new DnsMessage(dnsMessage));
     }
 
+    @SuppressWarnings("this-escape")
     public DnsIq(DnsMessage dnsQuery, Jid to) {
         this(dnsQuery);
         setTo(to);

smack-experimental/src/main/java/org/jivesoftware/smackx/httpfileupload/element/Slot.java

@@ -46,6 +46,7 @@ public class Slot extends IQ {
         this(putUrl, getUrl, headers, NAMESPACE);
     }
 
+    @SuppressWarnings("this-escape")
     protected Slot(URL putUrl, URL getUrl, Map<String, String> headers, String namespace) {
         super(ELEMENT, namespace);
         setType(Type.result);

smack-experimental/src/main/java/org/jivesoftware/smackx/httpfileupload/element/SlotRequest.java

@@ -53,6 +53,7 @@ public class SlotRequest extends IQ {
         this(uploadServiceAddress, filename, size, contentType, NAMESPACE);
     }
 
+    @SuppressWarnings("this-escape")
     protected SlotRequest(DomainBareJid uploadServiceAddress, String filename, long size, String contentType, String namespace) {
         super(ELEMENT, namespace);
 

smack-experimental/src/main/java/org/jivesoftware/smackx/iot/control/element/IoTSetRequest.java

@@ -1,6 +1,6 @@
 /**
  *
- * Copyright © 2016-2017 Florian Schmaus
+ * Copyright © 2016-2024 Florian Schmaus
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -29,6 +29,7 @@ public class IoTSetRequest extends IQ {
 
     private final Collection<SetData> setData;
 
+    @SuppressWarnings("this-escape")
     public IoTSetRequest(Collection<? extends SetData> setData) {
         super(ELEMENT, NAMESPACE);
         setType(Type.set);

smack-experimental/src/main/java/org/jivesoftware/smackx/iot/data/element/IoTDataReadOutAccepted.java

@@ -1,6 +1,6 @@
 /**
  *
- * Copyright © 2016 Florian Schmaus
+ * Copyright © 2016-2024 Florian Schmaus
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -30,6 +30,7 @@ public class IoTDataReadOutAccepted extends IQ {
 
     private final boolean queued;
 
+    @SuppressWarnings("this-escape")
     public IoTDataReadOutAccepted(int seqNr, boolean queued) {
         super(ELEMENT, NAMESPACE);
         this.seqNr = seqNr;
@@ -37,6 +38,7 @@ public class IoTDataReadOutAccepted extends IQ {
         setType(Type.result);
     }
 
+    @SuppressWarnings("this-escape")
     public IoTDataReadOutAccepted(IoTDataRequest dataRequest) {
         this(dataRequest.getSequenceNr(), false);
         setStanzaId(dataRequest.getStanzaId());

smack-experimental/src/main/java/org/jivesoftware/smackx/iot/discovery/element/IoTUnregister.java

@@ -1,6 +1,6 @@
 /**
  *
- * Copyright 2016 Florian Schmaus
+ * Copyright 2016-2024 Florian Schmaus
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -27,6 +27,7 @@ public class IoTUnregister extends IQ {
 
     private final NodeInfo nodeInfo;
 
+    @SuppressWarnings("this-escape")
     public IoTUnregister(NodeInfo nodeInfo) {
         super(ELEMENT, NAMESPACE);
         this.nodeInfo = nodeInfo;

smack-experimental/src/main/java/org/jivesoftware/smackx/iot/provisioning/element/ClearCache.java

@@ -1,6 +1,6 @@
 /**
  *
- * Copyright © 2016 Florian Schmaus
+ * Copyright © 2016-2024 Florian Schmaus
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -23,6 +23,7 @@ public class ClearCache extends SimpleIQ {
     public static final String ELEMENT = "clearCache";
     public static final String NAMESPACE = Constants.IOT_PROVISIONING_NAMESPACE;
 
+    @SuppressWarnings("this-escape")
     public ClearCache() {
         super(ELEMENT, NAMESPACE);
         // <clearCache/> IQs are always of type 'get' (XEP-0324 § 3.5.1, see also the XEPs history remarks)

smack-experimental/src/main/java/org/jivesoftware/smackx/iot/provisioning/element/ClearCacheResponse.java

@@ -1,6 +1,6 @@
 /**
  *
- * Copyright © 2016 Florian Schmaus
+ * Copyright © 2016-2024 Florian Schmaus
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -23,12 +23,14 @@ public class ClearCacheResponse extends SimpleIQ {
     public static final String ELEMENT = "clearCacheResponse";
     public static final String NAMESPACE = Constants.IOT_PROVISIONING_NAMESPACE;
 
+    @SuppressWarnings("this-escape")
     public ClearCacheResponse() {
         super(ELEMENT, NAMESPACE);
         // <clearCacheResponse/> IQs are always of type 'result' (XEP-0324 § 3.5.1, see also the XEPs history remarks)
         setType(Type.result);
     }
 
+    @SuppressWarnings("this-escape")
     public ClearCacheResponse(ClearCache clearCacheRequest) {
         this();
         setStanzaId(clearCacheRequest.getStanzaId());

smack-experimental/src/main/java/org/jivesoftware/smackx/mam/element/MamPrefsIQ.java

@@ -81,6 +81,7 @@ public class MamPrefsIQ extends IQ {
      * @param neverJids TODO javadoc me please
      * @param defaultBehavior TODO javadoc me please
      */
+    @SuppressWarnings("this-escape")
     public MamPrefsIQ(MamVersion version, List<Jid> alwaysJids, List<Jid> neverJids, DefaultBehavior defaultBehavior) {
         super(ELEMENT, version.getNamespace());
         setType(Type.set);

smack-experimental/src/main/java/org/jivesoftware/smackx/mam/element/MamQueryIQ.java

@@ -45,6 +45,7 @@ public class MamQueryIQ extends IQ {
      * @param version TODO javadoc me please
      * @param queryId TODO javadoc me please
      */
+    @SuppressWarnings("this-escape")
     public MamQueryIQ(MamVersion version, String queryId) {
         this(version, queryId, null, null);
         setType(IQ.Type.get);
@@ -79,6 +80,7 @@ public class MamQueryIQ extends IQ {
      * @param node TODO javadoc me please
      * @param dataForm TODO javadoc me please
      */
+    @SuppressWarnings("this-escape")
     public MamQueryIQ(MamVersion version, String queryId, String node, DataForm dataForm) {
         super(ELEMENT, version.getNamespace());
         this.queryId = queryId;

smack-experimental/src/main/java/org/jivesoftware/smackx/muclight/element/MUCLightAffiliationsIQ.java

@@ -48,6 +48,7 @@ public class MUCLightAffiliationsIQ extends IQ {
      * @param version TODO javadoc me please
      * @param affiliations TODO javadoc me please
      */
+    @SuppressWarnings("this-escape")
     public MUCLightAffiliationsIQ(String version, HashMap<Jid, MUCLightAffiliation> affiliations) {
         super(ELEMENT, NAMESPACE);
         this.version = version;

smack-experimental/src/main/java/org/jivesoftware/smackx/muclight/element/MUCLightChangeAffiliationsIQ.java

@@ -47,6 +47,7 @@ public class MUCLightChangeAffiliationsIQ extends IQ {
      * @param room TODO javadoc me please
      * @param affiliations TODO javadoc me please
      */
+    @SuppressWarnings("this-escape")
     public MUCLightChangeAffiliationsIQ(Jid room, HashMap<Jid, MUCLightAffiliation> affiliations) {
         super(ELEMENT, NAMESPACE);
         this.setType(Type.set);

smack-experimental/src/main/java/org/jivesoftware/smackx/muclight/element/MUCLightCreateIQ.java

@@ -53,6 +53,7 @@ public class MUCLightCreateIQ extends IQ {
      * @param customConfigs TODO javadoc me please
      * @param occupants TODO javadoc me please
      */
+    @SuppressWarnings("this-escape")
     public MUCLightCreateIQ(EntityJid room, String roomName, String subject, HashMap<String, String> customConfigs,
             List<Jid> occupants) {
         super(ELEMENT, NAMESPACE);

smack-experimental/src/main/java/org/jivesoftware/smackx/muclight/element/MUCLightDestroyIQ.java

@@ -38,6 +38,7 @@ public class MUCLightDestroyIQ extends IQ {
      *
      * @param roomJid TODO javadoc me please
      */
+    @SuppressWarnings("this-escape")
     public MUCLightDestroyIQ(Jid roomJid) {
         super(ELEMENT, NAMESPACE);
         this.setType(Type.set);

smack-experimental/src/main/java/org/jivesoftware/smackx/muclight/element/MUCLightGetAffiliationsIQ.java

@@ -41,6 +41,7 @@ public class MUCLightGetAffiliationsIQ extends IQ {
      * @param roomJid TODO javadoc me please
      * @param version TODO javadoc me please
      */
+    @SuppressWarnings("this-escape")
     public MUCLightGetAffiliationsIQ(Jid roomJid, String version) {
         super(ELEMENT, NAMESPACE);
         this.version = version;

smack-experimental/src/main/java/org/jivesoftware/smackx/muclight/element/MUCLightGetConfigsIQ.java

@@ -41,6 +41,7 @@ public class MUCLightGetConfigsIQ extends IQ {
      * @param roomJid TODO javadoc me please
      * @param version TODO javadoc me please
      */
+    @SuppressWarnings("this-escape")
     public MUCLightGetConfigsIQ(Jid roomJid, String version) {
         super(ELEMENT, NAMESPACE);
         this.version = version;

smack-experimental/src/main/java/org/jivesoftware/smackx/muclight/element/MUCLightGetInfoIQ.java

@@ -41,6 +41,7 @@ public class MUCLightGetInfoIQ extends IQ {
      * @param roomJid TODO javadoc me please
      * @param version TODO javadoc me please
      */
+    @SuppressWarnings("this-escape")
     public MUCLightGetInfoIQ(Jid roomJid, String version) {
         super(ELEMENT, NAMESPACE);
         this.version = version;

smack-experimental/src/main/java/org/jivesoftware/smackx/muclight/element/MUCLightSetConfigsIQ.java

@@ -49,6 +49,7 @@ public class MUCLightSetConfigsIQ extends IQ {
      * @param subject TODO javadoc me please
      * @param customConfigs TODO javadoc me please
      */
+    @SuppressWarnings("this-escape")
     public MUCLightSetConfigsIQ(Jid roomJid, String roomName, String subject, HashMap<String, String> customConfigs) {
         super(ELEMENT, NAMESPACE);
         this.roomName = roomName;

smack-experimental/src/main/java/org/jivesoftware/smackx/push_notifications/element/DisablePushNotificationsIQ.java

@@ -43,6 +43,7 @@ public class DisablePushNotificationsIQ extends IQ {
     private final Jid jid;
     private final String node;
 
+    @SuppressWarnings("this-escape")
     public DisablePushNotificationsIQ(Jid jid, String node) {
         super(ELEMENT, NAMESPACE);
         this.jid = jid;

smack-experimental/src/main/java/org/jivesoftware/smackx/push_notifications/element/EnablePushNotificationsIQ.java

@@ -53,6 +53,7 @@ public class EnablePushNotificationsIQ extends IQ {
     private final String node;
     private final HashMap<String, String> publishOptions;
 
+    @SuppressWarnings("this-escape")
     public EnablePushNotificationsIQ(Jid jid, String node, HashMap<String, String> publishOptions) {
         super(ELEMENT, NAMESPACE);
         this.jid = jid;

smack-extensions/src/main/java/org/jivesoftware/smackx/blocking/element/BlockContactsIQ.java

@@ -51,6 +51,7 @@ public class BlockContactsIQ extends IQ {
      *
      * @param jids TODO javadoc me please
      */
+    @SuppressWarnings("this-escape")
     public BlockContactsIQ(List<Jid> jids) {
         super(ELEMENT, NAMESPACE);
         this.setType(Type.set);

smack-extensions/src/main/java/org/jivesoftware/smackx/blocking/element/UnblockContactsIQ.java

@@ -52,6 +52,7 @@ public class UnblockContactsIQ extends IQ {
      *
      * @param jids TODO javadoc me please
      */
+    @SuppressWarnings("this-escape")
     public UnblockContactsIQ(List<Jid> jids) {
         super(ELEMENT, NAMESPACE);
         this.setType(Type.set);

smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/ibb/packet/Close.java

@@ -36,6 +36,7 @@ public class Close extends IQ {
      *
      * @param sessionID unique session ID identifying this In-Band Bytestream
      */
+    @SuppressWarnings("this-escape")
     public Close(String sessionID) {
         super(ELEMENT, NAMESPACE);
         if (sessionID == null || "".equals(sessionID)) {

smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/ibb/packet/Data.java

@@ -34,6 +34,7 @@ public class Data extends IQ {
      *
      * @param data data stanza extension containing the encoded data
      */
+    @SuppressWarnings("this-escape")
     public Data(DataPacketExtension data) {
         super(DataPacketExtension.ELEMENT, DataPacketExtension.NAMESPACE);
         if (data == null) {

smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/ibb/packet/Open.java

@@ -54,6 +54,7 @@ public class Open extends IQ {
      * @param blockSize block size in which the data will be fragmented
      * @param stanza stanza type used to encapsulate the data
      */
+    @SuppressWarnings("this-escape")
     public Open(String sessionID, int blockSize, StanzaType stanza) {
         super(ELEMENT, NAMESPACE);
         if (sessionID == null || "".equals(sessionID)) {

smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/socks5/Socks5Proxy.java

@@ -149,6 +149,7 @@ public class Socks5Proxy {
      *
      * @param serverSocket the server socket to use
      */
+    @SuppressWarnings("this-escape")
     protected Socks5Proxy(ServerSocket serverSocket) {
         this.serverProcess = new Socks5ServerProcess();
         this.serverSocket = serverSocket;

smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/socks5/packet/Bytestream.java

@@ -68,6 +68,7 @@ public class Bytestream extends IQ {
      * @param SID The session ID related to the negotiation.
      * @see #setSessionID(String)
      */
+    @SuppressWarnings("this-escape")
     public Bytestream(final String SID) {
         this();
         setSessionID(SID);

smack-extensions/src/main/java/org/jivesoftware/smackx/commands/AdHocCommandHandler.java

@@ -57,6 +57,7 @@ public abstract class AdHocCommandHandler extends AbstractAdHocCommand {
      */
     private int currentStage;
 
+    @SuppressWarnings("this-escape")
     public AdHocCommandHandler(String node, String name, String sessionId) {
         super(node, name);
         setSessionId(sessionId);

smack-extensions/src/main/java/org/jivesoftware/smackx/iqlast/packet/LastActivity.java

@@ -45,11 +45,13 @@ public class LastActivity extends IQ {
     public long lastActivity = -1;
     public String message;
 
+    @SuppressWarnings("this-escape")
     public LastActivity() {
         super(ELEMENT, NAMESPACE);
         setType(IQ.Type.get);
     }
 
+    @SuppressWarnings("this-escape")
     public LastActivity(Jid to) {
         this();
         setTo(to);

smack-extensions/src/main/java/org/jivesoftware/smackx/iqprivate/packet/PrivateDataIQ.java

@@ -1,6 +1,6 @@
 /**
  *
- * Copyright © 2014 Florian Schmaus
+ * Copyright 2014-2024 Florian Schmaus
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -27,11 +27,13 @@ public class PrivateDataIQ extends IQ {
     private final String getElement;
     private final String getNamespace;
 
+    @SuppressWarnings("this-escape")
     public PrivateDataIQ(PrivateData privateData) {
         this(privateData, null, null);
         setType(Type.set);
     }
 
+    @SuppressWarnings("this-escape")
     public PrivateDataIQ(String element, String namespace) {
         this(null, element, namespace);
         setType(Type.get);

smack-extensions/src/main/java/org/jivesoftware/smackx/jingle/transports/JingleTransportManager.java

@@ -30,6 +30,7 @@ public abstract class JingleTransportManager<D extends JingleContentTransport> i
 
     private final XMPPConnection connection;
 
+    @SuppressWarnings("this-escape")
     public JingleTransportManager(XMPPConnection connection) {
         this.connection = connection;
         connection.addConnectionListener(this);

smack-extensions/src/main/java/org/jivesoftware/smackx/ping/packet/Ping.java

@@ -1,6 +1,6 @@
 /**
  *
- * Copyright 2012-2019 Florian Schmaus
+ * Copyright 2012-2024 Florian Schmaus
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -32,6 +32,7 @@ public class Ping extends SimpleIQ {
         super(ELEMENT, NAMESPACE);
     }
 
+    @SuppressWarnings("this-escape")
     public Ping(Jid to) {
         this();
         setTo(to);

smack-extensions/src/main/java/org/jivesoftware/smackx/pubsub/packet/PubSub.java

@@ -43,6 +43,7 @@ public class PubSub extends IQ {
         super(ELEMENT, ns.getXmlns());
     }
 
+    @SuppressWarnings("this-escape")
     public PubSub(Jid to, Type type, PubSubNamespace ns) {
         super(ELEMENT, (ns == null ? PubSubNamespace.basic : ns).getXmlns());
         setTo(to);

smack-extensions/src/main/java/org/jivesoftware/smackx/time/packet/Time.java

@@ -1,6 +1,6 @@
 /**
  *
- * Copyright 2003-2007 Jive Software, 2014-2021 Florian Schmaus
+ * Copyright 2003-2007 Jive Software, 2014-2024 Florian Schmaus
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -46,6 +46,7 @@ public class Time extends IQ implements TimeView {
     private final String utc;
     private final String tzo;
 
+    @SuppressWarnings("this-escape")
     public Time(TimeBuilder timeBuilder) {
         super(timeBuilder, ELEMENT, NAMESPACE);
         utc = timeBuilder.getUtc();

smack-extensions/src/main/java/org/jivesoftware/smackx/xdata/form/FillableForm.java

@@ -49,6 +49,7 @@ public class FillableForm extends FilledForm {
 
     private final Map<String, FormField> filledFields = new HashMap<>();
 
+    @SuppressWarnings("this-escape")
     public FillableForm(DataForm dataForm) {
         super(dataForm);
         if (dataForm.getType() != DataForm.Type.form) {

smack-integration-test/src/main/java/org/jivesoftware/smack/StreamManagementTest.java

@@ -1,6 +1,6 @@
 /**
  *
- * Copyright 2015-2020 Florian Schmaus
+ * Copyright 2015-2024 Florian Schmaus
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -36,6 +36,7 @@ import org.jxmpp.jid.EntityFullJid;
 
 public class StreamManagementTest extends AbstractSmackSpecificLowLevelIntegrationTest<XMPPTCPConnection> {
 
+    @SuppressWarnings("this-escape")
     public StreamManagementTest(SmackIntegrationTestEnvironment environment) throws Exception {
         super(environment, XMPPTCPConnection.class);
         XMPPTCPConnection connection = getSpecificUnconnectedConnection();

smack-integration-test/src/main/java/org/jivesoftware/smackx/muc/MultiUserChatLowLevelIntegrationTest.java

@@ -42,6 +42,7 @@ import org.jxmpp.jid.parts.Resourcepart;
 @SpecificationReference(document = "XEP-0048", version = "1.2")
 public class MultiUserChatLowLevelIntegrationTest extends AbstractSmackLowLevelIntegrationTest {
 
+    @SuppressWarnings("this-escape")
     public MultiUserChatLowLevelIntegrationTest(SmackIntegrationTestEnvironment environment) throws Exception {
         super(environment);
         AbstractXMPPConnection connection = getConnectedConnection();

smack-jingle-old/src/main/java/org/jivesoftware/smackx/jingleold/mediaimpl/JMFInit.java

@@ -43,6 +43,7 @@ public class JMFInit extends Frame implements Runnable {
 
     private boolean visible = false;
 
+    @SuppressWarnings("this-escape")
     public JMFInit(String[] args, boolean visible) {
         super("Initializing JMF...");
 

smack-jingle-old/src/main/java/org/jivesoftware/smackx/jingleold/mediaimpl/jmf/AudioMediaSession.java

@@ -53,6 +53,7 @@ public class AudioMediaSession extends JingleMediaSession {
      * @param locator     media locator
      * @param jingleSession the jingle session.
      */
+    @SuppressWarnings("this-escape")
     public AudioMediaSession(final PayloadType payloadType, final TransportCandidate remote,
             final TransportCandidate local, String locator, JingleSession jingleSession) {
         super(payloadType, remote, local, locator == null ? "dsound://" : locator, jingleSession);

smack-jingle-old/src/main/java/org/jivesoftware/smackx/jingleold/mediaimpl/jspeex/AudioMediaSession.java

@@ -104,6 +104,7 @@ public class AudioMediaSession extends JingleMediaSession implements MediaSessio
      * @param locator     media locator
      * @param jingleSession the jingle session.
      */
+    @SuppressWarnings("this-escape")
     public AudioMediaSession(final PayloadType payloadType, final TransportCandidate remote,
             final TransportCandidate local, String locator, JingleSession jingleSession) {
         super(payloadType, remote, local, locator == null ? "dsound://" : locator, jingleSession);

smack-jingle-old/src/main/java/org/jivesoftware/smackx/jingleold/mediaimpl/sshare/ScreenShareSession.java

@@ -66,6 +66,7 @@ public class ScreenShareSession extends JingleMediaSession {
      * @param locator     media locator
      * @param jingleSession the jingle session.
      */
+    @SuppressWarnings("this-escape")
     public ScreenShareSession(final PayloadType payloadType, final TransportCandidate remote, final TransportCandidate local,
             final String locator, JingleSession jingleSession) {
         super(payloadType, remote, local, "Screen", jingleSession);

smack-jingle-old/src/main/java/org/jivesoftware/smackx/jingleold/mediaimpl/sshare/api/ImageReceiver.java

@@ -48,6 +48,7 @@ public class ImageReceiver extends Canvas {
     private int remotePort;
     private ImageDecoder decoder;
 
+    @SuppressWarnings("this-escape")
     public ImageReceiver(final InetAddress remoteHost, final int remotePort, final int localPort, int width, int height) {
         tiles = new BufferedImage[width][height];
 

smack-jingle-old/src/main/java/org/jivesoftware/smackx/jingleold/mediaimpl/sshare/api/OctTreeQuantizer.java

@@ -76,7 +76,7 @@ public class OctTreeQuantizer implements Quantizer {
     private int colors = 0;
     private final List<Vector<OctTreeNode>> colorList;
 
-    @SuppressWarnings("JdkObsolete")
+    @SuppressWarnings({"JdkObsolete", "this-escape"})
     public OctTreeQuantizer() {
         setup(256);
         colorList = new ArrayList<>(MAX_LEVEL + 1);

smack-jingle-old/src/main/java/org/jivesoftware/smackx/jingleold/mediaimpl/test/TestMediaSession.java

@@ -37,6 +37,7 @@ public class TestMediaSession extends JingleMediaSession {
      * @param locator     media locator
      * @param jingleSession the jingle session.
      */
+    @SuppressWarnings("this-escape")
     public TestMediaSession(final PayloadType payloadType, final TransportCandidate remote, final TransportCandidate local,
             final String locator, JingleSession jingleSession) {
         super(payloadType, remote, local, "Test", jingleSession);

smack-jingle-old/src/main/java/org/jivesoftware/smackx/jingleold/nat/FixedResolver.java

@@ -38,6 +38,7 @@ public class FixedResolver extends TransportResolver {
      * @param ip the IP address.
      * @param port the port number.
      */
+    @SuppressWarnings("this-escape")
     public FixedResolver(String ip, int port) {
         super();
         setFixedCandidate(ip, port);

smack-jingle-old/src/main/java/org/jivesoftware/smackx/jingleold/nat/ICEResolver.java

@@ -56,6 +56,7 @@ public class ICEResolver extends TransportResolver {
     static Map<String, ICENegociator> negociatorsMap = new HashMap<>();
     // ICENegociator iceNegociator = null;
 
+    @SuppressWarnings("this-escape")
     public ICEResolver(XMPPConnection connection, String server, int port) {
         super();
         this.connection = connection;

smack-jingle-old/src/main/java/org/jivesoftware/smackx/jingleold/nat/TcpUdpBridgeClient.java

@@ -45,6 +45,7 @@ public class TcpUdpBridgeClient {
     private DatagramSocket localUdpSocket;
     private Socket localTcpSocket;
 
+    @SuppressWarnings("this-escape")
     public TcpUdpBridgeClient(String remoteTcpHost, String remoteUdpHost, int remoteTcpPort, int remoteUdpPort) {
         this.remoteTcpHost = remoteTcpHost;
         this.remoteUdpHost = remoteUdpHost;

smack-jingle-old/src/main/java/org/jivesoftware/smackx/jingleold/nat/TcpUdpBridgeServer.java

@@ -48,6 +48,7 @@ public class TcpUdpBridgeServer {
     private Socket localTcpSocket;
     private ServerSocket serverTcpSocket;
 
+    @SuppressWarnings("this-escape")
     public TcpUdpBridgeServer(String remoteTcpHost, String remoteUdpHost, int remoteTcpPort, int remoteUdpPort) {
         this.remoteTcpHost = remoteTcpHost;
         this.remoteUdpHost = remoteUdpHost;

smack-jingle-old/src/main/java/org/jivesoftware/smackx/jingleold/packet/Jingle.java

@@ -71,6 +71,7 @@ public class Jingle extends IQ {
      * @param mi the jingle content info
      * @param sid the sid.
      */
+    @SuppressWarnings("this-escape")
     public Jingle(final List<JingleContent> contents, final JingleContentInfo mi,
                   final String sid) {
         this();
@@ -93,6 +94,7 @@ public class Jingle extends IQ {
      *
      * @param content a content
      */
+    @SuppressWarnings("this-escape")
     public Jingle(final JingleContent content) {
         this();
 
@@ -112,6 +114,7 @@ public class Jingle extends IQ {
      *
      * @param info The content info
      */
+    @SuppressWarnings("this-escape")
     public Jingle(final JingleContentInfo info) {
         this();
 
@@ -131,6 +134,7 @@ public class Jingle extends IQ {
      *
      * @param action The action.
      */
+    @SuppressWarnings("this-escape")
     public Jingle(final JingleActionEnum action) {
         this(null, null, null);
         this.action = action;

smack-jingle-old/src/main/java/org/jivesoftware/smackx/jingleold/packet/JingleContentDescription.java

@@ -184,6 +184,7 @@ public abstract class JingleContentDescription implements ExtensionElement {
          *
          * @param pt the payload type.
          */
+        @SuppressWarnings("this-escape")
         public Audio(final JinglePayloadType pt) {
             super();
             addJinglePayloadType(pt);

smack-jingle-old/src/main/java/org/jivesoftware/smackx/jingleold/packet/JingleContentInfo.java

@@ -99,6 +99,7 @@ public class JingleContentInfo implements ExtensionElement {
 
         public static final String NAMESPACE = "urn:xmpp:tmp:jingle:apps:rtp";
 
+        @SuppressWarnings("this-escape")
         public Audio(final ContentInfo mi) {
             super(mi);
             setNamespace(NAMESPACE);

smack-jingle-old/src/main/java/org/jivesoftware/smackx/jingleold/packet/JingleDescription.java

@@ -191,6 +191,7 @@ public abstract class JingleDescription implements ExtensionElement {
          *
          * @param pt the payload type.
          */
+        @SuppressWarnings("this-escape")
         public Audio(final PayloadType pt) {
             super();
             addPayloadType(pt);

smack-jingle-old/src/main/java/org/jivesoftware/smackx/jingleold/packet/JingleTransport.java

@@ -55,6 +55,7 @@ public class JingleTransport implements ExtensionElement {
      *
      * @param candidate A transport candidate element to add.
      */
+    @SuppressWarnings("this-escape")
     public JingleTransport(final JingleTransportCandidate candidate) {
         super();
         addCandidate(candidate);
@@ -202,6 +203,7 @@ public class JingleTransport implements ExtensionElement {
          *
          * @param candidate the jmf transport candidate
          */
+        @SuppressWarnings("this-escape")
         public JingleTransportCandidate(final TransportCandidate candidate) {
             super();
             setMediaTransport(candidate);
@@ -272,6 +274,7 @@ public class JingleTransport implements ExtensionElement {
     public static class Ice extends JingleTransport {
         public static final String NAMESPACE = "urn:xmpp:tmp:jingle:transports:ice-udp";
 
+        @SuppressWarnings("this-escape")
         public Ice() {
             super();
             setNamespace(NAMESPACE);
@@ -359,6 +362,7 @@ public class JingleTransport implements ExtensionElement {
     public static class RawUdp extends JingleTransport {
         public static final String NAMESPACE = "http://www.xmpp.org/extensions/xep-0177.html#ns";
 
+        @SuppressWarnings("this-escape")
         public RawUdp() {
             super();
             setNamespace(NAMESPACE);

smack-legacy/src/main/java/org/jivesoftware/smackx/workgroup/packet/DepartQueuePacket.java

@@ -53,6 +53,7 @@ public class DepartQueuePacket extends IQ {
      * @param workgroup the workgroup to depart.
      * @param user the user to make depart from the queue.
      */
+    @SuppressWarnings("this-escape")
     public DepartQueuePacket(EntityBareJid workgroup, EntityJid user) {
         super("depart-queue", "http://jabber.org/protocol/workgroup");
         this.user = user;

smack-legacy/src/main/java/org/jivesoftware/smackx/workgroup/settings/ChatSetting.java

@@ -22,6 +22,7 @@ public class ChatSetting {
     private String value;
     private int type;
 
+    @SuppressWarnings("this-escape")
     public ChatSetting(String key, String value, int type) {
         setKey(key);
         setValue(value);

smack-legacy/src/main/java/org/jivesoftware/smackx/workgroup/settings/ChatSettings.java

@@ -66,6 +66,7 @@ public class ChatSettings extends IQ {
         settings = new ArrayList<>();
     }
 
+    @SuppressWarnings("this-escape")
     public ChatSettings(String key) {
         this();
         setKey(key);

smack-legacy/src/main/java/org/jivesoftware/smackx/workgroup/user/Workgroup.java

@@ -99,6 +99,7 @@ public class Workgroup {
      * @param connection   an XMPP connection which must have already undergone a
      *                     successful login.
      */
+    @SuppressWarnings("this-escape")
     public Workgroup(EntityBareJid workgroupJID, XMPPConnection connection) {
         // Login must have been done before passing in connection.
         if (!connection.isAuthenticated()) {

smack-legacy/src/main/java/org/jivesoftware/smackx/xroster/packet/RosterExchange.java

@@ -70,6 +70,7 @@ public class RosterExchange implements ExtensionElement {
      *
      * @param roster the roster to send to other XMPP entity.
      */
+    @SuppressWarnings("this-escape")
     public RosterExchange(Roster roster) {
         // Add all the roster entries to the new RosterExchange
         for (RosterEntry rosterEntry : roster.getEntries()) {

smack-tcp/src/main/java/org/jivesoftware/smack/tcp/XMPPTCPConnection.java

@@ -294,6 +294,7 @@ public class XMPPTCPConnection extends AbstractXMPPConnection {
      *
      * @param config the connection configuration.
      */
+    @SuppressWarnings("this-escape")
     public XMPPTCPConnection(XMPPTCPConnectionConfiguration config) {
         super(config);
         this.config = config;