From 35cf094386ea0bcfd617c57e8f0ad4fec9d08b87 Mon Sep 17 00:00:00 2001 From: Florian Schmaus Date: Wed, 25 Sep 2019 23:36:21 +0200 Subject: [PATCH] sasl-javax: Do not set system properties in SASLGSSAPIMechanism Smack did this for a long time, since eb56f8a55 ("GSSAPI work by Jay Kline (SMACK-218)."). Not always in a static block though. But irregardless this is bad practice as it causes side-effects and may overrides settings. For example, one users reports: java.lang.SecurityException: java.io.IOException: gss.conf (No such file or directory) at sun.security.provider.ConfigFile$Spi.(ConfigFile.java:137) at sun.security.provider.ConfigFile.(ConfigFile.java:102) at sun.reflect.GeneratedConstructorAccessor119.newInstance(Unknown Source) --- .../jivesoftware/smack/sasl/javax/SASLGSSAPIMechanism.java | 5 ----- 1 file changed, 5 deletions(-) diff --git a/smack-sasl-javax/src/main/java/org/jivesoftware/smack/sasl/javax/SASLGSSAPIMechanism.java b/smack-sasl-javax/src/main/java/org/jivesoftware/smack/sasl/javax/SASLGSSAPIMechanism.java index e7e145c37..210e94ab9 100644 --- a/smack-sasl-javax/src/main/java/org/jivesoftware/smack/sasl/javax/SASLGSSAPIMechanism.java +++ b/smack-sasl-javax/src/main/java/org/jivesoftware/smack/sasl/javax/SASLGSSAPIMechanism.java @@ -29,11 +29,6 @@ public class SASLGSSAPIMechanism extends SASLJavaXMechanism { public static final String NAME = GSSAPI; - static { - System.setProperty("javax.security.auth.useSubjectCredsOnly", "false"); - System.setProperty("java.security.auth.login.config", "gss.conf"); - } - @Override public boolean authzidSupported() { return true;