From 382057f520d4b3142bb0b3e2407bceace0f303d1 Mon Sep 17 00:00:00 2001
From: Florian Schmaus <flo@geekplace.eu>
Date: Sun, 21 Oct 2018 09:01:54 +0200
Subject: [PATCH] Make Nick immutable

---
 .../org/jivesoftware/smackx/nick/packet/Nick.java | 15 +++------------
 1 file changed, 3 insertions(+), 12 deletions(-)

diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/nick/packet/Nick.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/nick/packet/Nick.java
index 34be6b83f..c9cfd4486 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/nick/packet/Nick.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/nick/packet/Nick.java
@@ -20,6 +20,7 @@ import java.io.IOException;
 
 import org.jivesoftware.smack.packet.ExtensionElement;
 import org.jivesoftware.smack.provider.ExtensionElementProvider;
+import org.jivesoftware.smack.util.StringUtils;
 import org.jivesoftware.smack.util.XmlStringBuilder;
 
 import org.xmlpull.v1.XmlPullParser;
@@ -37,10 +38,10 @@ public class Nick implements ExtensionElement {
 
     public static final String ELEMENT_NAME = "nick";
 
-    private String name = null;
+    private final String name;
 
     public Nick(String name) {
-        this.name = name;
+        this.name = StringUtils.requireNotNullNorEmpty(name, "Nickname must be given");
     }
 
     /**
@@ -52,16 +53,6 @@ public class Nick implements ExtensionElement {
         return name;
     }
 
-    /**
-     * Sets the value of this nickname.
-     *
-     * @param name
-     *            the name to set
-     */
-    public void setName(String name) {
-        this.name = name;
-    }
-
     @Override
     public String getElementName() {
         return ELEMENT_NAME;