From 439f4cd2917ed18bddbad046350ab91f2f82870d Mon Sep 17 00:00:00 2001 From: Florian Schmaus Date: Wed, 23 Apr 2014 09:43:48 +0200 Subject: [PATCH] Use volatile instead of synchronized in LastActivityManager. --- .../smackx/iqlast/LastActivityManager.java | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/extensions/src/main/java/org/jivesoftware/smackx/iqlast/LastActivityManager.java b/extensions/src/main/java/org/jivesoftware/smackx/iqlast/LastActivityManager.java index 6229d9ac6..6d4b38b03 100644 --- a/extensions/src/main/java/org/jivesoftware/smackx/iqlast/LastActivityManager.java +++ b/extensions/src/main/java/org/jivesoftware/smackx/iqlast/LastActivityManager.java @@ -118,7 +118,7 @@ public class LastActivityManager extends Manager { return lastActivityManager; } - private long lastMessageSent; + private volatile long lastMessageSent; private boolean enabled = false; /** @@ -197,10 +197,7 @@ public class LastActivityManager extends Manager { * sent. */ private void resetIdleTime() { - long now = System.currentTimeMillis(); - synchronized (this) { - lastMessageSent = now; - } + lastMessageSent = System.currentTimeMillis(); } /** @@ -209,11 +206,8 @@ public class LastActivityManager extends Manager { * @return the lapsed time between the last message sent and now. */ private long getIdleTime() { - long lms; + long lms = lastMessageSent; long now = System.currentTimeMillis(); - synchronized (this) { - lms = lastMessageSent; - } return ((now - lms) / 1000); }