From 450015bf40f3d87f63da39b6e846e367e87d967f Mon Sep 17 00:00:00 2001 From: Florian Schmaus Date: Thu, 14 Aug 2014 22:25:52 +0200 Subject: [PATCH] Make Bookmarks.toXML() return valid XML again Fixes SMACK-594 --- .../java/org/jivesoftware/smackx/bookmarks/Bookmarks.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/bookmarks/Bookmarks.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/bookmarks/Bookmarks.java index 10fdb2c2d..6c1dfe599 100644 --- a/smack-extensions/src/main/java/org/jivesoftware/smackx/bookmarks/Bookmarks.java +++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/bookmarks/Bookmarks.java @@ -169,13 +169,13 @@ public class Bookmarks implements PrivateData { @Override public XmlStringBuilder toXML() { XmlStringBuilder buf = new XmlStringBuilder(); - buf.openElement(ELEMENT).xmlnsAttribute(NAMESPACE); + buf.halfOpenElement(ELEMENT).xmlnsAttribute(NAMESPACE).rightAngelBracket(); for (BookmarkedURL urlStorage : getBookmarkedURLS()) { if(urlStorage.isShared()) { continue; } - buf.openElement("url").attribute("name", urlStorage.getName()).attribute("url", urlStorage.getURL()); + buf.halfOpenElement("url").attribute("name", urlStorage.getName()).attribute("url", urlStorage.getURL()); buf.condAttribute(urlStorage.isRss(), "rss", "true"); buf.closeEmptyElement(); } @@ -185,7 +185,7 @@ public class Bookmarks implements PrivateData { if(conference.isShared()) { continue; } - buf.openElement("conference"); + buf.halfOpenElement("conference"); buf.attribute("name", conference.getName()); buf.attribute("autojoin", Boolean.toString(conference.isAutoJoin())); buf.attribute("jid", conference.getJid());