diff --git a/smack-omemo-signal/src/main/java/org/jivesoftware/smackx/omemo/signal/SignalFileBasedOmemoStore.java b/smack-omemo-signal/src/main/java/org/jivesoftware/smackx/omemo/signal/SignalFileBasedOmemoStore.java index 014da93ae..f952dbe44 100644 --- a/smack-omemo-signal/src/main/java/org/jivesoftware/smackx/omemo/signal/SignalFileBasedOmemoStore.java +++ b/smack-omemo-signal/src/main/java/org/jivesoftware/smackx/omemo/signal/SignalFileBasedOmemoStore.java @@ -55,8 +55,7 @@ public class SignalFileBasedOmemoStore } @Override - public OmemoKeyUtil keyUtil() + public OmemoKeyUtil keyUtil() { return new SignalOmemoKeyUtil(); } diff --git a/smack-omemo-signal/src/main/java/org/jivesoftware/smackx/omemo/signal/SignalOmemoKeyUtil.java b/smack-omemo-signal/src/main/java/org/jivesoftware/smackx/omemo/signal/SignalOmemoKeyUtil.java index e800dfbfc..33c129070 100644 --- a/smack-omemo-signal/src/main/java/org/jivesoftware/smackx/omemo/signal/SignalOmemoKeyUtil.java +++ b/smack-omemo-signal/src/main/java/org/jivesoftware/smackx/omemo/signal/SignalOmemoKeyUtil.java @@ -33,8 +33,6 @@ import org.jivesoftware.smackx.omemo.util.OmemoKeyUtil; import org.whispersystems.libsignal.IdentityKey; import org.whispersystems.libsignal.IdentityKeyPair; import org.whispersystems.libsignal.InvalidKeyException; -import org.whispersystems.libsignal.SessionCipher; -import org.whispersystems.libsignal.SignalProtocolAddress; import org.whispersystems.libsignal.ecc.Curve; import org.whispersystems.libsignal.ecc.ECPublicKey; import org.whispersystems.libsignal.state.PreKeyBundle; @@ -49,7 +47,7 @@ import org.whispersystems.libsignal.util.KeyHelper; * @author Paul Schaub */ public class SignalOmemoKeyUtil extends OmemoKeyUtil + SessionRecord, ECPublicKey, PreKeyBundle> { @Override public IdentityKeyPair generateOmemoIdentityKeyPair() { diff --git a/smack-omemo-signal/src/main/java/org/jivesoftware/smackx/omemo/signal/SignalOmemoStore.java b/smack-omemo-signal/src/main/java/org/jivesoftware/smackx/omemo/signal/SignalOmemoStore.java index 38cd5a6d1..bde4f802a 100644 --- a/smack-omemo-signal/src/main/java/org/jivesoftware/smackx/omemo/signal/SignalOmemoStore.java +++ b/smack-omemo-signal/src/main/java/org/jivesoftware/smackx/omemo/signal/SignalOmemoStore.java @@ -46,8 +46,7 @@ public abstract class SignalOmemoStore private final SignalOmemoKeyUtil signalKeyUtil = new SignalOmemoKeyUtil(); @Override - public OmemoKeyUtil keyUtil() { + public OmemoKeyUtil keyUtil() { return signalKeyUtil; } } diff --git a/smack-omemo-signal/src/test/java/org/jivesoftware/smack/omemo/SignalOmemoKeyUtilTest.java b/smack-omemo-signal/src/test/java/org/jivesoftware/smack/omemo/SignalOmemoKeyUtilTest.java index ddafffda8..a296b5681 100644 --- a/smack-omemo-signal/src/test/java/org/jivesoftware/smack/omemo/SignalOmemoKeyUtilTest.java +++ b/smack-omemo-signal/src/test/java/org/jivesoftware/smack/omemo/SignalOmemoKeyUtilTest.java @@ -31,8 +31,6 @@ import org.junit.runner.RunWith; import org.junit.runners.Parameterized; import org.whispersystems.libsignal.IdentityKey; import org.whispersystems.libsignal.IdentityKeyPair; -import org.whispersystems.libsignal.SessionCipher; -import org.whispersystems.libsignal.SignalProtocolAddress; import org.whispersystems.libsignal.ecc.ECPublicKey; import org.whispersystems.libsignal.state.PreKeyBundle; import org.whispersystems.libsignal.state.PreKeyRecord; @@ -46,10 +44,9 @@ import org.whispersystems.libsignal.state.SignedPreKeyRecord; */ @RunWith(value = Parameterized.class) public class SignalOmemoKeyUtilTest - extends OmemoKeyUtilTest { + extends OmemoKeyUtilTest { - public SignalOmemoKeyUtilTest(OmemoKeyUtil keyUtil) { + public SignalOmemoKeyUtilTest(OmemoKeyUtil keyUtil) { super(keyUtil); } diff --git a/smack-omemo/src/main/java/org/jivesoftware/smackx/omemo/CachingOmemoStore.java b/smack-omemo/src/main/java/org/jivesoftware/smackx/omemo/CachingOmemoStore.java index 5156dd66b..92b67111a 100644 --- a/smack-omemo/src/main/java/org/jivesoftware/smackx/omemo/CachingOmemoStore.java +++ b/smack-omemo/src/main/java/org/jivesoftware/smackx/omemo/CachingOmemoStore.java @@ -52,9 +52,9 @@ public class CachingOmemoStore> caches = new HashMap<>(); private final OmemoStore persistent; - private final OmemoKeyUtil keyUtil; + private final OmemoKeyUtil keyUtil; - public CachingOmemoStore(OmemoKeyUtil keyUtil) { + public CachingOmemoStore(OmemoKeyUtil keyUtil) { if (keyUtil == null) { throw new IllegalArgumentException("KeyUtil MUST NOT be null!"); } @@ -379,7 +379,7 @@ public class CachingOmemoStore + public OmemoKeyUtil keyUtil() { if (persistent != null) { return persistent.keyUtil(); diff --git a/smack-omemo/src/main/java/org/jivesoftware/smackx/omemo/OmemoService.java b/smack-omemo/src/main/java/org/jivesoftware/smackx/omemo/OmemoService.java index 50c860590..e1b3b5ad4 100644 --- a/smack-omemo/src/main/java/org/jivesoftware/smackx/omemo/OmemoService.java +++ b/smack-omemo/src/main/java/org/jivesoftware/smackx/omemo/OmemoService.java @@ -166,8 +166,7 @@ public abstract class OmemoService omemoStore) - { + OmemoStore omemoStore) { if (this.omemoStore != null) { throw new IllegalStateException("An OmemoStore backend has already been set."); } diff --git a/smack-omemo/src/main/java/org/jivesoftware/smackx/omemo/OmemoStore.java b/smack-omemo/src/main/java/org/jivesoftware/smackx/omemo/OmemoStore.java index b648a27d1..9112f6e29 100644 --- a/smack-omemo/src/main/java/org/jivesoftware/smackx/omemo/OmemoStore.java +++ b/smack-omemo/src/main/java/org/jivesoftware/smackx/omemo/OmemoStore.java @@ -518,7 +518,7 @@ public abstract class OmemoStore keyUtil(); + public abstract OmemoKeyUtil keyUtil(); /** * Return our identityKeys fingerprint. diff --git a/smack-omemo/src/main/java/org/jivesoftware/smackx/omemo/util/OmemoKeyUtil.java b/smack-omemo/src/main/java/org/jivesoftware/smackx/omemo/util/OmemoKeyUtil.java index d4672b80c..ba045cc2e 100644 --- a/smack-omemo/src/main/java/org/jivesoftware/smackx/omemo/util/OmemoKeyUtil.java +++ b/smack-omemo/src/main/java/org/jivesoftware/smackx/omemo/util/OmemoKeyUtil.java @@ -36,13 +36,11 @@ import org.jivesoftware.smackx.omemo.trust.OmemoFingerprint; * @param PreKey class * @param SignedPreKey class * @param Session class - * @param Address class * @param Elliptic Curve PublicKey class * @param Bundle class - * @param Cipher class * @author Paul Schaub */ -public abstract class OmemoKeyUtil { +public abstract class OmemoKeyUtil { private static final Logger LOGGER = Logger.getLogger(OmemoKeyUtil.class.getName()); public final Bundle BUNDLE = new Bundle(); diff --git a/smack-omemo/src/test/java/org/jivesoftware/smack/omemo/OmemoKeyUtilTest.java b/smack-omemo/src/test/java/org/jivesoftware/smack/omemo/OmemoKeyUtilTest.java index 3c234cf6f..6c894a256 100644 --- a/smack-omemo/src/test/java/org/jivesoftware/smack/omemo/OmemoKeyUtilTest.java +++ b/smack-omemo/src/test/java/org/jivesoftware/smack/omemo/OmemoKeyUtilTest.java @@ -37,12 +37,12 @@ import org.jivesoftware.smackx.omemo.util.OmemoKeyUtil; import org.junit.Test; import org.jxmpp.jid.impl.JidCreate; -public abstract class OmemoKeyUtilTest +public abstract class OmemoKeyUtilTest extends SmackTestSuite { - protected OmemoKeyUtil keyUtil; + protected OmemoKeyUtil keyUtil; - public OmemoKeyUtilTest(OmemoKeyUtil keyUtil) { + public OmemoKeyUtilTest(OmemoKeyUtil keyUtil) { this.keyUtil = keyUtil; }