From 50c7d0bc2c876722fdf4012e4201fe81bfd32705 Mon Sep 17 00:00:00 2001 From: Florian Schmaus Date: Sat, 10 Jan 2015 01:46:09 +0100 Subject: [PATCH] Don't log whole exceptions in VCardProvider when trying to harden the parser. --- .../smackx/vcardtemp/provider/VCardProvider.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/vcardtemp/provider/VCardProvider.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/vcardtemp/provider/VCardProvider.java index 272b31eb7..d5e44691e 100644 --- a/smack-extensions/src/main/java/org/jivesoftware/smackx/vcardtemp/provider/VCardProvider.java +++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/vcardtemp/provider/VCardProvider.java @@ -60,7 +60,7 @@ public class VCardProvider extends IQProvider { try { documentBuilderFactory.setFeature("http://apache.org/xml/features/disallow-doctype-decl", true); } catch (ParserConfigurationException e) { - LOGGER.log(Level.FINER, "Could not disallow doctype decl", e); + LOGGER.finer("Could not disallow doctype decl: " + e.getMessage()); // If we can't disable DTDs, then at least try the following // Xerces 1 - http://xerces.apache.org/xerces-j/features.html#external-general-entities // Xerces 2 - http://xerces.apache.org/xerces2-j/features.html#external-general-entities @@ -68,7 +68,7 @@ public class VCardProvider extends IQProvider { documentBuilderFactory.setFeature( "http://xml.org/sax/features/external-general-entities", false); documentBuilderFactory.setFeature( "http://xml.org/sax/features/external-parameter-entities", false); } catch (ParserConfigurationException e1) { - LOGGER.log(Level.FINER, "Could not disallow external entities for xerces parser", e1); + LOGGER.finer("Could not disallow external entities for xerces parser: " + e1.getMessage()); } } // Android throws an UnsupportedOperationException when calling setXIncludeAware() and for some dumb reason also @@ -93,7 +93,7 @@ public class VCardProvider extends IQProvider { try { documentBuilderFactory.setFeature(XMLConstants.FEATURE_SECURE_PROCESSING, true); } catch (ParserConfigurationException e) { - LOGGER.log(Level.INFO, "Could not enable secure processing parsing feature", e); + LOGGER.info("Could not enable secure processing parsing feature: " + e.getMessage()); } DOCUMENT_BUILDER_FACTORY = documentBuilderFactory;