Add checkstyle check for space(s) after tab(s)

config/checkstyle.xml

@@ -27,6 +27,12 @@
 		<property name="format" value="^ +\t+"/>
 		<property name="message" value="Line containing tab(s) after space"/>
 	</module>
+	<module name="RegexpSingleline">
+		<!-- We use {2,} instead of + here to address the typical case where a file was written
+		   with tabs but javadoc is causing '\t *' -->
+		<property name="format" value="^\t+ {2,}"/>
+		<property name="message" value="Line containing space(s) after tab(s)"/>
+	</module>
 	<module name="RegexpSingleline">
 		<!--
 			Explaining the following Regex

smack-android-extensions/src/main/java/org/jivesoftware/smackx/ping/android/ServerPingWithAlarmManager.java

@@ -93,9 +93,8 @@ public class ServerPingWithAlarmManager extends Manager {
 	}
 
     /**
-	 * If enabled, ServerPingWithAlarmManager will call
+     * If enabled, ServerPingWithAlarmManager will call {@link PingManager#pingServerIfNecessary()}
-	 * {@link PingManager#pingServerIfNecessary()} for the connection of this
+     * for the connection of this instance every half hour.
-	 * instance every half hour.
      * 
      * @param enabled
      */
@@ -145,10 +144,9 @@ public class ServerPingWithAlarmManager extends Manager {
 	private static AlarmManager sAlarmManager;
 
     /**
-	 * Register a pending intent with the AlarmManager to be broadcasted every
+     * Register a pending intent with the AlarmManager to be broadcasted every half hour and
-	 * half hour and register the alarm broadcast receiver to receive this
+     * register the alarm broadcast receiver to receive this intent. The receiver will check all
-	 * intent. The receiver will check all known questions if a ping is
+     * known questions if a ping is Necessary when invoked by the alarm intent.
-	 * Necessary when invoked by the alarm intent.
      * 
      * @param context
      */

smack-core/src/test/java/org/jivesoftware/smack/PacketCollectorTest.java

@@ -62,8 +62,8 @@ public class PacketCollectorTest
 	}
 
     /**
-	 * Although this doesn't guarentee anything due to the nature of threading, it can 
+     * Although this doesn't guarentee anything due to the nature of threading, it can potentially
-	 * potentially catch problems.
+     * catch problems.
      */
 	@Test
 	public void verifyThreadSafety()

smack-debug/src/main/java/org/jivesoftware/smackx/debugger/EnhancedDebugger.java

@@ -354,6 +354,7 @@ public class EnhancedDebugger implements SmackDebugger {
         menu.add(menuItem1);
         // Add listener to the text area so the popup menu can come up.
         messageTextArea.addMouseListener(new PopupListener(menu));
+        // CHECKSTYLE:OFF
 	JPanel sublayout = new JPanel(new BorderLayout());
         sublayout.add(new JScrollPane(messageTextArea), BorderLayout.CENTER);
 
@@ -365,9 +366,9 @@ public class EnhancedDebugger implements SmackDebugger {
 	    @Override
 	    public void actionPerformed(ActionEvent e) {
             messagesTable.setRowCount(0);
-
 	    }
 	});
+         // CHECKSTYLE:ON
 
         sublayout.add(clearb, BorderLayout.NORTH);
         allPane.setBottomComponent(sublayout);

smack-extensions/src/main/java/org/jivesoftware/smackx/filetransfer/FileTransfer.java

@@ -187,8 +187,10 @@ public abstract class FileTransfer {
 
 	protected void setStatus(Status status) {
         synchronized (statusMonitor) {
+         // CHECKSTYLE:OFF
 		    this.status = status;
 	    }
+        // CHECKSTYLE:ON
     }
 
     protected boolean updateStatus(Status oldStatus, Status newStatus) {

smack-extensions/src/main/java/org/jivesoftware/smackx/filetransfer/StreamNegotiator.java

@@ -87,7 +87,9 @@ public abstract class StreamNegotiator {
     }
 
     protected final IQ initiateIncomingStream(final XMPPConnection connection, StreamInitiation initiation)
+    // CHECKSTYLE:OFF
 				   throws NoResponseException, XMPPErrorException, NotConnectedException, InterruptedException {
+    // CHECKSTYLE:ON
         final StreamInitiation response = createInitiationAccept(initiation,
                 getNamespaces());
 

smack-extensions/src/main/java/org/jivesoftware/smackx/pubsub/Node.java

@@ -304,7 +304,9 @@ abstract public class Node
 	 */
 	public Subscription subscribe(String jid) throws NoResponseException, XMPPErrorException, NotConnectedException, InterruptedException
 	{
+// CHECKSTYLE:OFF
 	    PubSub pubSub = createPubsubPacket(Type.set, new SubscribeExtension(jid, getId()));
+// CHECKSTYLE:ON
 		PubSub reply = sendPubsubPacket(pubSub);
 		return reply.getExtension(PubSubElementType.SUBSCRIPTION);
 	}
@@ -330,7 +332,9 @@ abstract public class Node
 	 */
 	public Subscription subscribe(String jid, SubscribeForm subForm) throws NoResponseException, XMPPErrorException, NotConnectedException, InterruptedException
 	{
+// CHECKSTYLE:OFF
 	    PubSub request = createPubsubPacket(Type.set, new SubscribeExtension(jid, getId()));
+// CHECKSTYLE:ON
 		request.addExtension(new FormNode(FormNodeType.OPTIONS, subForm));
 		PubSub reply = PubSubManager.sendPubsubPacket(con, request);
 		return reply.getExtension(PubSubElementType.SUBSCRIPTION);
@@ -545,7 +549,9 @@ abstract public class Node
 		@SuppressWarnings({ "rawtypes", "unchecked" })
         public void processPacket(Stanza packet)
 		{
+// CHECKSTYLE:OFF
 	        EventElement event = (EventElement)packet.getExtension("event", PubSubNamespace.EVENT.getXmlns());
+// CHECKSTYLE:ON
 			ItemsExtension itemsElem = (ItemsExtension)event.getEvent();
             ItemPublishEvent eventItems = new ItemPublishEvent(itemsElem.getNode(), (List<Item>)itemsElem.getItems(), getSubscriptionIds(packet), DelayInformationManager.getDelayTimestamp(packet));
 			listener.handlePublishedItems(eventItems);
@@ -569,6 +575,7 @@ abstract public class Node
 
 		public void processPacket(Stanza packet)
 		{
+// CHECKSTYLE:OFF
 	        EventElement event = (EventElement)packet.getExtension("event", PubSubNamespace.EVENT.getXmlns());
 
 	        List<ExtensionElement> extList = event.getExtensions();
@@ -592,6 +599,7 @@ abstract public class Node
 				ItemDeleteEvent eventItems = new ItemDeleteEvent(itemsElem.getNode(), items, getSubscriptionIds(packet));
 				listener.handleDeletedItems(eventItems);
 	        }
+// CHECKSTYLE:ON
 		}
 	}
 
@@ -612,8 +620,10 @@ abstract public class Node
 
 		public void processPacket(Stanza packet)
 		{
+// CHECKSTYLE:OFF
 	        EventElement event = (EventElement)packet.getExtension("event", PubSubNamespace.EVENT.getXmlns());
 	        ConfigurationEvent config = (ConfigurationEvent)event.getEvent();
+// CHECKSTYLE:ON
 
 			listener.handleNodeConfiguration(config);
 		}

smack-extensions/src/main/java/org/jivesoftware/smackx/pubsub/PubSubManager.java

@@ -321,10 +321,12 @@ final public class PubSubManager
 
 	static PubSub sendPubsubPacket(XMPPConnection con, Jid to, Type type, List<ExtensionElement> extList, PubSubNamespace ns) throws NoResponseException, XMPPErrorException, NotConnectedException, InterruptedException
 	{
+// CHECKSTYLE:OFF
 	    PubSub pubSub = new PubSub(to, type, ns);
 	    for (ExtensionElement pe : extList) {
 	        pubSub.addExtension(pe);
 	    }
+// CHECKSTYLE:ON
 		return sendPubsubPacket(con ,pubSub);
 	}
 

smack-extensions/src/main/java/org/jivesoftware/smackx/pubsub/provider/EventProvider.java

@@ -36,6 +36,8 @@ public class EventProvider extends EmbeddedExtensionProvider<EventElement>
 	@Override
 	protected EventElement createReturnExtension(String currentElement, String currentNamespace, Map<String, String> attMap, List<? extends ExtensionElement> content)
 	{
+// CHECKSTYLE:OFF
 	   	return new EventElement(EventElementType.valueOf(content.get(0).getElementName()), (NodeExtension)content.get(0));
+// CHECKSTYLE:ON
 	}
 }