Cleanup of PrivacyList API

Use Type enum instead of String for PrivacyItem's constructor. Add
getName() to PrivacyList. Remove PrivacyRule, as it just adds unnecessary
complexity spliting PrivacyItem and PrivacyRule, they belong
together. Don't mix camel-case and c-style method names. Some minor
improvements. Add parser test.

documentation/extensions/privacy.html

@@ -63,23 +63,20 @@ Now the client is able to show every <tt>PrivacyItem</tt> of the server and also
 	String groupName = <font color="green">"enemies"</font>;
 	ArrayList privacyItems = new ArrayList();
 
-	PrivacyItem item = new PrivacyItem(PrivacyRule.<font color="navy"><i>JID</i></font>, <font color="navy">true</font>, 1);
+	PrivacyItem item = new PrivacyItem(PrivacyItem.Type.jid, user, <font color="navy">true</font>, 1);
-	item.setValue(user);
 	privacyItems.add(item);
 
-	item = new PrivacyItem(PrivacyRule.<font color="navy"><i>SUBSCRIPTION</i></font>, <font color="navy">true</font>, 2);
+	item = new PrivacyItem(PrivacyItem.Type.subscription, PrivacyItem.SUBSCRIPTION_BOTH, <font color="navy">true</font>, 2);
-	item.setValue(PrivacyRule.<font color="navy"><i>SUBSCRIPTION_BOTH</i></font>);
 	privacyItems.add(item);
      	
-	item = new PrivacyItem(PrivacyRule.<font color="navy"><i>GROUP</i></font>, <font color="navy">false</font>, 3);
+	item = new PrivacyItem(PrivacyItem.Type.group, groupName, <font color="navy">false</font>, 3);
-	item.setValue(groupName);
 	item.setFilterMessage(<font color="navy">true</font>);
 	privacyItems.add(item);
 
 	<font color="gray"><i>// Get the privacy manager for the current connection.</i></font>
 	PrivacyListManager privacyManager = PrivacyListManager.getInstanceFor(myConnection);
 	<font color="gray"><i>// Create the new list.</i></font>
-	privacyManager.createPrivacyList(listName, Arrays.<i>asList</i>(privacyItems));
+	privacyManager.createPrivacyList(listName, privacyItems);
 </pre> 
 </div>
 

extensions/src/main/java/org/jivesoftware/smackx/privacy/PrivacyList.java

@@ -37,13 +37,13 @@ import java.util.List;
 public class PrivacyList {
 
     /** Holds if it is an active list or not **/
-    private boolean isActiveList;
+    private final boolean isActiveList;
     /** Holds if it is an default list or not **/
-    private boolean isDefaultList;
+    private final boolean isDefaultList;
     /** Holds the list name used to print **/
-    private String listName;
+    private final String listName;
     /** Holds the list of {@see PrivacyItem} **/
-    private List<PrivacyItem> items;
+    private final List<PrivacyItem> items;
     
     protected PrivacyList(boolean isActiveList, boolean isDefaultList,
             String listName, List<PrivacyItem> privacyItems) {
@@ -54,6 +54,10 @@ public class PrivacyList {
         this.items = privacyItems;
     }
 
+    public String getName() {
+        return listName;
+    }
+
     public boolean isActiveList() {
         return isActiveList;
     }
@@ -66,8 +70,4 @@ public class PrivacyList {
         return items;
     }
 
-    public String toString() {
-        return listName;
-    }
-
 }

extensions/src/main/java/org/jivesoftware/smackx/privacy/PrivacyListManager.java

@@ -28,9 +28,13 @@ import org.jivesoftware.smack.ConnectionCreationListener;
 import org.jivesoftware.smack.Manager;
 import org.jivesoftware.smack.PacketListener;
 import org.jivesoftware.smack.XMPPException;
-import org.jivesoftware.smack.filter.*;
+import org.jivesoftware.smack.filter.AndFilter;
+import org.jivesoftware.smack.filter.IQTypeFilter;
+import org.jivesoftware.smack.filter.PacketExtensionFilter;
+import org.jivesoftware.smack.filter.PacketFilter;
 import org.jivesoftware.smack.packet.IQ;
 import org.jivesoftware.smack.packet.Packet;
+import org.jivesoftware.smackx.disco.ServiceDiscoveryManager;
 import org.jivesoftware.smackx.privacy.packet.Privacy;
 import org.jivesoftware.smackx.privacy.packet.PrivacyItem;
 
@@ -46,27 +50,29 @@ import org.jivesoftware.smackx.privacy.packet.PrivacyItem;
  * subscription type or globally (@see PrivacyItem).
  * 
  * @author Francisco Vives
+ * @see <a href="http://xmpp.org/extensions/xep-0016.html">XEP-16: Privacy Lists</a>
  */
 public class PrivacyListManager extends Manager {
+    public static final String NAMESPACE = "jabber:iq:privacy";
+
+    private static final PacketFilter PACKET_FILTER = new AndFilter(new IQTypeFilter(IQ.Type.SET),
+                    new PacketExtensionFilter("query", "jabber:iq:privacy"));
 
     // Keep the list of instances of this class.
-    private static Map<XMPPConnection, PrivacyListManager> instances = Collections
+    private static final Map<XMPPConnection, PrivacyListManager> instances = Collections
             .synchronizedMap(new WeakHashMap<XMPPConnection, PrivacyListManager>());
 
 	private final List<PrivacyListListener> listeners = new ArrayList<PrivacyListListener>();
-	PacketFilter packetFilter = new AndFilter(new IQTypeFilter(IQ.Type.SET),
-    		new PacketExtensionFilter("query", "jabber:iq:privacy"));
 
     static {
-        // Create a new PrivacyListManager on every established connection. In the init()
+        // Create a new PrivacyListManager on every established connection.
-        // method of PrivacyListManager, we'll add a listener that will delete the
-        // instance when the connection is closed.
         XMPPConnection.addConnectionCreationListener(new ConnectionCreationListener() {
             public void connectionCreated(XMPPConnection connection) {
                 getInstanceFor(connection);
             }
         });
     }
+
     /**
      * Creates a new privacy manager to maintain the communication privacy. Note: no
      * information is sent to or received from the server until you attempt to 
@@ -80,12 +86,8 @@ public class PrivacyListManager extends Manager {
         instances.put(connection, this);
 
         connection.addPacketListener(new PacketListener() {
+            @Override
             public void processPacket(Packet packet) {
-
-                if (packet == null || packet.getError() != null) {
-                    return;
-                }
-                // The packet is correct.
                 Privacy privacy = (Privacy) packet;
 
                 // Notifies the event to the listeners.
@@ -105,21 +107,11 @@ public class PrivacyListManager extends Manager {
                 }
 
                 // Send a result package acknowledging the reception of a privacy package.
-                
+                IQ iq = IQ.createResultIQ(privacy);
-                // Prepare the IQ packet to send
-                IQ iq = new IQ() {
-                    public String getChildElementXML() {
-                        return "";
-                    }
-                };
-                iq.setType(IQ.Type.RESULT);
-                iq.setFrom(packet.getFrom());
-                iq.setPacketID(packet.getPacketID());
-
-                // Send create & join packet.
                 connection.sendPacket(iq);
             }
-        }, packetFilter);    }
+        }, PACKET_FILTER);
+    }
 
 	/** Answer the connection userJID that owns the privacy.
 	 * @return the userJID that owns the privacy
@@ -176,13 +168,12 @@ public class PrivacyListManager extends Manager {
     }
 
 	/**
-	 * Answer a privacy containing the list structre without {@link PrivacyItem}.
+	 * Answer a privacy containing the list structure without {@link PrivacyItem}.
 	 * 
 	 * @return a Privacy with the list names.
      * @throws XMPPException if an error occurs.
 	 */ 
 	private Privacy getPrivacyWithListNames() throws XMPPException {
-		
 		// The request of the list is an empty privacy message
 		Privacy request = new Privacy();
 		
@@ -230,7 +221,6 @@ public class PrivacyListManager extends Manager {
      * @throws XMPPException if an error occurs.
      */ 
     private List<PrivacyItem> getPrivacyListItems(String listName) throws XMPPException {
-        
         // The request of the list is an privacy message with an empty list
         Privacy request = new Privacy();
         request.setPrivacyList(listName, new ArrayList<PrivacyItem>());
@@ -249,7 +239,6 @@ public class PrivacyListManager extends Manager {
      * @throws XMPPException if an error occurs.
 	 */ 
 	public PrivacyList getPrivacyList(String listName) throws XMPPException {
-		
         return new PrivacyList(false, false, listName, getPrivacyListItems(listName));
 	}
 
@@ -276,7 +265,6 @@ public class PrivacyListManager extends Manager {
         return lists;
     }
 
-    
 	/**
 	 * Set or change the active list to listName.
 	 * 
@@ -284,7 +272,6 @@ public class PrivacyListManager extends Manager {
 	 * @exception XMPPException if the request or the answer failed, it raises an exception.
 	 */ 
 	public void setActiveListName(String listName) throws XMPPException {
-		
 		// The request of the list is an privacy message with an empty list
 		Privacy request = new Privacy();
 		request.setActiveName(listName);
@@ -299,7 +286,6 @@ public class PrivacyListManager extends Manager {
      * @throws XMPPException if an error occurs.
 	 */ 
 	public void declineActiveList() throws XMPPException {
-		
 		// The request of the list is an privacy message with an empty list
 		Privacy request = new Privacy();
 		request.setDeclineActiveList(true);
@@ -315,7 +301,6 @@ public class PrivacyListManager extends Manager {
 	 * @exception XMPPException if the request or the answer failed, it raises an exception.
 	 */ 
 	public void setDefaultListName(String listName) throws XMPPException {
-		
 		// The request of the list is an privacy message with an empty list
 		Privacy request = new Privacy();
 		request.setDefaultName(listName);
@@ -330,7 +315,6 @@ public class PrivacyListManager extends Manager {
      * @throws XMPPException if an error occurs.
 	 */ 
 	public void declineDefaultList() throws XMPPException {
-		
 		// The request of the list is an privacy message with an empty list
 		Privacy request = new Privacy();
 		request.setDeclineDefaultList(true);
@@ -347,7 +331,6 @@ public class PrivacyListManager extends Manager {
      * @throws XMPPException if an error occurs.
 	 */ 
 	public void createPrivacyList(String listName, List<PrivacyItem> privacyItems) throws XMPPException {
-
 		this.updatePrivacyList(listName, privacyItems);
 	}
 
@@ -361,7 +344,6 @@ public class PrivacyListManager extends Manager {
      * @throws XMPPException if an error occurs.
      */ 
     public void updatePrivacyList(String listName, List<PrivacyItem> privacyItems) throws XMPPException {
-
         // Build the privacy package to add or update the new list
         Privacy request = new Privacy();
         request.setPrivacyList(listName, privacyItems);
@@ -377,7 +359,6 @@ public class PrivacyListManager extends Manager {
      * @throws XMPPException if an error occurs.
 	 */ 
 	public void deletePrivacyList(String listName) throws XMPPException {
-		
 		// The request of the list is an privacy message with an empty list
 		Privacy request = new Privacy();
 		request.setPrivacyList(listName, new ArrayList<PrivacyItem>());
@@ -399,4 +380,15 @@ public class PrivacyListManager extends Manager {
             listeners.add(listener);
         }
     }
+
+    /**
+     * Check if the user's server supports privacy lists.
+     * 
+     * @return true, if the server supports privacy lists, false otherwise.
+     * @throws XMPPException
+     */
+    public boolean isSupported() throws XMPPException {
+        return ServiceDiscoveryManager.getInstanceFor(connection()).supportsFeature(
+                        connection().getServiceName(), NAMESPACE);
+    }
 }

extensions/src/main/java/org/jivesoftware/smackx/privacy/packet/Privacy.java

@@ -19,6 +19,7 @@ package org.jivesoftware.smackx.privacy.packet;
 import java.util.*;
 
 import org.jivesoftware.smack.packet.IQ;
+import org.jivesoftware.smackx.privacy.PrivacyListManager;
 
 /**
  * A Privacy IQ Packet, is used by the {@link org.jivesoftware.smackx.privacy.PrivacyListManager}
@@ -274,7 +275,7 @@ public class Privacy extends IQ {
 	
 	public String getChildElementXML() {
         StringBuilder buf = new StringBuilder();
-        buf.append("<query xmlns=\"jabber:iq:privacy\">");
+        buf.append("<query xmlns=\"" + PrivacyListManager.NAMESPACE + "\">");
 
         // Add the active tag
         if (this.isDeclineActiveList()) {

extensions/src/main/java/org/jivesoftware/smackx/privacy/packet/PrivacyItem.java

@@ -30,37 +30,74 @@ package org.jivesoftware.smackx.privacy.packet;
  * @author Francisco Vives
  */
 public class PrivacyItem {
+    /**
+     * Value for subscription type rules.
+     */
+    public static final String SUBSCRIPTION_BOTH = "both";
+    public static final String SUBSCRIPTION_TO = "to";
+    public static final String SUBSCRIPTION_FROM = "from";
+    public static final String SUBSCRIPTION_NONE = "none";
+
     /** allow is the action associated with the item, it can allow or deny the communication. */
-	private boolean allow;
+    private final boolean allow;
     /** order is a non-negative integer that is unique among all items in the list. */
-    private int order;
+    private final int order;
-    /** rule hold the kind of communication ([jid|group|subscription]) it will allow or block and
+
-     * identifier to apply the action.
+    /**
-     * If the type is "jid", then the 'value' attribute MUST contain a valid Jabber ID.
+     * Type defines if the rule is based on JIDs, roster groups or presence subscription types.
-     * If the type is "group", then the 'value' attribute SHOULD contain the name of a group
+     * Available values are: [jid|group|subscription]
-     * in the user's roster.
+     */
-     * If the type is "subscription", then the 'value' attribute MUST be one of "both", "to",
+    private final Type type;
-     * "from", or "none". */
+
-    private PrivacyRule rule;
+    /**
+     * The value hold the element identifier to apply the action. If the type is "jid", then the
+     * 'value' attribute MUST contain a valid Jabber ID. If the type is "group", then the
+     * 'value' attribute SHOULD contain the name of a group in the user's roster. If the type is
+     * "subscription", then the 'value' attribute MUST be one of "both", "to", "from", or
+     * "none".
+     */
+    private final String value;
 
     /** blocks incoming IQ stanzas. */
     private boolean filterIQ = false;
     /** filterMessage blocks incoming message stanzas. */
     private boolean filterMessage = false;
     /** blocks incoming presence notifications. */
-    private boolean filterPresence_in = false;
+    private boolean filterPresenceIn = false;
     /** blocks outgoing presence notifications. */
-    private boolean filterPresence_out = false;
+    private boolean filterPresenceOut = false;
+
+    /**
+     * Creates a new fall-through privacy item.
+     *
+     * This is usually the last item in a privacy list and has no 'type' attribute.
+     *
+     * @param allow true if this is an allow item
+     * @param order the order of this privacy item
+     */
+    public PrivacyItem(boolean allow, int order) {
+        this(null, null, allow, order);
+    }
 
     /**
      * Creates a new privacy item.
      *
+     * If the type is "jid", then the 'value' attribute MUST contain a valid Jabber ID.
+     * If the type is "group", then the 'value' attribute SHOULD contain the name of a group
+     * in the user's roster.
+     * If the type is "subscription", then the 'value' attribute MUST be one of "both", "to",
+     * "from", or "none".
+     *
      * @param type the type.
+     * @param value the value of the privacy item
+     * @param allow true if this is an allow item
+     * @param order the order of this privacy item
      */
-    public PrivacyItem(String type, boolean allow, int order) {
+    public PrivacyItem(Type type, String value, boolean allow, int order) {
-        this.setRule(PrivacyRule.fromString(type));
+        this.type = type;
-        this.setAllow(allow);
+        this.value = value;
-        this.setOrder(order);
+        this.allow = allow;
+        this.order = order;
     }
 
     /**
@@ -73,16 +110,6 @@ public class PrivacyItem {
 		return allow;
 	}
 
-    /**
-     * Sets the action associated with the item, it can allow or deny the communication.
-     *
-     * @param allow indicates if the receiver allow or deny the communication.
-     */
-    private void setAllow(boolean allow) {
-		this.allow = allow;
-	}
-
-
     /**
      * Returns whether the receiver allow or deny incoming IQ stanzas or not.
      *
@@ -92,7 +119,6 @@ public class PrivacyItem {
 		return filterIQ;
 	}
 
-
     /**
      * Sets whether the receiver allows or denies incoming IQ stanzas or not.
      *
@@ -102,7 +128,6 @@ public class PrivacyItem {
 		this.filterIQ = filterIQ;
 	}
 
-
     /**
      * Returns whether the receiver allows or denies incoming messages or not.
      *
@@ -112,7 +137,6 @@ public class PrivacyItem {
 		return filterMessage;
 	}
 
-
     /**
      * Sets wheather the receiver allows or denies incoming messages or not.
      *
@@ -122,47 +146,42 @@ public class PrivacyItem {
 		this.filterMessage = filterMessage;
 	}
 
-
     /**
      * Returns whether the receiver allows or denies incoming presence or not.
      *
      * @return the iq filtering incoming presence status.
      */
-    public boolean isFilterPresence_in() {
+    public boolean isFilterPresenceIn() {
-		return filterPresence_in;
+		return filterPresenceIn;
 	}
 
-
     /**
      * Sets whether the receiver allows or denies incoming presence or not.
      *
-     * @param filterPresence_in indicates if the receiver allows or denies filtering incoming presence.
+     * @param filterPresenceIn indicates if the receiver allows or denies filtering incoming presence.
      */
-    public void setFilterPresence_in(boolean filterPresence_in) {
+    public void setFilterPresenceIn(boolean filterPresenceIn) {
-		this.filterPresence_in = filterPresence_in;
+		this.filterPresenceIn = filterPresenceIn;
 	}
 
-
     /**
      * Returns whether the receiver allows or denies incoming presence or not.
      *
      * @return the iq filtering incoming presence status.
      */
-    public boolean isFilterPresence_out() {
+    public boolean isFilterPresenceOut() {
-		return filterPresence_out;
+		return filterPresenceOut;
 	}
 
-
     /**
      * Sets whether the receiver allows or denies outgoing presence or not.
      *
-     * @param filterPresence_out indicates if the receiver allows or denies filtering outgoing presence
+     * @param filterPresenceOut indicates if the receiver allows or denies filtering outgoing presence
      */
-    public void setFilterPresence_out(boolean filterPresence_out) {
+    public void setFilterPresenceOut(boolean filterPresenceOut) {
-		this.filterPresence_out = filterPresence_out;
+		this.filterPresenceOut = filterPresenceOut;
 	}
 
-
     /**
      * Returns the order where the receiver is processed. List items are processed in
      * ascending order.
@@ -176,36 +195,6 @@ public class PrivacyItem {
 		return order;
 	}
 
-
-    /**
-     * Sets the order where the receiver is processed.
-     *
-     * The order MUST be filled and its value MUST be a non-negative integer
-     * that is unique among all items in the list.
-     *
-     * @param order indicates the order in the list.
-     */
-    public void setOrder(int order) {
-		this.order = order;
-	}
-
-    /**
-     * Sets the element identifier to apply the action.
-     *
-     * If the type is "jid", then the 'value' attribute MUST contain a valid Jabber ID.
-     * If the type is "group", then the 'value' attribute SHOULD contain the name of a group
-     * in the user's roster.
-     * If the type is "subscription", then the 'value' attribute MUST be one of "both", "to",
-     * "from", or "none".
-     *
-     * @param value is the identifier to apply the action.
-     */
-    public void setValue(String value) {
-    	if (!(this.getRule() == null && value == null)) {
-    		this.getRule().setValue(value);
-    	}
-	}
-
     /**
      * Returns the type hold the kind of communication it will allow or block.
      * It MUST be filled with one of these values: jid, group or subscription.
@@ -213,11 +202,7 @@ public class PrivacyItem {
      * @return the type of communication it represent.
      */
     public Type getType() {
-    	if (this.getRule() == null) {
+        return type;
-    		return null;
-    	} else {
-		return this.getRule().getType();
-    	}
 	}
 
     /**
@@ -232,35 +217,22 @@ public class PrivacyItem {
      * @return the identifier to apply the action.
      */
     public String getValue() {
-    	if (this.getRule() == null) {
+        return value;
-    		return null;
-    	} else {
-		return this.getRule().getValue();
 	}
-	}
-
 
     /**
      * Returns whether the receiver allows or denies every kind of communication.
      *
-     * When filterIQ, filterMessage, filterPresence_in and filterPresence_out are not set
+     * When filterIQ, filterMessage, filterPresenceIn and filterPresenceOut are not set
      * the receiver will block all communications.
      *
      * @return the all communications status.
      */
     public boolean isFilterEverything() {
-		return !(this.isFilterIQ() || this.isFilterMessage() || this.isFilterPresence_in()
+		return !(this.isFilterIQ() || this.isFilterMessage() || this.isFilterPresenceIn()
-				|| this.isFilterPresence_out());
+				|| this.isFilterPresenceOut());
 	}
 
-
-	private PrivacyRule getRule() {
-		return rule;
-	}
-
-	private void setRule(PrivacyRule rule) {
-		this.rule = rule;
-	}
 	/**
 	 * Answer an xml representation of the receiver according to the RFC 3921.
 	 *
@@ -291,10 +263,10 @@ public class PrivacyItem {
         	if (this.isFilterMessage()) {
             	buf.append("<message/>");
             }
-        	if (this.isFilterPresence_in()) {
+        	if (this.isFilterPresenceIn()) {
             	buf.append("<presence-in/>");
             }
-        	if (this.isFilterPresence_out()) {
+        	if (this.isFilterPresenceOut()) {
             	buf.append("<presence-out/>");
             }
         	buf.append("</item>");
@@ -302,144 +274,6 @@ public class PrivacyItem {
         return buf.toString();
     }
 
-
-    /**
-     * Privacy Rule represents the kind of action to apply.
-     * It holds the kind of communication ([jid|group|subscription]) it will allow or block and
-     * identifier to apply the action.
-     */
-
-	public static class PrivacyRule {
-    	 /**
-    	  * Type defines if the rule is based on JIDs, roster groups or presence subscription types.
-    	  * Available values are: [jid|group|subscription]
-    	  */
-         private Type type;
-         /**
-          * The value hold the element identifier to apply the action.
-          * If the type is "jid", then the 'value' attribute MUST contain a valid Jabber ID.
-          * If the type is "group", then the 'value' attribute SHOULD contain the name of a group
-          * in the user's roster.
-          * If the type is "subscription", then the 'value' attribute MUST be one of "both", "to",
-          * "from", or "none".
-          */
-         private String value;
-
-         /**
-     	 * If the type is "subscription", then the 'value' attribute MUST be one of "both",
-     	 * "to", "from", or "none"
-     	 */
-     	public static final String SUBSCRIPTION_BOTH = "both";
-     	public static final String SUBSCRIPTION_TO = "to";
-     	public static final String SUBSCRIPTION_FROM = "from";
-     	public static final String SUBSCRIPTION_NONE = "none";
-
-         /**
-          * Returns the type constant associated with the String value.
-          */
-         protected static PrivacyRule fromString(String value) {
-             if (value == null) {
-                 return null;
-             }
-             PrivacyRule rule = new PrivacyRule();
-             rule.setType(Type.valueOf(value.toLowerCase()));
-             return rule;
-         }
-
-         /**
-          * Returns the type hold the kind of communication it will allow or block.
-          * It MUST be filled with one of these values: jid, group or subscription.
-          *
-          * @return the type of communication it represent.
-          */
-         public Type getType() {
-     		return type;
-     	}
-
-         /**
-          * Sets the action associated with the item, it can allow or deny the communication.
-          *
-          * @param type indicates if the receiver allows or denies the communication.
-          */
-         private void setType(Type type) {
-     		this.type = type;
-     	}
-
-         /**
-          * Returns the element identifier to apply the action.
-          *
-          * If the type is "jid", then the 'value' attribute MUST contain a valid Jabber ID.
-          * If the type is "group", then the 'value' attribute SHOULD contain the name of a group
-          * in the user's roster.
-          * If the type is "subscription", then the 'value' attribute MUST be one of "both", "to",
-          * "from", or "none".
-          *
-          * @return the identifier to apply the action.
-          */
-         public String getValue() {
-     		return value;
-     	}
-
-         /**
-          * Sets the element identifier to apply the action.
-          *
-          * If the type is "jid", then the 'value' attribute MUST contain a valid Jabber ID.
-          * If the type is "group", then the 'value' attribute SHOULD contain the name of a group
-          * in the user's roster.
-          * If the type is "subscription", then the 'value' attribute MUST be one of "both", "to",
-          * "from", or "none".
-          *
-          * @param value is the identifier to apply the action.
-          */
-         protected void setValue(String value) {
-        	 if (this.isSuscription()) {
-        		 setSuscriptionValue(value);
-        	 } else {
-        		 this.value = value;
-        	 }
-     	}
-
-         /**
-          * Sets the element identifier to apply the action.
-          *
-          * The 'value' attribute MUST be one of "both", "to", "from", or "none".
-          *
-          * @param value is the identifier to apply the action.
-          */
-         private void setSuscriptionValue(String value) {
-        	 String setValue;
-             if (value == null) {
-            	 // Do nothing
-             }
-             if (SUBSCRIPTION_BOTH.equalsIgnoreCase(value)) {
-            	 setValue = SUBSCRIPTION_BOTH;
-             }
-             else if (SUBSCRIPTION_TO.equalsIgnoreCase(value)) {
-            	 setValue = SUBSCRIPTION_TO;
-             }
-             else if (SUBSCRIPTION_FROM.equalsIgnoreCase(value)) {
-            	 setValue = SUBSCRIPTION_FROM;
-             }
-             else if (SUBSCRIPTION_NONE.equalsIgnoreCase(value)) {
-            	 setValue = SUBSCRIPTION_NONE;
-             }
-             // Default to available.
-             else {
-            	 setValue = null;
-             }
-     		this.value = setValue;
-     	}
-
-         /**
-          * Returns if the receiver represents a subscription rule.
-          *
-          * @return if the receiver represents a subscription rule.
-          */
-         public boolean isSuscription () {
-     		return this.getType() == Type.subscription;
-     	}
-    }
-
     /**
      * Type defines if the rule is based on JIDs, roster groups or presence subscription types.
      */
@@ -453,8 +287,8 @@ public class PrivacyItem {
          */
         jid,
         /**
-         * JID being analyzed should belong to a contact present in the owner's roster with
+         * JID being analyzed should belong to a contact present in the owner's roster with the
-         * the specified subscription status.
+         * specified subscription status.
          */
         subscription
     }

extensions/src/main/java/org/jivesoftware/smackx/privacy/provider/PrivacyProvider.java

@@ -29,7 +29,7 @@ import java.util.ArrayList;
  * The PrivacyProvider parses {@link Privacy} packets. {@link Privacy}
  * Parses the <tt>query</tt> sub-document and creates an instance of {@link Privacy}.
  * For each <tt>item</tt> in the <tt>list</tt> element, it creates an instance 
- * of {@link PrivacyItem} and {@link org.jivesoftware.smackx.privacy.packet.PrivacyItem.PrivacyRule}.
+ * of {@link PrivacyItem}.
  * 
  * @author Francisco Vives
  */
@@ -120,9 +120,11 @@ public class PrivacyProvider implements IQProvider {
         // Set the order number
         int order = Integer.parseInt(orderValue);
 
-        // Create the privacy item
+        PrivacyItem item;
-        PrivacyItem item = new PrivacyItem(type, allow, order);
+        if (type != null) {
-        item.setValue(parser.getAttributeValue("", "value"));
+            // If the type is not null, then we are dealing with a standard privacy item
+            String value = parser.getAttributeValue("", "value");
+            item = new PrivacyItem(PrivacyItem.Type.valueOf(type), value, allow, order);
 
             while (!done) {
                 int eventType = parser.next();
@@ -134,10 +136,10 @@ public class PrivacyProvider implements IQProvider {
                         item.setFilterMessage(true);
                     }
                     if (parser.getName().equals("presence-in")) {
-                	item.setFilterPresence_in(true);
+                        item.setFilterPresenceIn(true);
                     }
                     if (parser.getName().equals("presence-out")) {
-                	item.setFilterPresence_out(true);
+                        item.setFilterPresenceOut(true);
                     }
                 }
                 else if (eventType == XmlPullParser.END_TAG) {
@@ -146,6 +148,11 @@ public class PrivacyProvider implements IQProvider {
                     }
                 }
             }
+        }
+        else {
+            // If the type is null, then we are dealing with the fall-through privacy item.
+            item = new PrivacyItem(allow, order);
+        }
         return item;
 	}
 }

extensions/src/test/java/org/jivesoftware/smackx/privacy/provider/PrivacyProviderTest.java

@@ -0,0 +1,69 @@
+/**
+ *
+ * Copyright 2012 Florian Schmaus
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License");
+ * you may not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.jivesoftware.smackx.privacy.provider;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+
+import java.util.List;
+
+import org.jivesoftware.smack.DummyConnection;
+import org.jivesoftware.smack.packet.IQ;
+import org.jivesoftware.smack.test.util.TestUtils;
+import org.jivesoftware.smack.util.PacketParserUtils;
+import org.jivesoftware.smackx.InitExtensions;
+import org.jivesoftware.smackx.privacy.packet.Privacy;
+import org.jivesoftware.smackx.privacy.packet.PrivacyItem;
+import org.junit.Test;
+
+public class PrivacyProviderTest extends InitExtensions {
+
+    @Test
+    public void parsePrivacyList() throws Exception {
+        DummyConnection connection = new DummyConnection();
+
+        // @formatter:off
+        final String xmlPrivacyList =
+        "<iq type='result' id='getlist2' to='romeo@example.net/orchard'>"
+          + "<query xmlns='jabber:iq:privacy'>"
+          + "<list name='public'>"
+          + "<item type='jid'"
+          + "value='tybalt@example.com'"
+          + "action='deny'"
+          + "order='1'/>"
+          + "<item action='allow' order='2'/>"
+          + "</list>"
+          + "</query>"
+          + "</iq>";
+        // @formatter:on
+        IQ iqPrivacyList = PacketParserUtils.parseIQ(TestUtils.getIQParser(xmlPrivacyList), connection);
+        assertTrue(iqPrivacyList instanceof Privacy);
+        
+        Privacy privacyList = (Privacy) iqPrivacyList;
+        List<PrivacyItem> pl = privacyList.getPrivacyList("public");
+
+        PrivacyItem first = pl.get(0);
+        assertEquals(PrivacyItem.Type.jid, first.getType());
+        assertEquals("tybalt@example.com", first.getValue());
+        assertEquals(false, first.isAllow());
+        assertEquals(1, first.getOrder());
+        
+        PrivacyItem second = pl.get(1);
+        assertEquals(true, second.isAllow());
+        assertEquals(2, second.getOrder());
+    }
+}