vanitasvitae/Smack
1
0
Fork 0
mirror of https://github.com/vanitasvitae/Smack.git synced 2024-11-22 03:52:06 +01:00
Code Issues Releases Wiki Activity

Remove clone() from DiscoverInfo.Identity

Browse source 
there is no need to clone immutable types.
This commit is contained in:
Florian Schmaus 2019-10-30 08:22:47 +01:00
parent 63ba524758
commit 63a4212f7e
1 changed files with 1 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
smack-extensions/src/main/java/org/jivesoftware/smackx/disco/packet/DiscoverInfo.java
View file

@ -330,7 +330,7 @@ public class DiscoverInfo extends IQ implements DiscoverInfoView, TypedCloneable
* attributes.
*
*/
public static final class Identity implements Comparable<Identity>, TypedCloneable<Identity> {
public static final class Identity implements Comparable<Identity> {
private final String category;
private final String type;
@ -512,11 +512,6 @@ public class DiscoverInfo extends IQ implements DiscoverInfoView, TypedCloneable
}
}
@Override
public Identity clone() {
return new Identity(this);
}
@Override
public String toString() {
return toXML().toString();