From 64db6e3ebc0a6697b8f1457ae7ac3794a57b439d Mon Sep 17 00:00:00 2001 From: Florian Schmaus Date: Sun, 2 May 2021 18:41:57 +0200 Subject: [PATCH] [openpgp] Remove INFO log sites INFO log sites should be used sparingly and carefully. Those are a good examples for an unnecessary INFO log sites. --- .../smackx/ox/OXSecretKeyBackupIntegrationTest.java | 2 -- .../smackx/ox_im/OXInstantMessagingIntegrationTest.java | 3 --- .../jivesoftware/smackx/ox/crypto/PainlessOpenPgpProvider.java | 1 - 3 files changed, 6 deletions(-) diff --git a/smack-integration-test/src/main/java/org/jivesoftware/smackx/ox/OXSecretKeyBackupIntegrationTest.java b/smack-integration-test/src/main/java/org/jivesoftware/smackx/ox/OXSecretKeyBackupIntegrationTest.java index 8031301ad..60e3361ad 100644 --- a/smack-integration-test/src/main/java/org/jivesoftware/smackx/ox/OXSecretKeyBackupIntegrationTest.java +++ b/smack-integration-test/src/main/java/org/jivesoftware/smackx/ox/OXSecretKeyBackupIntegrationTest.java @@ -27,7 +27,6 @@ import java.io.IOException; import java.security.InvalidAlgorithmParameterException; import java.security.NoSuchAlgorithmException; import java.security.NoSuchProviderException; -import java.util.logging.Level; import org.jivesoftware.smack.SmackException; import org.jivesoftware.smack.XMPPException; @@ -98,7 +97,6 @@ public class OXSecretKeyBackupIntegrationTest extends AbstractOpenPgpIntegration @AfterClass @BeforeClass public static void cleanStore() throws IOException { - LOGGER.log(Level.INFO, "Delete store directories..."); org.apache.commons.io.FileUtils.deleteDirectory(afterPath); org.apache.commons.io.FileUtils.deleteDirectory(beforePath); } diff --git a/smack-integration-test/src/main/java/org/jivesoftware/smackx/ox_im/OXInstantMessagingIntegrationTest.java b/smack-integration-test/src/main/java/org/jivesoftware/smackx/ox_im/OXInstantMessagingIntegrationTest.java index ee46e7182..683bc199a 100644 --- a/smack-integration-test/src/main/java/org/jivesoftware/smackx/ox_im/OXInstantMessagingIntegrationTest.java +++ b/smack-integration-test/src/main/java/org/jivesoftware/smackx/ox_im/OXInstantMessagingIntegrationTest.java @@ -21,7 +21,6 @@ import static org.junit.jupiter.api.Assertions.assertTrue; import java.io.File; import java.io.IOException; -import java.util.logging.Level; import org.jivesoftware.smack.SmackException; import org.jivesoftware.smack.XMPPException; @@ -104,8 +103,6 @@ public class OXInstantMessagingIntegrationTest extends AbstractOpenPgpIntegratio public void basicInstantMessagingTest() throws Exception { - LOGGER.log(Level.INFO, aliceStorePath.getAbsolutePath() + " " + bobStorePath.getAbsolutePath()); - final SimpleResultSyncPoint bobReceivedMessage = new SimpleResultSyncPoint(); final String body = "Writing integration tests is an annoying task, but it has to be done, so lets do it!!!"; diff --git a/smack-openpgp/src/main/java/org/jivesoftware/smackx/ox/crypto/PainlessOpenPgpProvider.java b/smack-openpgp/src/main/java/org/jivesoftware/smackx/ox/crypto/PainlessOpenPgpProvider.java index 8036111e9..28073421c 100644 --- a/smack-openpgp/src/main/java/org/jivesoftware/smackx/ox/crypto/PainlessOpenPgpProvider.java +++ b/smack-openpgp/src/main/java/org/jivesoftware/smackx/ox/crypto/PainlessOpenPgpProvider.java @@ -162,7 +162,6 @@ public class PainlessOpenPgpProvider implements OpenPgpProvider { PGPPublicKeyRingCollection announcedPublicKeys = sender.getAnnouncedPublicKeys(); if (announcedPublicKeys == null) { - LOGGER.log(Level.INFO, "Received a message from " + sender.getJid() + " but we have no keys yet. Try fetching them."); try { sender.updateKeys(connection); announcedPublicKeys = sender.getAnnouncedPublicKeys();