vanitasvitae/Smack
1
0
Fork 0
mirror of https://github.com/vanitasvitae/Smack.git synced 2024-11-22 03:52:06 +01:00
Code Issues Releases Wiki Activity

Fix parsing exception causing infinite loop

Browse source 
Fixes SMACK-613
This commit is contained in:
Florian Schmaus 2014-10-21 21:55:47 +02:00
parent 039fac7ab7
commit 674df78741
1 changed files with 12 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
smack-tcp/src/main/java/org/jivesoftware/smack/tcp/PacketReader.java
View file

@ -160,6 +160,10 @@ class PacketReader {
if (callback != null) { if (callback != null) {
callback.handleUnparsablePacket(message); callback.handleUnparsablePacket(message);
} }
// The parser is now at the end tag of the unparsable stanza. We need to advance to the next
// start tag in order to avoid an exception which would again lead to the execution of the
// catch block becoming effectively an endless loop.
eventType = parser.next();
continue; continue;
} }
connection.processPacket(packet); connection.processPacket(packet);
@ -174,6 +178,10 @@ class PacketReader {
if (callback != null) { if (callback != null) {
callback.handleUnparsablePacket(message); callback.handleUnparsablePacket(message);
} }
// The parser is now at the end tag of the unparsable stanza. We need to advance to the next
// start tag in order to avoid an exception which would again lead to the execution of the
// catch block becoming effectively an endless loop.
eventType = parser.next();
continue; continue;
} }
connection.processPacket(iq); connection.processPacket(iq);
@ -188,6 +196,10 @@ class PacketReader {
if (callback != null) { if (callback != null) {
callback.handleUnparsablePacket(message); callback.handleUnparsablePacket(message);
} }
// The parser is now at the end tag of the unparsable stanza. We need to advance to the next
// start tag in order to avoid an exception which would again lead to the execution of the
// catch block becoming effectively an endless loop.
eventType = parser.next();
continue; continue;
} }
connection.processPacket(presence); connection.processPacket(presence);