1
0
Fork 0
mirror of https://github.com/vanitasvitae/Smack.git synced 2024-12-22 10:37:59 +01:00

Improve StringUtils.collectionToString()

Use generics, and iterator and append(char) instead of append(String).
This commit is contained in:
Florian Schmaus 2015-07-14 13:40:23 +02:00
parent 57cc3aa3f8
commit 734695c80e

View file

@ -19,6 +19,7 @@ package org.jivesoftware.smack.util;
import java.io.UnsupportedEncodingException;
import java.util.Collection;
import java.util.Iterator;
import java.util.Random;
/**
@ -221,16 +222,22 @@ public class StringUtils {
return cs.length() == 0;
}
public static String collectionToString(Collection<String> collection) {
StringBuilder sb = new StringBuilder();
for (String s : collection) {
sb.append(s);
sb.append(" ");
/**
* Transform a collection of CharSequences to a whitespace delimited String.
*
* @param collection the collection to transform.
* @return a String with all the elements of the collection.
*/
public static String collectionToString(Collection<? extends CharSequence> collection) {
StringBuilder sb = new StringBuilder(collection.size() * 20);
for (Iterator<? extends CharSequence> it = collection.iterator(); it.hasNext();) {
CharSequence cs = it.next();
sb.append(cs);
if (it.hasNext()) {
sb.append(' ');
}
}
String res = sb.toString();
// Remove the trailing whitespace
res = res.substring(0, res.length() - 1);
return res;
return sb.toString();
}
public static String returnIfNotEmptyTrimmed(String string) {