From 77a4867450a1ea1f9cd161ea9c7014ce5155ab1f Mon Sep 17 00:00:00 2001 From: Florian Schmaus Date: Wed, 5 Nov 2014 20:25:51 +0100 Subject: [PATCH] Change Packet.getExtensionsXML() Remove the synchronized, as getExtensions() is properly synchronized and will return a copy. Return XmlStringBuilder instead of CharSequence to take advantage of fast XmlStringBuilder.append(XmlStringBuilder). Mark the method as final, as it should not be overwritten. --- .../src/main/java/org/jivesoftware/smack/packet/Packet.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/smack-core/src/main/java/org/jivesoftware/smack/packet/Packet.java b/smack-core/src/main/java/org/jivesoftware/smack/packet/Packet.java index 1529404b8..0fbd14a32 100644 --- a/smack-core/src/main/java/org/jivesoftware/smack/packet/Packet.java +++ b/smack-core/src/main/java/org/jivesoftware/smack/packet/Packet.java @@ -354,7 +354,7 @@ public abstract class Packet extends TopLevelStreamElement { * @return the extension sub-packets as XML or the Empty String if there * are no packet extensions. */ - protected synchronized CharSequence getExtensionsXML() { + protected final XmlStringBuilder getExtensionsXML() { XmlStringBuilder xml = new XmlStringBuilder(); // Add in all standard extension sub-packets. for (PacketExtension extension : getExtensions()) {