From 7a5533c823500d01aeeeacb534e7ba60f2eb0863 Mon Sep 17 00:00:00 2001 From: Florian Schmaus Date: Wed, 7 May 2014 12:46:24 +0200 Subject: [PATCH] Fix NPE in DiscoverInfo.Identities XmlStringBuilder The 'name' attribute of an service discovery identity is optional. Thanks to Jens Offenbach for reporting. --- .../java/org/jivesoftware/smackx/disco/packet/DiscoverInfo.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/disco/packet/DiscoverInfo.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/disco/packet/DiscoverInfo.java index 512dfda62..135f9d89a 100644 --- a/smack-extensions/src/main/java/org/jivesoftware/smackx/disco/packet/DiscoverInfo.java +++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/disco/packet/DiscoverInfo.java @@ -327,7 +327,7 @@ public class DiscoverInfo extends IQ implements Cloneable { xml.halfOpenElement("identity"); xml.xmllangAttribute(lang); xml.attribute("category", category); - xml.attribute("name", name); + xml.optAttribute("name", name); xml.optAttribute("type", type); xml.closeEmptyElement(); return xml;