From 7cefe63175a3233db2f904536f26d689af7694dc Mon Sep 17 00:00:00 2001 From: Florian Schmaus Date: Mon, 23 Mar 2015 21:12:13 +0100 Subject: [PATCH] Don't require a properties file when running the integration tests. --- .../smack/inttest/Configuration.java | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/smack-integration-test/src/main/java/org/igniterealtime/smack/inttest/Configuration.java b/smack-integration-test/src/main/java/org/igniterealtime/smack/inttest/Configuration.java index 1681eee09..15e06e1f8 100644 --- a/smack-integration-test/src/main/java/org/igniterealtime/smack/inttest/Configuration.java +++ b/smack-integration-test/src/main/java/org/igniterealtime/smack/inttest/Configuration.java @@ -27,6 +27,7 @@ import java.util.Properties; import java.util.Set; import org.jivesoftware.smack.ConnectionConfiguration.SecurityMode; +import org.jivesoftware.smack.util.Objects; import org.jivesoftware.smack.util.StringUtils; import org.jxmpp.jid.DomainBareJid; import org.jxmpp.jid.impl.JidCreate; @@ -64,7 +65,8 @@ public class Configuration { boolean debug, String accountOneUsername, String accountOnePassword, String accountTwoUsername, String accountTwoPassword, Set enabledTests, Set disabledTests, Set testPackages) { - this.service = service; + this.service = Objects.requireNonNull(service, + "'service' must be set. Either via 'properties' files or via system property 'sinttest.service'."); this.serviceTlsPin = serviceTlsPin; this.securityMode = securityMode; this.replyTimeout = replyTimeout; @@ -214,11 +216,13 @@ public class Configuration { private static final String SINTTEST = "sinttest."; public static Configuration newConfiguration() throws IOException { - File propertiesFile = findPropertiesFile(); Properties properties = new Properties(); - try (FileInputStream in = new FileInputStream(propertiesFile)) { - properties.load(in); + File propertiesFile = findPropertiesFile(); + if (propertiesFile != null) { + try (FileInputStream in = new FileInputStream(propertiesFile)) { + properties.load(in); + } } // Properties set via the system override the file properties @@ -266,7 +270,7 @@ public class Configuration { if (res.isFile()) return res; } - throw new IOException("Could not find properties file"); + return null; } private static Set getTestSetFrom(String string) {