vanitasvitae
/
Smack
mirror of https://github.com/vanitasvitae/Smack.git
1
0
Fork 0
Code Issues Releases Wiki Activity

Fix shouldPreserveAddressOrderOnInsertions test 

The test failed because the ArrayList - in contrast to the underlying Set - did not check for duplicates on insert. Under certain circumstances this lead to an index out
of bounds exception because the list in the test contained duplicated entries which were not present in the set of the Socks5Proxy.
I fixed the issue by only inserting the address when it was not in the list before.
This commit is contained in:
vanitasvitae 2017-06-23 12:51:07 +02:00
parent 08a4ee4eb2
commit 847a39b6ab
Signed by: vanitasvitae
GPG Key ID: 62BEE9264BF17311
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
smack-extensions/src/test/java/org/jivesoftware/smackx/bytestreams/socks5/Socks5ProxyTest.java
View File

@ -102,10 +102,15 @@ public class Socks5ProxyTest {
@Test
public void shouldPreserveAddressOrderOnInsertions() {
Socks5Proxy proxy = Socks5Proxy.getSocks5Proxy();
List<String> addresses = new ArrayList<String>(proxy.getLocalAddresses());
addresses.add("1");
addresses.add("2");
addresses.add("3");
List<String> addresses = new ArrayList<>(proxy.getLocalAddresses());
for (int i = 1 ; i <= 3; i++) {
String addr = Integer.toString(i);
if (!addresses.contains(addr)) {
addresses.add(addr);
}
}
for (String address : addresses) {
proxy.addLocalAddress(address);
}