vanitasvitae/Smack
1
0
Fork 0
mirror of https://github.com/vanitasvitae/Smack.git synced 2024-11-25 21:42:07 +01:00
Code Issues Releases Wiki Activity

Add TODO comment to XmppNioTcpConnection

Browse source
This commit is contained in:
Florian Schmaus 2019-05-29 11:50:25 +02:00
parent 60c7e0ab76
commit 89b64fbf0c
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
smack-tcp/src/main/java/org/jivesoftware/smack/tcp/XmppNioTcpConnection.java
View file

@ -1117,6 +1117,8 @@ public class XmppNioTcpConnection extends AbstractXmppNioConnection {
// session resumption may would need or at least benefit from B. Variant A would also be required if the // session resumption may would need or at least benefit from B. Variant A would also be required if the
// String is used for certificate verification. And it appears at least likely that TLS session resumption // String is used for certificate verification. And it appears at least likely that TLS session resumption
// would not be hurt by using variant A. Therefore we currently use variant A. // would not be hurt by using variant A. Therefore we currently use variant A.
// TODO: Should we use the ACE representation of the XMPP service domain? Compare with f60e4055ec529f0b8160acedf13275592ab10a4b
// If yes, then we should probably introduce getXmppServiceDomainAceEncodedIfPossible().
engine = smackTlsContext.sslContext.createSSLEngine(config.getXMPPServiceDomain().toString(), remoteAddress.getPort()); engine = smackTlsContext.sslContext.createSSLEngine(config.getXMPPServiceDomain().toString(), remoteAddress.getPort());
engine.setUseClientMode(true); engine.setUseClientMode(true);