From 89c97bb46cee60c17f3ff8220dee25df4104d0a6 Mon Sep 17 00:00:00 2001 From: Florian Schmaus Date: Mon, 25 Dec 2017 12:09:46 +0100 Subject: [PATCH] Enable javadoc 'syntax' doclint Addresses SMACK-650 but does not yet fix it completely. --- build.gradle | 2 +- .../src/main/java/org/jivesoftware/smack/XMPPConnection.java | 2 +- .../org/jivesoftware/smack/initializer/VmArgInitializer.java | 2 +- .../src/main/java/org/jivesoftware/smack/packet/Presence.java | 2 +- .../smack/provider/EmbeddedExtensionProvider.java | 2 +- .../java/org/jivesoftware/smack/provider/ProviderManager.java | 4 ++-- 6 files changed, 7 insertions(+), 7 deletions(-) diff --git a/build.gradle b/build.gradle index b6166250b..63ab6d340 100644 --- a/build.gradle +++ b/build.gradle @@ -179,7 +179,7 @@ allprojects { // work, we extra add '-quiet', which is added anyway by // gradle. // TODO enable all doclints, see SMACK-650 - options.addStringOption('Xdoclint:all,-html,-syntax', '-quiet') + options.addStringOption('Xdoclint:all,-html', '-quiet') } } tasks.withType(Javadoc) { diff --git a/smack-core/src/main/java/org/jivesoftware/smack/XMPPConnection.java b/smack-core/src/main/java/org/jivesoftware/smack/XMPPConnection.java index 9f99f0957..6cace5edb 100644 --- a/smack-core/src/main/java/org/jivesoftware/smack/XMPPConnection.java +++ b/smack-core/src/main/java/org/jivesoftware/smack/XMPPConnection.java @@ -451,7 +451,7 @@ public interface XMPPConnection { public static enum FromMode { /** - * Leave the 'from' attribute unchanged. This is the behavior of Smack < 4.0 + * Leave the 'from' attribute unchanged. This is the behavior of Smack < 4.0 */ UNCHANGED, /** diff --git a/smack-core/src/main/java/org/jivesoftware/smack/initializer/VmArgInitializer.java b/smack-core/src/main/java/org/jivesoftware/smack/initializer/VmArgInitializer.java index 5b3ce046a..3d0aaa762 100644 --- a/smack-core/src/main/java/org/jivesoftware/smack/initializer/VmArgInitializer.java +++ b/smack-core/src/main/java/org/jivesoftware/smack/initializer/VmArgInitializer.java @@ -23,7 +23,7 @@ import org.jivesoftware.smack.provider.ProviderManager; /** - * Looks for a provider file location based on the VM argument smack.provider.file. If it is supplied, its value will + * Looks for a provider file location based on the VM argument smack.provider.file. If it is supplied, its value will * be used as a file location for a providers file and loaded into the {@link ProviderManager} on Smack initialization. * * @author Robin Collier diff --git a/smack-core/src/main/java/org/jivesoftware/smack/packet/Presence.java b/smack-core/src/main/java/org/jivesoftware/smack/packet/Presence.java index cc2a90e36..d2e46e656 100644 --- a/smack-core/src/main/java/org/jivesoftware/smack/packet/Presence.java +++ b/smack-core/src/main/java/org/jivesoftware/smack/packet/Presence.java @@ -155,7 +155,7 @@ public final class Presence extends Stanza implements TypedCloneable { * {@link Mode#dnd do not disturb}. False will be returned when the type or mode * is any other value, including when the presence type is unavailable (offline). * This is a convenience method equivalent to - * type == Type.available && (mode == Mode.away || mode == Mode.xa || mode == Mode.dnd). + * type == Type.available && (mode == Mode.away || mode == Mode.xa || mode == Mode.dnd). * * @return true if the presence type is available and the presence mode is away, xa, or dnd. */ diff --git a/smack-core/src/main/java/org/jivesoftware/smack/provider/EmbeddedExtensionProvider.java b/smack-core/src/main/java/org/jivesoftware/smack/provider/EmbeddedExtensionProvider.java index 263916c59..b07c603e7 100644 --- a/smack-core/src/main/java/org/jivesoftware/smack/provider/EmbeddedExtensionProvider.java +++ b/smack-core/src/main/java/org/jivesoftware/smack/provider/EmbeddedExtensionProvider.java @@ -48,7 +48,7 @@ import org.xmlpull.v1.XmlPullParser; * <entry xmlns='http://www.w3.org/2005/Atom'> * <title>Soliloquy</title> * <link rel='alternative' type='text/html'/> - * <id>tag:denmark.lit,2003:entry-32397</id> + * <id>tag:denmark.lit,2003:entry-32397</id> * </entry> * </item> * </items> diff --git a/smack-core/src/main/java/org/jivesoftware/smack/provider/ProviderManager.java b/smack-core/src/main/java/org/jivesoftware/smack/provider/ProviderManager.java index 7784e4523..c8f34079c 100644 --- a/smack-core/src/main/java/org/jivesoftware/smack/provider/ProviderManager.java +++ b/smack-core/src/main/java/org/jivesoftware/smack/provider/ProviderManager.java @@ -55,7 +55,7 @@ import org.jxmpp.util.XmppStringUtils; * <iqProvider> * <elementName>query</elementName> * <namespace>jabber:iq:time</namespace> - * <className>org.jivesoftware.smack.packet.Time</className> + * <className>org.jivesoftware.smack.packet.Time</className> * </iqProvider> * </smackProviders> * @@ -91,7 +91,7 @@ import org.jxmpp.util.XmppStringUtils; * <extensionProvider> * <elementName>x</elementName> * <namespace>jabber:iq:event</namespace> - * <className>org.jivesoftware.smack.packet.MessageEvent</className> + * <className>org.jivesoftware.smack.packet.MessageEvent</className> * </extensionProvider> * </smackProviders> *