From 93683389e325621d5135d20bd267ecdaa2aa8fbb Mon Sep 17 00:00:00 2001 From: lohse Date: Fri, 19 Jan 2018 11:38:17 +0100 Subject: [PATCH] Bugfix in SOCKS5 authentication Read password bytes from the correct field. Fixes SMACK-796, introduced with 4c64643 --- .../jivesoftware/smack/proxy/Socks5ProxySocketConnection.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/smack-core/src/main/java/org/jivesoftware/smack/proxy/Socks5ProxySocketConnection.java b/smack-core/src/main/java/org/jivesoftware/smack/proxy/Socks5ProxySocketConnection.java index 053c1a67e..33c887ea2 100644 --- a/smack-core/src/main/java/org/jivesoftware/smack/proxy/Socks5ProxySocketConnection.java +++ b/smack-core/src/main/java/org/jivesoftware/smack/proxy/Socks5ProxySocketConnection.java @@ -137,7 +137,7 @@ public class Socks5ProxySocketConnection implements ProxySocketConnection { System.arraycopy(userBytes, 0, buf, index, user.length()); index += user.length(); - byte[] passwordBytes = user.getBytes(StringUtils.UTF8); + byte[] passwordBytes = passwd.getBytes(StringUtils.UTF8); buf[index++] = (byte) (passwordBytes.length); System.arraycopy(passwordBytes, 0, buf, index, passwd.length());