diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/jingle/JingleTransportMethodManager.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/jingle/JingleTransportMethodManager.java index 98bc100a5..4c2a9fe73 100644 --- a/smack-extensions/src/main/java/org/jivesoftware/smackx/jingle/JingleTransportMethodManager.java +++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/jingle/JingleTransportMethodManager.java @@ -91,6 +91,7 @@ public final class JingleTransportMethodManager extends Manager { return getTransportManager(transport.getNamespace()); } + public static JingleTransportManager getBestAvailableTransportManager(XMPPConnection connection) { return getInstanceFor(connection).getBestAvailableTransportManager(); } diff --git a/smack-extensions/src/test/java/org/jivesoftware/smackx/bytestreams/socks5/Socks5ProxyTest.java b/smack-extensions/src/test/java/org/jivesoftware/smackx/bytestreams/socks5/Socks5ProxyTest.java index a4dd53bb6..1fea4c24b 100644 --- a/smack-extensions/src/test/java/org/jivesoftware/smackx/bytestreams/socks5/Socks5ProxyTest.java +++ b/smack-extensions/src/test/java/org/jivesoftware/smackx/bytestreams/socks5/Socks5ProxyTest.java @@ -30,6 +30,8 @@ import java.net.Socket; import java.net.SocketException; import java.net.UnknownHostException; import java.util.ArrayList; +import java.util.Iterator; +import java.util.LinkedHashSet; import java.util.List; import org.jivesoftware.smack.util.StringUtils; @@ -39,7 +41,7 @@ import org.junit.Test; /** * Test for Socks5Proxy class. - * + * * @author Henning Staib */ public class Socks5ProxyTest { @@ -73,7 +75,7 @@ public class Socks5ProxyTest { /** * The SOCKS5 proxy should use a free port above the one configured. - * + * * @throws Exception should not happen */ @Test @@ -102,13 +104,11 @@ public class Socks5ProxyTest { @Test public void shouldPreserveAddressOrderOnInsertions() { Socks5Proxy proxy = Socks5Proxy.getSocks5Proxy(); - List addresses = new ArrayList<>(proxy.getLocalAddresses()); + + LinkedHashSet addresses = new LinkedHashSet<>(proxy.getLocalAddresses()); for (int i = 1 ; i <= 3; i++) { - String addr = Integer.toString(i); - if (!addresses.contains(addr)) { - addresses.add(addr); - } + addresses.add(Integer.toString(i)); } for (String address : addresses) { @@ -116,8 +116,10 @@ public class Socks5ProxyTest { } List localAddresses = proxy.getLocalAddresses(); + + Iterator iterator = addresses.iterator(); for (int i = 0; i < addresses.size(); i++) { - assertEquals(addresses.get(i), localAddresses.get(i)); + assertEquals(iterator.next(), localAddresses.get(i)); } } @@ -165,7 +167,7 @@ public class Socks5ProxyTest { /** * If the SOCKS5 proxy accepts a connection that is not a SOCKS5 connection it should close the * corresponding socket. - * + * * @throws Exception should not happen */ @Test @@ -196,7 +198,7 @@ public class Socks5ProxyTest { /** * The SOCKS5 proxy should reply with an error message if no supported authentication methods * are given in the SOCKS5 request. - * + * * @throws Exception should not happen */ @Test @@ -227,7 +229,7 @@ public class Socks5ProxyTest { /** * The SOCKS5 proxy should respond with an error message if the client is not allowed to connect * with the proxy. - * + * * @throws Exception should not happen */ @Test @@ -249,7 +251,7 @@ public class Socks5ProxyTest { // send valid SOCKS5 message out.write(new byte[] { (byte) 0x05, (byte) 0x00, (byte) 0x00, (byte) 0x03, (byte) 0x01, - (byte) 0xAA, (byte) 0x00, (byte) 0x00 }); + (byte) 0xAA, (byte) 0x00, (byte) 0x00 }); // verify error message assertEquals((byte) 0x05, (byte) in.read()); @@ -269,7 +271,7 @@ public class Socks5ProxyTest { /** * A Client should successfully establish a connection to the SOCKS5 proxy. - * + * * @throws Exception should not happen */ @Test @@ -297,7 +299,7 @@ public class Socks5ProxyTest { // send valid SOCKS5 message out.write(new byte[] { (byte) 0x05, (byte) 0x00, (byte) 0x00, (byte) 0x03, (byte) 0x01, - (byte) 0xAA, (byte) 0x00, (byte) 0x00 }); + (byte) 0xAA, (byte) 0x00, (byte) 0x00 }); // verify response assertEquals((byte) 0x05, (byte) in.read()); diff --git a/smack-extensions/src/test/java/org/jivesoftware/smackx/jingle/JingleManagerTest.java b/smack-extensions/src/test/java/org/jivesoftware/smackx/jingle/JingleManagerTest.java index a277d7f0f..24c1f08ee 100644 --- a/smack-extensions/src/test/java/org/jivesoftware/smackx/jingle/JingleManagerTest.java +++ b/smack-extensions/src/test/java/org/jivesoftware/smackx/jingle/JingleManagerTest.java @@ -1,3 +1,19 @@ +/** + * + * Copyright 2017 Paul Schaub + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ package org.jivesoftware.smackx.jingle; import static junit.framework.TestCase.assertEquals; diff --git a/smack-extensions/src/test/java/org/jivesoftware/smackx/jingle/JingleTransportMethodManagerTest.java b/smack-extensions/src/test/java/org/jivesoftware/smackx/jingle/JingleTransportMethodManagerTest.java index a08ed8fa9..4081ee30f 100644 --- a/smack-extensions/src/test/java/org/jivesoftware/smackx/jingle/JingleTransportMethodManagerTest.java +++ b/smack-extensions/src/test/java/org/jivesoftware/smackx/jingle/JingleTransportMethodManagerTest.java @@ -1,3 +1,19 @@ +/** + * + * Copyright 2017 Paul Schaub + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ package org.jivesoftware.smackx.jingle; import static junit.framework.TestCase.assertEquals; diff --git a/smack-extensions/src/test/java/org/jivesoftware/smackx/jingle/JingleUtilTest.java b/smack-extensions/src/test/java/org/jivesoftware/smackx/jingle/JingleUtilTest.java index 9863e01a5..123a967a7 100644 --- a/smack-extensions/src/test/java/org/jivesoftware/smackx/jingle/JingleUtilTest.java +++ b/smack-extensions/src/test/java/org/jivesoftware/smackx/jingle/JingleUtilTest.java @@ -32,6 +32,7 @@ import org.jxmpp.jid.FullJid; import org.jxmpp.jid.impl.JidCreate; import org.jxmpp.stringprep.XmppStringprepException; + /** * Test the JingleUtil class. */ @@ -45,6 +46,7 @@ public class JingleUtilTest extends SmackTestSuite { @Before public void setup() throws XmppStringprepException { + connection = new DummyConnection( DummyConnection.getDummyConfigurationBuilder() .setUsernameAndPassword("romeo@montague.lit",