From ac0c05be043b639ea44194b5aa3eb580eaad078e Mon Sep 17 00:00:00 2001 From: Florian Schmaus Date: Sun, 10 Jan 2016 18:23:06 +0100 Subject: [PATCH] StringUtils: Make randGen and numbersAndLetters final --- .../main/java/org/jivesoftware/smack/util/StringUtils.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/smack-core/src/main/java/org/jivesoftware/smack/util/StringUtils.java b/smack-core/src/main/java/org/jivesoftware/smack/util/StringUtils.java index 710d7d292..a0a70e19f 100644 --- a/smack-core/src/main/java/org/jivesoftware/smack/util/StringUtils.java +++ b/smack-core/src/main/java/org/jivesoftware/smack/util/StringUtils.java @@ -151,7 +151,7 @@ public class StringUtils { * The Random class is not considered to be cryptographically secure, so * only use these random Strings for low to medium security applications. */ - private static Random randGen = new Random(); + private static final Random randGen = new Random(); /** * Array of numbers and letters of mixed case. Numbers appear in the list @@ -159,7 +159,7 @@ public class StringUtils { * We can use the array to get a random number or letter by picking a random * array index. */ - private static char[] numbersAndLetters = ("0123456789abcdefghijklmnopqrstuvwxyz" + + private static final char[] numbersAndLetters = ("0123456789abcdefghijklmnopqrstuvwxyz" + "0123456789ABCDEFGHIJKLMNOPQRSTUVWXYZ").toCharArray(); /**