vanitasvitae/Smack
1
0
Fork 0
mirror of https://github.com/vanitasvitae/Smack.git synced 2024-11-29 07:22:07 +01:00
Code Issues Releases Wiki Activity

Add TODO notes to OX code

Browse source
This commit is contained in:
Florian Schmaus 2018-08-17 12:13:28 +02:00
parent 27164f4c06
commit b36b19d864
2 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
smack-openpgp/src/main/java/org/jivesoftware/smackx/ox/store/abstr/AbstractOpenPgpKeyStore.java
View file

@ -157,6 +157,7 @@ public abstract class AbstractOpenPgpKeyStore implements OpenPgpKeyStore {
public void importSecretKey(BareJid owner, PGPSecretKeyRing secretKeys) public void importSecretKey(BareJid owner, PGPSecretKeyRing secretKeys)
throws IOException, PGPException, MissingUserIdOnKeyException { throws IOException, PGPException, MissingUserIdOnKeyException {
// TODO: Avoid 'new' use instance method.
if (!new BareJidUserId.SecRingSelectionStrategy().accept(owner, secretKeys)) { if (!new BareJidUserId.SecRingSelectionStrategy().accept(owner, secretKeys)) {
throw new MissingUserIdOnKeyException(owner, new OpenPgpV4Fingerprint(secretKeys)); throw new MissingUserIdOnKeyException(owner, new OpenPgpV4Fingerprint(secretKeys));
} }

1
smack-openpgp/src/main/java/org/jivesoftware/smackx/ox/store/filebased/FileBasedOpenPgpStore.java
View file

@ -36,6 +36,7 @@ public class FileBasedOpenPgpStore extends AbstractOpenPgpStore {
} }
public static File getContactsPath(File basePath, BareJid jid) { public static File getContactsPath(File basePath, BareJid jid) {
// TODO: This is not filesystem agnostic, the jid should be base32 encoded.
return new File(basePath, Objects.requireNonNull(jid.toString())); return new File(basePath, Objects.requireNonNull(jid.toString()));
} }