From b4694ec152ddfd8a48812a0631063162286bb047 Mon Sep 17 00:00:00 2001
From: Florian Schmaus
Date: Mon, 6 Apr 2015 10:45:12 +0200
Subject: [PATCH] Add FinalClass checkstyle check
And mark affected classes final.
---
config/checkstyle.xml | 1 +
.../smackx/ping/android/ServerPingWithAlarmManager.java | 2 +-
.../util/stringencoder/android/AndroidBase64Encoder.java | 2 +-
.../stringencoder/android/AndroidBase64UrlSafeEncoder.java | 2 +-
.../java/org/jivesoftware/smack/bosh/BOSHConfiguration.java | 4 ++--
.../main/java/org/jivesoftware/smack/PacketCollector.java | 2 +-
.../java/org/jivesoftware/smack/ReconnectionManager.java | 2 +-
.../main/java/org/jivesoftware/smack/SmackException.java | 2 +-
.../org/jivesoftware/smack/compress/packet/Compressed.java | 2 +-
.../java/org/jivesoftware/smack/filter/IQTypeFilter.java | 2 +-
.../org/jivesoftware/smack/filter/MessageTypeFilter.java | 2 +-
.../jivesoftware/smack/filter/MessageWithBodiesFilter.java | 2 +-
.../jivesoftware/smack/filter/MessageWithSubjectFilter.java | 2 +-
.../org/jivesoftware/smack/filter/PresenceTypeFilter.java | 2 +-
.../src/main/java/org/jivesoftware/smack/packet/Bind.java | 2 +-
.../main/java/org/jivesoftware/smack/packet/Message.java | 4 ++--
.../src/main/java/org/jivesoftware/smack/util/MultiMap.java | 2 +-
.../test/java/org/jivesoftware/smack/DummyConnection.java | 2 +-
.../smackx/debugger/EnhancedDebuggerWindow.java | 2 +-
.../java/org/jivesoftware/smackx/carbons/CarbonManager.java | 2 +-
.../jivesoftware/smackx/carbons/packet/CarbonExtension.java | 2 +-
.../smackx/csi/packet/ClientStateIndication.java | 6 +++---
.../smackx/address/packet/MultipleAddresses.java | 2 +-
.../org/jivesoftware/smackx/bookmarks/BookmarkManager.java | 2 +-
.../smackx/bytestreams/ibb/InBandBytestreamManager.java | 2 +-
.../jivesoftware/smackx/bytestreams/socks5/Socks5Proxy.java | 2 +-
.../org/jivesoftware/smackx/caps/EntityCapsManager.java | 2 +-
.../jivesoftware/smackx/chatstates/ChatStateManager.java | 2 +-
.../jivesoftware/smackx/commands/AdHocCommandManager.java | 2 +-
.../smackx/delay/filter/DelayedStanzaFilter.java | 2 +-
.../jivesoftware/smackx/disco/ServiceDiscoveryManager.java | 2 +-
.../smackx/filetransfer/FileTransferManager.java | 2 +-
.../smackx/filetransfer/FileTransferNegotiator.java | 2 +-
.../smackx/filetransfer/IBBTransferNegotiator.java | 2 +-
.../smackx/filetransfer/Socks5TransferNegotiator.java | 2 +-
.../org/jivesoftware/smackx/geoloc/GeoLocationManager.java | 2 +-
.../org/jivesoftware/smackx/geoloc/packet/GeoLocation.java | 2 +-
.../org/jivesoftware/smackx/iqlast/LastActivityManager.java | 2 +-
.../jivesoftware/smackx/iqprivate/PrivateDataManager.java | 2 +-
.../org/jivesoftware/smackx/iqregister/AccountManager.java | 2 +-
.../jivesoftware/smackx/iqregister/packet/Registration.java | 2 +-
.../org/jivesoftware/smackx/iqversion/VersionManager.java | 2 +-
.../org/jivesoftware/smackx/muc/MultiUserChatManager.java | 2 +-
.../java/org/jivesoftware/smackx/muc/packet/MUCUser.java | 2 +-
.../main/java/org/jivesoftware/smackx/ping/PingManager.java | 2 +-
.../org/jivesoftware/smackx/privacy/PrivacyListManager.java | 2 +-
.../smackx/privacy/filter/SetActiveListFilter.java | 2 +-
.../smackx/privacy/filter/SetDefaultListFilter.java | 2 +-
.../smackx/receipts/DeliveryReceiptManager.java | 2 +-
.../org/jivesoftware/smackx/time/EntityTimeManager.java | 2 +-
.../org/jivesoftware/smackx/vcardtemp/VCardManager.java | 2 +-
.../java/org/jivesoftware/smackx/xdata/XDataManager.java | 2 +-
.../smackx/bytestreams/socks5/Socks5TestProxy.java | 2 +-
.../main/java/org/jivesoftware/smack/chat/ChatManager.java | 2 +-
.../src/main/java/org/jivesoftware/smack/roster/Roster.java | 4 ++--
.../org/jivesoftware/smack/roster/packet/RosterVer.java | 2 +-
.../smack/roster/packet/SubscriptionPreApproval.java | 2 +-
.../smack/roster/rosterstore/DirectoryRosterStore.java | 2 +-
.../org/igniterealtime/smack/inttest/Configuration.java | 4 ++--
.../java/org/igniterealtime/smack/inttest/IntTestUtil.java | 2 +-
.../smack/inttest/SmackIntegrationTestFramework.java | 2 +-
.../jivesoftware/smack/util/stringencoder/java7/Base64.java | 2 +-
.../smack/util/stringencoder/java7/Java7Base64Encoder.java | 2 +-
.../util/stringencoder/java7/Java7Base64UrlSafeEncoder.java | 2 +-
.../jivesoftware/smackx/workgroup/agent/WorkgroupQueue.java | 2 +-
.../jivesoftware/smackx/workgroup/packet/QueueDetails.java | 2 +-
.../org/jivesoftware/smackx/xevent/MessageEventManager.java | 2 +-
.../org/jivesoftware/smack/sm/packet/StreamManagement.java | 4 ++--
.../jivesoftware/smack/sm/predicates/ForEveryMessage.java | 2 +-
.../jivesoftware/smack/sm/predicates/ForEveryStanza.java | 2 +-
.../jivesoftware/smack/sm/predicates/OnceForThisStanza.java | 2 +-
.../smack/tcp/XMPPTCPConnectionConfiguration.java | 4 ++--
72 files changed, 80 insertions(+), 79 deletions(-)
diff --git a/config/checkstyle.xml b/config/checkstyle.xml
index 9cd10f305..4dc35f6b6 100644
--- a/config/checkstyle.xml
+++ b/config/checkstyle.xml
@@ -54,6 +54,7 @@
+
diff --git a/smack-android-extensions/src/main/java/org/jivesoftware/smackx/ping/android/ServerPingWithAlarmManager.java b/smack-android-extensions/src/main/java/org/jivesoftware/smackx/ping/android/ServerPingWithAlarmManager.java
index 9b252dd40..54e271d12 100644
--- a/smack-android-extensions/src/main/java/org/jivesoftware/smackx/ping/android/ServerPingWithAlarmManager.java
+++ b/smack-android-extensions/src/main/java/org/jivesoftware/smackx/ping/android/ServerPingWithAlarmManager.java
@@ -59,7 +59,7 @@ import android.os.SystemClock;
* functionality.
*
*/
-public class ServerPingWithAlarmManager extends Manager {
+public final class ServerPingWithAlarmManager extends Manager {
private static final Logger LOGGER = Logger.getLogger(ServerPingWithAlarmManager.class
.getName());
diff --git a/smack-android/src/main/java/org/jivesoftware/smack/util/stringencoder/android/AndroidBase64Encoder.java b/smack-android/src/main/java/org/jivesoftware/smack/util/stringencoder/android/AndroidBase64Encoder.java
index 4eaa2d3f6..5d143737d 100644
--- a/smack-android/src/main/java/org/jivesoftware/smack/util/stringencoder/android/AndroidBase64Encoder.java
+++ b/smack-android/src/main/java/org/jivesoftware/smack/util/stringencoder/android/AndroidBase64Encoder.java
@@ -22,7 +22,7 @@ import android.util.Base64;
* A Base 64 encoding implementation based on android.util.Base64.
* @author Florian Schmaus
*/
-public class AndroidBase64Encoder implements org.jivesoftware.smack.util.stringencoder.Base64.Encoder {
+public final class AndroidBase64Encoder implements org.jivesoftware.smack.util.stringencoder.Base64.Encoder {
private static AndroidBase64Encoder instance = new AndroidBase64Encoder();
diff --git a/smack-android/src/main/java/org/jivesoftware/smack/util/stringencoder/android/AndroidBase64UrlSafeEncoder.java b/smack-android/src/main/java/org/jivesoftware/smack/util/stringencoder/android/AndroidBase64UrlSafeEncoder.java
index 3bd89e642..e92fc297b 100644
--- a/smack-android/src/main/java/org/jivesoftware/smack/util/stringencoder/android/AndroidBase64UrlSafeEncoder.java
+++ b/smack-android/src/main/java/org/jivesoftware/smack/util/stringencoder/android/AndroidBase64UrlSafeEncoder.java
@@ -23,7 +23,7 @@ import org.jivesoftware.smack.util.stringencoder.StringEncoder;
import android.util.Base64;
-public class AndroidBase64UrlSafeEncoder implements StringEncoder {
+public final class AndroidBase64UrlSafeEncoder implements StringEncoder {
private static AndroidBase64UrlSafeEncoder instance = new AndroidBase64UrlSafeEncoder();
diff --git a/smack-bosh/src/main/java/org/jivesoftware/smack/bosh/BOSHConfiguration.java b/smack-bosh/src/main/java/org/jivesoftware/smack/bosh/BOSHConfiguration.java
index 32a5e13a4..58646dd45 100644
--- a/smack-bosh/src/main/java/org/jivesoftware/smack/bosh/BOSHConfiguration.java
+++ b/smack-bosh/src/main/java/org/jivesoftware/smack/bosh/BOSHConfiguration.java
@@ -30,7 +30,7 @@ import org.jivesoftware.smack.proxy.ProxyInfo;
* @see XMPPBOSHConnection
* @author Guenther Niess
*/
-public class BOSHConfiguration extends ConnectionConfiguration {
+public final class BOSHConfiguration extends ConnectionConfiguration {
private final boolean https;
private final String file;
@@ -73,7 +73,7 @@ public class BOSHConfiguration extends ConnectionConfiguration {
return new Builder();
}
- public static class Builder extends ConnectionConfiguration.Builder {
+ public static final class Builder extends ConnectionConfiguration.Builder {
private boolean https;
private String file;
diff --git a/smack-core/src/main/java/org/jivesoftware/smack/PacketCollector.java b/smack-core/src/main/java/org/jivesoftware/smack/PacketCollector.java
index 1082bc859..57764c2b8 100644
--- a/smack-core/src/main/java/org/jivesoftware/smack/PacketCollector.java
+++ b/smack-core/src/main/java/org/jivesoftware/smack/PacketCollector.java
@@ -271,7 +271,7 @@ public class PacketCollector {
return new Configuration();
}
- public static class Configuration {
+ public static final class Configuration {
private StanzaFilter packetFilter;
private int size = SmackConfiguration.getPacketCollectorSize();
private PacketCollector collectorToReset;
diff --git a/smack-core/src/main/java/org/jivesoftware/smack/ReconnectionManager.java b/smack-core/src/main/java/org/jivesoftware/smack/ReconnectionManager.java
index 2986fec72..2ebcaff8c 100644
--- a/smack-core/src/main/java/org/jivesoftware/smack/ReconnectionManager.java
+++ b/smack-core/src/main/java/org/jivesoftware/smack/ReconnectionManager.java
@@ -47,7 +47,7 @@ import java.util.logging.Logger;
* @author Francisco Vives
* @author Luca Stucchi
*/
-public class ReconnectionManager {
+public final class ReconnectionManager {
private static final Logger LOGGER = Logger.getLogger(ReconnectionManager.class.getName());
private static final Map INSTANCES = new WeakHashMap();
diff --git a/smack-core/src/main/java/org/jivesoftware/smack/SmackException.java b/smack-core/src/main/java/org/jivesoftware/smack/SmackException.java
index a898efa01..c2fbca05e 100644
--- a/smack-core/src/main/java/org/jivesoftware/smack/SmackException.java
+++ b/smack-core/src/main/java/org/jivesoftware/smack/SmackException.java
@@ -60,7 +60,7 @@ public class SmackException extends Exception {
* connection instance. You can modify (e.g. increase) the stanza(/packet) reply timeout with
* {@link XMPPConnection#setPacketReplyTimeout(long)}.
*/
- public static class NoResponseException extends SmackException {
+ public static final class NoResponseException extends SmackException {
/**
*
*/
diff --git a/smack-core/src/main/java/org/jivesoftware/smack/compress/packet/Compressed.java b/smack-core/src/main/java/org/jivesoftware/smack/compress/packet/Compressed.java
index 29634f4cc..f614ad2c0 100644
--- a/smack-core/src/main/java/org/jivesoftware/smack/compress/packet/Compressed.java
+++ b/smack-core/src/main/java/org/jivesoftware/smack/compress/packet/Compressed.java
@@ -18,7 +18,7 @@ package org.jivesoftware.smack.compress.packet;
import org.jivesoftware.smack.packet.FullStreamElement;
-public class Compressed extends FullStreamElement {
+public final class Compressed extends FullStreamElement {
public static final String ELEMENT = "compressed";
public static final String NAMESPACE = Compress.NAMESPACE;
diff --git a/smack-core/src/main/java/org/jivesoftware/smack/filter/IQTypeFilter.java b/smack-core/src/main/java/org/jivesoftware/smack/filter/IQTypeFilter.java
index 1310b12d3..f84bdadb2 100644
--- a/smack-core/src/main/java/org/jivesoftware/smack/filter/IQTypeFilter.java
+++ b/smack-core/src/main/java/org/jivesoftware/smack/filter/IQTypeFilter.java
@@ -27,7 +27,7 @@ import org.jivesoftware.smack.util.Objects;
* @author Alexander Wenckus
*
*/
-public class IQTypeFilter extends FlexibleStanzaTypeFilter {
+public final class IQTypeFilter extends FlexibleStanzaTypeFilter {
public static final StanzaFilter GET = new IQTypeFilter(Type.get);
public static final StanzaFilter SET = new IQTypeFilter(Type.set);
diff --git a/smack-core/src/main/java/org/jivesoftware/smack/filter/MessageTypeFilter.java b/smack-core/src/main/java/org/jivesoftware/smack/filter/MessageTypeFilter.java
index 4305a384e..836151d45 100644
--- a/smack-core/src/main/java/org/jivesoftware/smack/filter/MessageTypeFilter.java
+++ b/smack-core/src/main/java/org/jivesoftware/smack/filter/MessageTypeFilter.java
@@ -27,7 +27,7 @@ import org.jivesoftware.smack.packet.Message.Type;
* @see org.jivesoftware.smack.packet.Message.Type
* @author Ward Harold
*/
-public class MessageTypeFilter extends FlexibleStanzaTypeFilter {
+public final class MessageTypeFilter extends FlexibleStanzaTypeFilter {
public static final StanzaFilter NORMAL = new MessageTypeFilter(Type.normal);
public static final StanzaFilter CHAT = new MessageTypeFilter(Type.chat);
diff --git a/smack-core/src/main/java/org/jivesoftware/smack/filter/MessageWithBodiesFilter.java b/smack-core/src/main/java/org/jivesoftware/smack/filter/MessageWithBodiesFilter.java
index 258c8c9c3..0ec082b77 100644
--- a/smack-core/src/main/java/org/jivesoftware/smack/filter/MessageWithBodiesFilter.java
+++ b/smack-core/src/main/java/org/jivesoftware/smack/filter/MessageWithBodiesFilter.java
@@ -22,7 +22,7 @@ import org.jivesoftware.smack.packet.Message;
/**
* Filters message stanzas which have at least one body.
*/
-public class MessageWithBodiesFilter extends FlexibleStanzaTypeFilter {
+public final class MessageWithBodiesFilter extends FlexibleStanzaTypeFilter {
public static final StanzaFilter INSTANCE = new MessageWithBodiesFilter();
diff --git a/smack-core/src/main/java/org/jivesoftware/smack/filter/MessageWithSubjectFilter.java b/smack-core/src/main/java/org/jivesoftware/smack/filter/MessageWithSubjectFilter.java
index 0955d9d55..ddc0833a1 100644
--- a/smack-core/src/main/java/org/jivesoftware/smack/filter/MessageWithSubjectFilter.java
+++ b/smack-core/src/main/java/org/jivesoftware/smack/filter/MessageWithSubjectFilter.java
@@ -22,7 +22,7 @@ import org.jivesoftware.smack.packet.Message;
/**
* Filters message stanzas which have at least one body.
*/
-public class MessageWithSubjectFilter extends FlexibleStanzaTypeFilter {
+public final class MessageWithSubjectFilter extends FlexibleStanzaTypeFilter {
public static final StanzaFilter INSTANCE = new MessageWithSubjectFilter();
diff --git a/smack-core/src/main/java/org/jivesoftware/smack/filter/PresenceTypeFilter.java b/smack-core/src/main/java/org/jivesoftware/smack/filter/PresenceTypeFilter.java
index 23464e956..a737091e6 100644
--- a/smack-core/src/main/java/org/jivesoftware/smack/filter/PresenceTypeFilter.java
+++ b/smack-core/src/main/java/org/jivesoftware/smack/filter/PresenceTypeFilter.java
@@ -24,7 +24,7 @@ import org.jivesoftware.smack.util.Objects;
* A filter for Presence types. Returns true only if the stanza is an Presence stanza(/packet) and it matches the type provided in the
* constructor.
*/
-public class PresenceTypeFilter extends FlexibleStanzaTypeFilter {
+public final class PresenceTypeFilter extends FlexibleStanzaTypeFilter {
public static final PresenceTypeFilter AVAILABLE = new PresenceTypeFilter(Type.available);
public static final PresenceTypeFilter UNAVAILABLE = new PresenceTypeFilter(Type.unavailable);
diff --git a/smack-core/src/main/java/org/jivesoftware/smack/packet/Bind.java b/smack-core/src/main/java/org/jivesoftware/smack/packet/Bind.java
index 83714b9bd..1b3252695 100644
--- a/smack-core/src/main/java/org/jivesoftware/smack/packet/Bind.java
+++ b/smack-core/src/main/java/org/jivesoftware/smack/packet/Bind.java
@@ -70,7 +70,7 @@ public class Bind extends IQ {
return xml;
}
- public static class Feature implements ExtensionElement {
+ public static final class Feature implements ExtensionElement {
public static final Feature INSTANCE = new Feature();
diff --git a/smack-core/src/main/java/org/jivesoftware/smack/packet/Message.java b/smack-core/src/main/java/org/jivesoftware/smack/packet/Message.java
index f1be2d0e2..50b855cc7 100644
--- a/smack-core/src/main/java/org/jivesoftware/smack/packet/Message.java
+++ b/smack-core/src/main/java/org/jivesoftware/smack/packet/Message.java
@@ -481,7 +481,7 @@ public final class Message extends Stanza implements TypedCloneable {
/**
* Represents a message subject, its language and the content of the subject.
*/
- public static class Subject {
+ public static final class Subject {
private final String subject;
private final String language;
@@ -544,7 +544,7 @@ public final class Message extends Stanza implements TypedCloneable {
/**
* Represents a message body, its language and the content of the message.
*/
- public static class Body {
+ public static final class Body {
private final String message;
private final String language;
diff --git a/smack-core/src/main/java/org/jivesoftware/smack/util/MultiMap.java b/smack-core/src/main/java/org/jivesoftware/smack/util/MultiMap.java
index 88868a0f8..480c94477 100644
--- a/smack-core/src/main/java/org/jivesoftware/smack/util/MultiMap.java
+++ b/smack-core/src/main/java/org/jivesoftware/smack/util/MultiMap.java
@@ -208,7 +208,7 @@ public class MultiMap {
return entrySet;
}
- private static class SimpleMapEntry implements Map.Entry {
+ private static final class SimpleMapEntry implements Map.Entry {
private final K key;
private V value;
diff --git a/smack-core/src/test/java/org/jivesoftware/smack/DummyConnection.java b/smack-core/src/test/java/org/jivesoftware/smack/DummyConnection.java
index 085b35466..844fc0d5c 100644
--- a/smack-core/src/test/java/org/jivesoftware/smack/DummyConnection.java
+++ b/smack-core/src/test/java/org/jivesoftware/smack/DummyConnection.java
@@ -223,7 +223,7 @@ public class DummyConnection extends AbstractXMPPConnection {
return new Builder();
}
- public static class Builder
+ public static final class Builder
extends
ConnectionConfiguration.Builder {
diff --git a/smack-debug/src/main/java/org/jivesoftware/smackx/debugger/EnhancedDebuggerWindow.java b/smack-debug/src/main/java/org/jivesoftware/smackx/debugger/EnhancedDebuggerWindow.java
index 6de6c7271..d5ec26ec8 100644
--- a/smack-debug/src/main/java/org/jivesoftware/smackx/debugger/EnhancedDebuggerWindow.java
+++ b/smack-debug/src/main/java/org/jivesoftware/smackx/debugger/EnhancedDebuggerWindow.java
@@ -56,7 +56,7 @@ import org.jivesoftware.smack.provider.ProviderManager;
*
* @author Gaston Dombiak
*/
-public class EnhancedDebuggerWindow {
+public final class EnhancedDebuggerWindow {
private static EnhancedDebuggerWindow instance;
diff --git a/smack-experimental/src/main/java/org/jivesoftware/smackx/carbons/CarbonManager.java b/smack-experimental/src/main/java/org/jivesoftware/smackx/carbons/CarbonManager.java
index b65d72d16..c3d30f615 100644
--- a/smack-experimental/src/main/java/org/jivesoftware/smackx/carbons/CarbonManager.java
+++ b/smack-experimental/src/main/java/org/jivesoftware/smackx/carbons/CarbonManager.java
@@ -47,7 +47,7 @@ import org.jivesoftware.smackx.disco.ServiceDiscoveryManager;
*
* @author Georg Lukas
*/
-public class CarbonManager extends Manager {
+public final class CarbonManager extends Manager {
private static Map INSTANCES = new WeakHashMap();
diff --git a/smack-experimental/src/main/java/org/jivesoftware/smackx/carbons/packet/CarbonExtension.java b/smack-experimental/src/main/java/org/jivesoftware/smackx/carbons/packet/CarbonExtension.java
index a82ca67c0..8fa7af1ad 100644
--- a/smack-experimental/src/main/java/org/jivesoftware/smackx/carbons/packet/CarbonExtension.java
+++ b/smack-experimental/src/main/java/org/jivesoftware/smackx/carbons/packet/CarbonExtension.java
@@ -131,7 +131,7 @@ public class CarbonExtension implements ExtensionElement {
* Stanza(/Packet) extension indicating that a message may not be carbon-copied. Adding this
* extension to any message will disallow that message from being copied.
*/
- public static class Private implements ExtensionElement {
+ public static final class Private implements ExtensionElement {
public static final Private INSTANCE = new Private();
public static final String ELEMENT = "private";
diff --git a/smack-experimental/src/main/java/org/jivesoftware/smackx/csi/packet/ClientStateIndication.java b/smack-experimental/src/main/java/org/jivesoftware/smackx/csi/packet/ClientStateIndication.java
index 0542741ef..24a617626 100644
--- a/smack-experimental/src/main/java/org/jivesoftware/smackx/csi/packet/ClientStateIndication.java
+++ b/smack-experimental/src/main/java/org/jivesoftware/smackx/csi/packet/ClientStateIndication.java
@@ -27,7 +27,7 @@ import org.jivesoftware.smack.packet.ExtensionElement;
public class ClientStateIndication {
public static final String NAMESPACE = "urn:xmpp:csi:0";
- public static class Active extends FullStreamElement {
+ public static final class Active extends FullStreamElement {
public static final Active INSTANCE = new Active();
public static final String ELEMENT = "active";
@@ -50,7 +50,7 @@ public class ClientStateIndication {
}
}
- public static class Inactive extends FullStreamElement {
+ public static final class Inactive extends FullStreamElement {
public static final Inactive INSTANCE = new Inactive();
public static final String ELEMENT = "inactive";
@@ -73,7 +73,7 @@ public class ClientStateIndication {
}
}
- public static class Feature implements ExtensionElement {
+ public static final class Feature implements ExtensionElement {
public static final Feature INSTANCE = new Feature();
public static final String ELEMENT = "csi";
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/address/packet/MultipleAddresses.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/address/packet/MultipleAddresses.java
index 7ab9fcf7c..14777bf0e 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/address/packet/MultipleAddresses.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/address/packet/MultipleAddresses.java
@@ -128,7 +128,7 @@ public class MultipleAddresses implements ExtensionElement {
return buf;
}
- public static class Address implements NamedElement {
+ public static final class Address implements NamedElement {
public static final String ELEMENT = "address";
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/bookmarks/BookmarkManager.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/bookmarks/BookmarkManager.java
index 13f8094f5..8b6fc5808 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/bookmarks/BookmarkManager.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/bookmarks/BookmarkManager.java
@@ -40,7 +40,7 @@ import org.jivesoftware.smackx.iqprivate.PrivateDataManager;
*
* @author Alexander Wenckus
*/
-public class BookmarkManager {
+public final class BookmarkManager {
private static final Map bookmarkManagerMap = new WeakHashMap();
static {
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/ibb/InBandBytestreamManager.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/ibb/InBandBytestreamManager.java
index a832f7489..3042fb774 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/ibb/InBandBytestreamManager.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/ibb/InBandBytestreamManager.java
@@ -79,7 +79,7 @@ import org.jxmpp.jid.Jid;
*
* @author Henning Staib
*/
-public class InBandBytestreamManager implements BytestreamManager {
+public final class InBandBytestreamManager implements BytestreamManager {
/**
* Stanzas that can be used to encapsulate In-Band Bytestream data packets.
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/socks5/Socks5Proxy.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/socks5/Socks5Proxy.java
index 585fa6e86..fd1b64996 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/socks5/Socks5Proxy.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/socks5/Socks5Proxy.java
@@ -68,7 +68,7 @@ import org.jivesoftware.smack.SmackException;
*
* @author Henning Staib
*/
-public class Socks5Proxy {
+public final class Socks5Proxy {
private static final Logger LOGGER = Logger.getLogger(Socks5Proxy.class.getName());
/* SOCKS5 proxy singleton */
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/caps/EntityCapsManager.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/caps/EntityCapsManager.java
index f6e615da1..154c6c791 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/caps/EntityCapsManager.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/caps/EntityCapsManager.java
@@ -71,7 +71,7 @@ import java.security.NoSuchAlgorithmException;
* @author Florian Schmaus
* @see XEP-0115: Entity Capabilities
*/
-public class EntityCapsManager extends Manager {
+public final class EntityCapsManager extends Manager {
private static final Logger LOGGER = Logger.getLogger(EntityCapsManager.class.getName());
public static final String NAMESPACE = CapsExtension.NAMESPACE;
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/chatstates/ChatStateManager.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/chatstates/ChatStateManager.java
index 84d07fbee..95372e50d 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/chatstates/ChatStateManager.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/chatstates/ChatStateManager.java
@@ -49,7 +49,7 @@ import org.jivesoftware.smackx.disco.ServiceDiscoveryManager;
* @see org.jivesoftware.smackx.chatstates.ChatState
* @see org.jivesoftware.smackx.chatstates.packet.ChatStateExtension
*/
-public class ChatStateManager extends Manager {
+public final class ChatStateManager extends Manager {
public static final String NAMESPACE = "http://jabber.org/protocol/chatstates";
private static final Map INSTANCES =
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/commands/AdHocCommandManager.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/commands/AdHocCommandManager.java
index 23e8d41c9..52fae4d1f 100755
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/commands/AdHocCommandManager.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/commands/AdHocCommandManager.java
@@ -60,7 +60,7 @@ import org.jxmpp.jid.Jid;
*
* @author Gabriel Guardincerri
*/
-public class AdHocCommandManager extends Manager {
+public final class AdHocCommandManager extends Manager {
public static final String NAMESPACE = "http://jabber.org/protocol/commands";
private static final Logger LOGGER = Logger.getLogger(AdHocCommandManager.class.getName());
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/delay/filter/DelayedStanzaFilter.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/delay/filter/DelayedStanzaFilter.java
index 433d157a2..2d17bda38 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/delay/filter/DelayedStanzaFilter.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/delay/filter/DelayedStanzaFilter.java
@@ -24,7 +24,7 @@ import org.jivesoftware.smackx.delay.DelayInformationManager;
/**
* Filters stanza with delay information, ie. stanzas that got delayed for some reason
*/
-public class DelayedStanzaFilter implements StanzaFilter {
+public final class DelayedStanzaFilter implements StanzaFilter {
public static final StanzaFilter INSTANCE = new DelayedStanzaFilter();
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/disco/ServiceDiscoveryManager.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/disco/ServiceDiscoveryManager.java
index 1ea1c2276..0193848e2 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/disco/ServiceDiscoveryManager.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/disco/ServiceDiscoveryManager.java
@@ -63,7 +63,7 @@ import java.util.logging.Logger;
*
* @author Gaston Dombiak
*/
-public class ServiceDiscoveryManager extends Manager {
+public final class ServiceDiscoveryManager extends Manager {
private static final Logger LOGGER = Logger.getLogger(ServiceDiscoveryManager.class.getName());
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/filetransfer/FileTransferManager.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/filetransfer/FileTransferManager.java
index f40fa6867..7a2ff2481 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/filetransfer/FileTransferManager.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/filetransfer/FileTransferManager.java
@@ -43,7 +43,7 @@ import java.util.concurrent.CopyOnWriteArrayList;
* @author Alexander Wenckus
*
*/
-public class FileTransferManager extends Manager {
+public final class FileTransferManager extends Manager {
private static final Map INSTANCES = new WeakHashMap();
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/filetransfer/FileTransferNegotiator.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/filetransfer/FileTransferNegotiator.java
index 05a672096..726ca6be0 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/filetransfer/FileTransferNegotiator.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/filetransfer/FileTransferNegotiator.java
@@ -52,7 +52,7 @@ import org.jxmpp.jid.Jid;
* @author Alexander Wenckus
* @see XEP-0096: SI File Transfer
*/
-public class FileTransferNegotiator extends Manager {
+public final class FileTransferNegotiator extends Manager {
public static final String SI_NAMESPACE = "http://jabber.org/protocol/si";
public static final String SI_PROFILE_FILE_TRANSFER_NAMESPACE = "http://jabber.org/protocol/si/profile/file-transfer";
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/filetransfer/IBBTransferNegotiator.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/filetransfer/IBBTransferNegotiator.java
index 4fb5b8e8a..27d63571c 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/filetransfer/IBBTransferNegotiator.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/filetransfer/IBBTransferNegotiator.java
@@ -105,7 +105,7 @@ public class IBBTransferNegotiator extends StreamNegotiator {
/**
* Derive from InBandBytestreamRequest to access protected constructor.
*/
- private static class ByteStreamRequest extends InBandBytestreamRequest {
+ private static final class ByteStreamRequest extends InBandBytestreamRequest {
private ByteStreamRequest(InBandBytestreamManager manager, Open byteStreamRequest) {
super(manager, byteStreamRequest);
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/filetransfer/Socks5TransferNegotiator.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/filetransfer/Socks5TransferNegotiator.java
index 8a77777e2..830812524 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/filetransfer/Socks5TransferNegotiator.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/filetransfer/Socks5TransferNegotiator.java
@@ -119,7 +119,7 @@ public class Socks5TransferNegotiator extends StreamNegotiator {
/**
* Derive from Socks5BytestreamRequest to access protected constructor.
*/
- private static class ByteStreamRequest extends Socks5BytestreamRequest {
+ private static final class ByteStreamRequest extends Socks5BytestreamRequest {
private ByteStreamRequest(Socks5BytestreamManager manager, Bytestream byteStreamRequest) {
super(manager, byteStreamRequest);
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/geoloc/GeoLocationManager.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/geoloc/GeoLocationManager.java
index c0f4fe3df..f3ada0e69 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/geoloc/GeoLocationManager.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/geoloc/GeoLocationManager.java
@@ -28,7 +28,7 @@ import org.jivesoftware.smack.packet.Message;
import org.jivesoftware.smackx.geoloc.packet.GeoLocation;
import org.jxmpp.jid.Jid;
-public class GeoLocationManager extends Manager {
+public final class GeoLocationManager extends Manager {
private static final Map INSTANCES = new WeakHashMap();
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/geoloc/packet/GeoLocation.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/geoloc/packet/GeoLocation.java
index 0bda4585e..2d89f1372 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/geoloc/packet/GeoLocation.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/geoloc/packet/GeoLocation.java
@@ -33,7 +33,7 @@ import org.jivesoftware.smack.util.XmlStringBuilder;
* @see XEP-0080
* @author Ishan Khanna
*/
-public class GeoLocation implements Serializable, ExtensionElement {
+public final class GeoLocation implements Serializable, ExtensionElement {
private static final long serialVersionUID = 1L;
public static final String NAMESPACE = "http://jabber.org/protocol/geoloc";
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/iqlast/LastActivityManager.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/iqlast/LastActivityManager.java
index 3fbed38f2..4783610c4 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/iqlast/LastActivityManager.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/iqlast/LastActivityManager.java
@@ -90,7 +90,7 @@ import org.jxmpp.jid.Jid;
* Activity
*/
-public class LastActivityManager extends Manager {
+public final class LastActivityManager extends Manager {
private static final Map instances = new WeakHashMap();
// private static final PacketFilter IQ_GET_LAST_FILTER = new AndFilter(IQTypeFilter.GET,
// new StanzaTypeFilter(LastActivity.class));
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/iqprivate/PrivateDataManager.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/iqprivate/PrivateDataManager.java
index c38194bd0..99a8c0b5c 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/iqprivate/PrivateDataManager.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/iqprivate/PrivateDataManager.java
@@ -59,7 +59,7 @@ import java.util.WeakHashMap;
*
* @author Matt Tucker
*/
-public class PrivateDataManager extends Manager {
+public final class PrivateDataManager extends Manager {
private static final Map instances = new WeakHashMap();
public static synchronized PrivateDataManager getInstanceFor(XMPPConnection connection) {
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/iqregister/AccountManager.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/iqregister/AccountManager.java
index ba2e64ae3..7da106910 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/iqregister/AccountManager.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/iqregister/AccountManager.java
@@ -41,7 +41,7 @@ import org.jivesoftware.smackx.iqregister.packet.Registration;
*
* @author Matt Tucker
*/
-public class AccountManager extends Manager {
+public final class AccountManager extends Manager {
private static final Logger LOGGER = Logger.getLogger(AccountManager.class.getName());
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/iqregister/packet/Registration.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/iqregister/packet/Registration.java
index 7267db2b9..73baa79f4 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/iqregister/packet/Registration.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/iqregister/packet/Registration.java
@@ -100,7 +100,7 @@ public class Registration extends IQ {
return xml;
}
- public static class Feature implements ExtensionElement {
+ public static final class Feature implements ExtensionElement {
public static final String ELEMENT = "register";
public static final String NAMESPACE = "http://jabber.org/features/iq-register";
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/iqversion/VersionManager.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/iqversion/VersionManager.java
index 8f081e679..b513ee7d0 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/iqversion/VersionManager.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/iqversion/VersionManager.java
@@ -53,7 +53,7 @@ import org.jxmpp.jid.Jid;
*
* @author Georg Lukas
*/
-public class VersionManager extends Manager {
+public final class VersionManager extends Manager {
private static final Map INSTANCES = new WeakHashMap();
private static Version defaultVersion;
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/muc/MultiUserChatManager.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/muc/MultiUserChatManager.java
index 9ad17cc6b..d599bedfb 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/muc/MultiUserChatManager.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/muc/MultiUserChatManager.java
@@ -55,7 +55,7 @@ import org.jxmpp.jid.DomainBareJid;
import org.jxmpp.jid.Jid;
import org.jxmpp.jid.JidWithLocalpart;
-public class MultiUserChatManager extends Manager {
+public final class MultiUserChatManager extends Manager {
private final static String DISCO_NODE = MUCInitialPresence.NAMESPACE + "#rooms";
private static final Logger LOGGER = Logger.getLogger(MultiUserChatManager.class.getName());
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/muc/packet/MUCUser.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/muc/packet/MUCUser.java
index d61785e03..e9ed4c8bc 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/muc/packet/MUCUser.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/muc/packet/MUCUser.java
@@ -413,7 +413,7 @@ public class MUCUser implements ExtensionElement {
*
* @author Gaston Dombiak
*/
- public static class Status implements NamedElement {
+ public static final class Status implements NamedElement {
public static final String ELEMENT = "status";
private static final Map statusMap = new HashMap(8);
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/ping/PingManager.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/ping/PingManager.java
index d27da55eb..4cdba66c7 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/ping/PingManager.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/ping/PingManager.java
@@ -60,7 +60,7 @@ import org.jxmpp.jid.Jid;
* @author Florian Schmaus
* @see XEP-0199:XMPP Ping
*/
-public class PingManager extends Manager {
+public final class PingManager extends Manager {
private static final Logger LOGGER = Logger.getLogger(PingManager.class.getName());
private static final Map INSTANCES = new WeakHashMap();
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/privacy/PrivacyListManager.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/privacy/PrivacyListManager.java
index 46908acc7..2d967df0c 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/privacy/PrivacyListManager.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/privacy/PrivacyListManager.java
@@ -62,7 +62,7 @@ import org.jivesoftware.smackx.privacy.packet.PrivacyItem;
* @author Francisco Vives
* @see XEP-16: Privacy Lists
*/
-public class PrivacyListManager extends Manager {
+public final class PrivacyListManager extends Manager {
public static final String NAMESPACE = Privacy.NAMESPACE;
public static final StanzaFilter PRIVACY_FILTER = new StanzaTypeFilter(Privacy.class);
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/privacy/filter/SetActiveListFilter.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/privacy/filter/SetActiveListFilter.java
index 9699ce3cb..5482930fd 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/privacy/filter/SetActiveListFilter.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/privacy/filter/SetActiveListFilter.java
@@ -20,7 +20,7 @@ import org.jivesoftware.smack.filter.FlexibleStanzaTypeFilter;
import org.jivesoftware.smack.packet.IQ.Type;
import org.jivesoftware.smackx.privacy.packet.Privacy;
-public class SetActiveListFilter extends FlexibleStanzaTypeFilter {
+public final class SetActiveListFilter extends FlexibleStanzaTypeFilter {
public static final SetActiveListFilter INSTANCE = new SetActiveListFilter();
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/privacy/filter/SetDefaultListFilter.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/privacy/filter/SetDefaultListFilter.java
index 5988d1427..ef83b870f 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/privacy/filter/SetDefaultListFilter.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/privacy/filter/SetDefaultListFilter.java
@@ -20,7 +20,7 @@ import org.jivesoftware.smack.filter.FlexibleStanzaTypeFilter;
import org.jivesoftware.smack.packet.IQ.Type;
import org.jivesoftware.smackx.privacy.packet.Privacy;
-public class SetDefaultListFilter extends FlexibleStanzaTypeFilter {
+public final class SetDefaultListFilter extends FlexibleStanzaTypeFilter {
public static final SetDefaultListFilter INSTANCE = new SetDefaultListFilter();
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/receipts/DeliveryReceiptManager.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/receipts/DeliveryReceiptManager.java
index 1c717767c..98f0f2b23 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/receipts/DeliveryReceiptManager.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/receipts/DeliveryReceiptManager.java
@@ -66,7 +66,7 @@ import org.jxmpp.jid.Jid;
* @author Georg Lukas
* @see XEP-0184: Message Delivery Receipts
*/
-public class DeliveryReceiptManager extends Manager {
+public final class DeliveryReceiptManager extends Manager {
private static final StanzaFilter MESSAGES_WITH_DEVLIERY_RECEIPT_REQUEST = new AndFilter(StanzaTypeFilter.MESSAGE,
new StanzaExtensionFilter(new DeliveryReceiptRequest()));
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/time/EntityTimeManager.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/time/EntityTimeManager.java
index ad96e2742..50454debd 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/time/EntityTimeManager.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/time/EntityTimeManager.java
@@ -36,7 +36,7 @@ import org.jivesoftware.smackx.disco.ServiceDiscoveryManager;
import org.jivesoftware.smackx.time.packet.Time;
import org.jxmpp.jid.Jid;
-public class EntityTimeManager extends Manager {
+public final class EntityTimeManager extends Manager {
private static final Map INSTANCES = new WeakHashMap();
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/vcardtemp/VCardManager.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/vcardtemp/VCardManager.java
index 96051bc07..60a8dacaf 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/vcardtemp/VCardManager.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/vcardtemp/VCardManager.java
@@ -33,7 +33,7 @@ import org.jivesoftware.smackx.vcardtemp.packet.VCard;
import org.jxmpp.jid.BareJid;
import org.jxmpp.jid.Jid;
-public class VCardManager extends Manager {
+public final class VCardManager extends Manager {
public static final String NAMESPACE = VCard.NAMESPACE;
public static final String ELEMENT = VCard.ELEMENT;
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/xdata/XDataManager.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/xdata/XDataManager.java
index 54a226da8..92575f1ec 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/xdata/XDataManager.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/xdata/XDataManager.java
@@ -30,7 +30,7 @@ import org.jivesoftware.smackx.disco.ServiceDiscoveryManager;
import org.jivesoftware.smackx.xdata.packet.DataForm;
import org.jxmpp.jid.Jid;
-public class XDataManager extends Manager {
+public final class XDataManager extends Manager {
/**
* The value of {@link DataForm#NAMESPACE}.
diff --git a/smack-extensions/src/test/java/org/jivesoftware/smackx/bytestreams/socks5/Socks5TestProxy.java b/smack-extensions/src/test/java/org/jivesoftware/smackx/bytestreams/socks5/Socks5TestProxy.java
index d4b2a9662..f40eb930b 100644
--- a/smack-extensions/src/test/java/org/jivesoftware/smackx/bytestreams/socks5/Socks5TestProxy.java
+++ b/smack-extensions/src/test/java/org/jivesoftware/smackx/bytestreams/socks5/Socks5TestProxy.java
@@ -37,7 +37,7 @@ import org.jivesoftware.smack.SmackException;
*
* @author Henning Staib
*/
-public class Socks5TestProxy {
+public final class Socks5TestProxy {
private static final Logger LOGGER = Logger.getLogger(Socks5TestProxy.class.getName());
/* SOCKS5 proxy singleton */
diff --git a/smack-im/src/main/java/org/jivesoftware/smack/chat/ChatManager.java b/smack-im/src/main/java/org/jivesoftware/smack/chat/ChatManager.java
index cec5af577..5d4345a44 100644
--- a/smack-im/src/main/java/org/jivesoftware/smack/chat/ChatManager.java
+++ b/smack-im/src/main/java/org/jivesoftware/smack/chat/ChatManager.java
@@ -53,7 +53,7 @@ import org.jxmpp.jid.JidWithLocalpart;
*
* @author Alexander Wenckus
*/
-public class ChatManager extends Manager{
+public final class ChatManager extends Manager{
private static final Logger LOGGER = Logger.getLogger(ChatManager.class.getName());
diff --git a/smack-im/src/main/java/org/jivesoftware/smack/roster/Roster.java b/smack-im/src/main/java/org/jivesoftware/smack/roster/Roster.java
index 8bad2b65b..e9d8b2c5d 100644
--- a/smack-im/src/main/java/org/jivesoftware/smack/roster/Roster.java
+++ b/smack-im/src/main/java/org/jivesoftware/smack/roster/Roster.java
@@ -82,7 +82,7 @@ import org.jxmpp.jid.parts.Resourcepart;
* @author Matt Tucker
* @see #getInstanceFor(XMPPConnection)
*/
-public class Roster extends Manager {
+public final class Roster extends Manager {
private static final Logger LOGGER = Logger.getLogger(Roster.class.getName());
@@ -1459,7 +1459,7 @@ public class Roster extends Manager {
/**
* Listens for all roster pushes and processes them.
*/
- private class RosterPushListener extends AbstractIqRequestHandler {
+ private final class RosterPushListener extends AbstractIqRequestHandler {
private RosterPushListener() {
super(RosterPacket.ELEMENT, RosterPacket.NAMESPACE, Type.set, Mode.sync);
diff --git a/smack-im/src/main/java/org/jivesoftware/smack/roster/packet/RosterVer.java b/smack-im/src/main/java/org/jivesoftware/smack/roster/packet/RosterVer.java
index 7a0c55cb5..49b509106 100644
--- a/smack-im/src/main/java/org/jivesoftware/smack/roster/packet/RosterVer.java
+++ b/smack-im/src/main/java/org/jivesoftware/smack/roster/packet/RosterVer.java
@@ -19,7 +19,7 @@ package org.jivesoftware.smack.roster.packet;
import org.jivesoftware.smack.packet.ExtensionElement;
import org.jivesoftware.smack.util.XmlStringBuilder;
-public class RosterVer implements ExtensionElement {
+public final class RosterVer implements ExtensionElement {
public static final String ELEMENT = "ver";
public static final String NAMESPACE = "urn:xmpp:features:rosterver";
diff --git a/smack-im/src/main/java/org/jivesoftware/smack/roster/packet/SubscriptionPreApproval.java b/smack-im/src/main/java/org/jivesoftware/smack/roster/packet/SubscriptionPreApproval.java
index 0a6fddc05..e75f009c0 100644
--- a/smack-im/src/main/java/org/jivesoftware/smack/roster/packet/SubscriptionPreApproval.java
+++ b/smack-im/src/main/java/org/jivesoftware/smack/roster/packet/SubscriptionPreApproval.java
@@ -19,7 +19,7 @@ package org.jivesoftware.smack.roster.packet;
import org.jivesoftware.smack.packet.ExtensionElement;
import org.jivesoftware.smack.util.XmlStringBuilder;
-public class SubscriptionPreApproval implements ExtensionElement {
+public final class SubscriptionPreApproval implements ExtensionElement {
public static final String ELEMENT = "sub";
public static final String NAMESPACE = "urn:xmpp:features:pre-approval";
diff --git a/smack-im/src/main/java/org/jivesoftware/smack/roster/rosterstore/DirectoryRosterStore.java b/smack-im/src/main/java/org/jivesoftware/smack/roster/rosterstore/DirectoryRosterStore.java
index e71622746..1fedc8550 100644
--- a/smack-im/src/main/java/org/jivesoftware/smack/roster/rosterstore/DirectoryRosterStore.java
+++ b/smack-im/src/main/java/org/jivesoftware/smack/roster/rosterstore/DirectoryRosterStore.java
@@ -44,7 +44,7 @@ import org.xmlpull.v1.XmlPullParserException;
* @author Lars Noschinski
* @author Fabian Schuetz
*/
-public class DirectoryRosterStore implements RosterStore {
+public final class DirectoryRosterStore implements RosterStore {
private final File fileDir;
diff --git a/smack-integration-test/src/main/java/org/igniterealtime/smack/inttest/Configuration.java b/smack-integration-test/src/main/java/org/igniterealtime/smack/inttest/Configuration.java
index 15e06e1f8..35f05dbbe 100644
--- a/smack-integration-test/src/main/java/org/igniterealtime/smack/inttest/Configuration.java
+++ b/smack-integration-test/src/main/java/org/igniterealtime/smack/inttest/Configuration.java
@@ -33,7 +33,7 @@ import org.jxmpp.jid.DomainBareJid;
import org.jxmpp.jid.impl.JidCreate;
import org.jxmpp.stringprep.XmppStringprepException;
-public class Configuration {
+public final class Configuration {
public final DomainBareJid service;
@@ -92,7 +92,7 @@ public class Configuration {
return new Builder();
}
- public static class Builder {
+ public static final class Builder {
private DomainBareJid service;
diff --git a/smack-integration-test/src/main/java/org/igniterealtime/smack/inttest/IntTestUtil.java b/smack-integration-test/src/main/java/org/igniterealtime/smack/inttest/IntTestUtil.java
index fc7a889a1..35a4d8516 100644
--- a/smack-integration-test/src/main/java/org/igniterealtime/smack/inttest/IntTestUtil.java
+++ b/smack-integration-test/src/main/java/org/igniterealtime/smack/inttest/IntTestUtil.java
@@ -55,7 +55,7 @@ public class IntTestUtil {
return new UsernameAndPassword(username, password);
}
- public static class UsernameAndPassword {
+ public static final class UsernameAndPassword {
public final String username;
public final String password;
diff --git a/smack-integration-test/src/main/java/org/igniterealtime/smack/inttest/SmackIntegrationTestFramework.java b/smack-integration-test/src/main/java/org/igniterealtime/smack/inttest/SmackIntegrationTestFramework.java
index 18a609720..571d2c1b3 100644
--- a/smack-integration-test/src/main/java/org/igniterealtime/smack/inttest/SmackIntegrationTestFramework.java
+++ b/smack-integration-test/src/main/java/org/igniterealtime/smack/inttest/SmackIntegrationTestFramework.java
@@ -595,7 +595,7 @@ public class SmackIntegrationTestFramework {
return (Exception) e;
}
- public static class TestRunResult {
+ public static final class TestRunResult {
public final String testRunId = StringUtils.randomString(5);
private final List successfulTests = Collections.synchronizedList(new LinkedList());
private final List failedIntegrationTests = Collections.synchronizedList(new LinkedList());
diff --git a/smack-java7/src/main/java/org/jivesoftware/smack/util/stringencoder/java7/Base64.java b/smack-java7/src/main/java/org/jivesoftware/smack/util/stringencoder/java7/Base64.java
index 093c60639..28385b7e6 100644
--- a/smack-java7/src/main/java/org/jivesoftware/smack/util/stringencoder/java7/Base64.java
+++ b/smack-java7/src/main/java/org/jivesoftware/smack/util/stringencoder/java7/Base64.java
@@ -29,7 +29,7 @@ import java.util.logging.Logger;
* @author rob@iharder.net
* @version 2.2.1
*/
-public class Base64
+public final class Base64
{
private static final Logger LOGGER = Logger.getLogger(Base64.class.getName());
diff --git a/smack-java7/src/main/java/org/jivesoftware/smack/util/stringencoder/java7/Java7Base64Encoder.java b/smack-java7/src/main/java/org/jivesoftware/smack/util/stringencoder/java7/Java7Base64Encoder.java
index 129de87c6..bc211e4ab 100644
--- a/smack-java7/src/main/java/org/jivesoftware/smack/util/stringencoder/java7/Java7Base64Encoder.java
+++ b/smack-java7/src/main/java/org/jivesoftware/smack/util/stringencoder/java7/Java7Base64Encoder.java
@@ -24,7 +24,7 @@ import org.jivesoftware.smack.util.StringUtils;
* A Base 64 encoding implementation.
* @author Florian Schmaus
*/
-public class Java7Base64Encoder implements org.jivesoftware.smack.util.stringencoder.Base64.Encoder {
+public final class Java7Base64Encoder implements org.jivesoftware.smack.util.stringencoder.Base64.Encoder {
private static Java7Base64Encoder instance = new Java7Base64Encoder();
diff --git a/smack-java7/src/main/java/org/jivesoftware/smack/util/stringencoder/java7/Java7Base64UrlSafeEncoder.java b/smack-java7/src/main/java/org/jivesoftware/smack/util/stringencoder/java7/Java7Base64UrlSafeEncoder.java
index d5e6e9750..3b9cfa451 100644
--- a/smack-java7/src/main/java/org/jivesoftware/smack/util/stringencoder/java7/Java7Base64UrlSafeEncoder.java
+++ b/smack-java7/src/main/java/org/jivesoftware/smack/util/stringencoder/java7/Java7Base64UrlSafeEncoder.java
@@ -30,7 +30,7 @@ import org.jivesoftware.smack.util.stringencoder.StringEncoder;
*
* @author Robin Collier
*/
-public class Java7Base64UrlSafeEncoder implements StringEncoder {
+public final class Java7Base64UrlSafeEncoder implements StringEncoder {
private static Java7Base64UrlSafeEncoder instance = new Java7Base64UrlSafeEncoder();
diff --git a/smack-legacy/src/main/java/org/jivesoftware/smackx/workgroup/agent/WorkgroupQueue.java b/smack-legacy/src/main/java/org/jivesoftware/smackx/workgroup/agent/WorkgroupQueue.java
index a22aa14c5..f2c0e61d2 100644
--- a/smack-legacy/src/main/java/org/jivesoftware/smackx/workgroup/agent/WorkgroupQueue.java
+++ b/smack-legacy/src/main/java/org/jivesoftware/smackx/workgroup/agent/WorkgroupQueue.java
@@ -170,7 +170,7 @@ public class WorkgroupQueue {
* chat requests.
*
*/
- public static class Status {
+ public static final class Status {
/**
* The queue is active and accepting new chat requests.
diff --git a/smack-legacy/src/main/java/org/jivesoftware/smackx/workgroup/packet/QueueDetails.java b/smack-legacy/src/main/java/org/jivesoftware/smackx/workgroup/packet/QueueDetails.java
index a9399ca58..8d11ebb2c 100644
--- a/smack-legacy/src/main/java/org/jivesoftware/smackx/workgroup/packet/QueueDetails.java
+++ b/smack-legacy/src/main/java/org/jivesoftware/smackx/workgroup/packet/QueueDetails.java
@@ -37,7 +37,7 @@ import java.util.logging.Logger;
* Queue details stanza(/packet) extension, which contains details about the users
* currently in a queue.
*/
-public class QueueDetails implements ExtensionElement {
+public final class QueueDetails implements ExtensionElement {
private static final Logger LOGGER = Logger.getLogger(QueueDetails.class.getName());
/**
diff --git a/smack-legacy/src/main/java/org/jivesoftware/smackx/xevent/MessageEventManager.java b/smack-legacy/src/main/java/org/jivesoftware/smackx/xevent/MessageEventManager.java
index 3594c9ddc..ba8763a02 100644
--- a/smack-legacy/src/main/java/org/jivesoftware/smackx/xevent/MessageEventManager.java
+++ b/smack-legacy/src/main/java/org/jivesoftware/smackx/xevent/MessageEventManager.java
@@ -48,7 +48,7 @@ import org.jxmpp.jid.Jid;
* @author Gaston Dombiak
* @see XEP-22: Message Events
*/
-public class MessageEventManager extends Manager {
+public final class MessageEventManager extends Manager {
private static final Logger LOGGER = Logger.getLogger(MessageEventManager.class.getName());
private static final Map INSTANCES = new WeakHashMap<>();
diff --git a/smack-tcp/src/main/java/org/jivesoftware/smack/sm/packet/StreamManagement.java b/smack-tcp/src/main/java/org/jivesoftware/smack/sm/packet/StreamManagement.java
index 46d85a140..cb68d1cea 100644
--- a/smack-tcp/src/main/java/org/jivesoftware/smack/sm/packet/StreamManagement.java
+++ b/smack-tcp/src/main/java/org/jivesoftware/smack/sm/packet/StreamManagement.java
@@ -24,7 +24,7 @@ import org.jivesoftware.smack.util.XmlStringBuilder;
public class StreamManagement {
public static final String NAMESPACE = "urn:xmpp:sm:3";
- public static class StreamManagementFeature implements ExtensionElement {
+ public static final class StreamManagementFeature implements ExtensionElement {
public static final String ELEMENT = "sm";
public static final StreamManagementFeature INSTANCE = new StreamManagementFeature();
@@ -320,7 +320,7 @@ public class StreamManagement {
}
}
- public static class AckRequest extends FullStreamElement {
+ public static final class AckRequest extends FullStreamElement {
public static final String ELEMENT = "r";
public static final AckRequest INSTANCE = new AckRequest();
diff --git a/smack-tcp/src/main/java/org/jivesoftware/smack/sm/predicates/ForEveryMessage.java b/smack-tcp/src/main/java/org/jivesoftware/smack/sm/predicates/ForEveryMessage.java
index 7bd3d1443..c248d23de 100644
--- a/smack-tcp/src/main/java/org/jivesoftware/smack/sm/predicates/ForEveryMessage.java
+++ b/smack-tcp/src/main/java/org/jivesoftware/smack/sm/predicates/ForEveryMessage.java
@@ -20,7 +20,7 @@ import org.jivesoftware.smack.filter.StanzaFilter;
import org.jivesoftware.smack.packet.Message;
import org.jivesoftware.smack.packet.Stanza;
-public class ForEveryMessage implements StanzaFilter {
+public final class ForEveryMessage implements StanzaFilter {
public static final ForEveryMessage INSTANCE = new ForEveryMessage();
diff --git a/smack-tcp/src/main/java/org/jivesoftware/smack/sm/predicates/ForEveryStanza.java b/smack-tcp/src/main/java/org/jivesoftware/smack/sm/predicates/ForEveryStanza.java
index 24f923752..bbf73806c 100644
--- a/smack-tcp/src/main/java/org/jivesoftware/smack/sm/predicates/ForEveryStanza.java
+++ b/smack-tcp/src/main/java/org/jivesoftware/smack/sm/predicates/ForEveryStanza.java
@@ -19,7 +19,7 @@ package org.jivesoftware.smack.sm.predicates;
import org.jivesoftware.smack.filter.StanzaFilter;
import org.jivesoftware.smack.packet.Stanza;
-public class ForEveryStanza implements StanzaFilter {
+public final class ForEveryStanza implements StanzaFilter {
public static final ForEveryStanza INSTANCE = new ForEveryStanza();
diff --git a/smack-tcp/src/main/java/org/jivesoftware/smack/sm/predicates/OnceForThisStanza.java b/smack-tcp/src/main/java/org/jivesoftware/smack/sm/predicates/OnceForThisStanza.java
index 15c00004c..94c9e6863 100644
--- a/smack-tcp/src/main/java/org/jivesoftware/smack/sm/predicates/OnceForThisStanza.java
+++ b/smack-tcp/src/main/java/org/jivesoftware/smack/sm/predicates/OnceForThisStanza.java
@@ -21,7 +21,7 @@ import org.jivesoftware.smack.packet.Stanza;
import org.jivesoftware.smack.tcp.XMPPTCPConnection;
import org.jivesoftware.smack.util.StringUtils;
-public class OnceForThisStanza implements StanzaFilter {
+public final class OnceForThisStanza implements StanzaFilter {
private final String id;
private final XMPPTCPConnection connection;
diff --git a/smack-tcp/src/main/java/org/jivesoftware/smack/tcp/XMPPTCPConnectionConfiguration.java b/smack-tcp/src/main/java/org/jivesoftware/smack/tcp/XMPPTCPConnectionConfiguration.java
index 7e0359d8b..844830a0d 100644
--- a/smack-tcp/src/main/java/org/jivesoftware/smack/tcp/XMPPTCPConnectionConfiguration.java
+++ b/smack-tcp/src/main/java/org/jivesoftware/smack/tcp/XMPPTCPConnectionConfiguration.java
@@ -33,7 +33,7 @@ import org.jivesoftware.smack.ConnectionConfiguration;
* }
*
*/
-public class XMPPTCPConnectionConfiguration extends ConnectionConfiguration {
+public final class XMPPTCPConnectionConfiguration extends ConnectionConfiguration {
/**
* The default connect timeout in milliseconds. Preinitialized with 30000 (30 seconds). If this value is changed,
@@ -84,7 +84,7 @@ public class XMPPTCPConnectionConfiguration extends ConnectionConfiguration {
* A configuration builder for XMPP connections over TCP. Use {@link XMPPTCPConnectionConfiguration#builder()} to
* obtain a new instance and {@link #build} to build the configuration.
*/
- public static class Builder extends ConnectionConfiguration.Builder {
+ public static final class Builder extends ConnectionConfiguration.Builder {
private boolean compressionEnabled = false;
private int connectTimeout = DEFAULT_CONNECT_TIMEOUT;