debuggersToRemove = new ArrayList<>();
// Remove all the debuggers of which their connections are no longer valid
for (int index = 0; index < tabbedPane.getComponentCount() - 1; index++) {
EnhancedDebugger debugger = debuggers.get(index);
diff --git a/smack-experimental/src/main/java/org/jivesoftware/smackx/carbons/packet/CarbonExtension.java b/smack-experimental/src/main/java/org/jivesoftware/smackx/carbons/packet/CarbonExtension.java
index f6d63952d..b0e1f9685 100644
--- a/smack-experimental/src/main/java/org/jivesoftware/smackx/carbons/packet/CarbonExtension.java
+++ b/smack-experimental/src/main/java/org/jivesoftware/smackx/carbons/packet/CarbonExtension.java
@@ -123,7 +123,7 @@ public class CarbonExtension implements ExtensionElement {
/**
* Defines the direction of a {@link CarbonExtension} message.
*/
- public static enum Direction {
+ public enum Direction {
received,
sent
}
diff --git a/smack-experimental/src/main/java/org/jivesoftware/smackx/eme/element/ExplicitMessageEncryptionElement.java b/smack-experimental/src/main/java/org/jivesoftware/smackx/eme/element/ExplicitMessageEncryptionElement.java
index c98f22cd4..04e0df9c6 100644
--- a/smack-experimental/src/main/java/org/jivesoftware/smackx/eme/element/ExplicitMessageEncryptionElement.java
+++ b/smack-experimental/src/main/java/org/jivesoftware/smackx/eme/element/ExplicitMessageEncryptionElement.java
@@ -48,7 +48,7 @@ public class ExplicitMessageEncryptionElement implements ExtensionElement {
private final String namespace;
private final String name;
- private ExplicitMessageEncryptionProtocol(String namespace, String name) {
+ ExplicitMessageEncryptionProtocol(String namespace, String name) {
this.namespace = namespace;
this.name = name;
PROTOCOL_LUT.put(namespace, this);
diff --git a/smack-experimental/src/main/java/org/jivesoftware/smackx/hoxt/packet/AbstractHttpOverXmpp.java b/smack-experimental/src/main/java/org/jivesoftware/smackx/hoxt/packet/AbstractHttpOverXmpp.java
index 0842b15ae..03f335e02 100644
--- a/smack-experimental/src/main/java/org/jivesoftware/smackx/hoxt/packet/AbstractHttpOverXmpp.java
+++ b/smack-experimental/src/main/java/org/jivesoftware/smackx/hoxt/packet/AbstractHttpOverXmpp.java
@@ -90,7 +90,7 @@ public abstract class AbstractHttpOverXmpp extends IQ {
/**
* A builder for XMPP connection configurations.
*
- * See ConnectionConfiguration Buidler for more details.
+ * See ConnectionConfiguration Builder for more details.
*
*
* @param the builder type parameter.
diff --git a/smack-experimental/src/main/java/org/jivesoftware/smackx/iot/control/ThingControlRequest.java b/smack-experimental/src/main/java/org/jivesoftware/smackx/iot/control/ThingControlRequest.java
index 3eb58e40e..cfdc245c7 100644
--- a/smack-experimental/src/main/java/org/jivesoftware/smackx/iot/control/ThingControlRequest.java
+++ b/smack-experimental/src/main/java/org/jivesoftware/smackx/iot/control/ThingControlRequest.java
@@ -26,6 +26,6 @@ import org.jxmpp.jid.Jid;
public interface ThingControlRequest {
- public void processRequest(Jid from, Collection setData) throws XMPPErrorException;
+ void processRequest(Jid from, Collection setData) throws XMPPErrorException;
}
diff --git a/smack-experimental/src/main/java/org/jivesoftware/smackx/iot/control/element/IoTSetResponse.java b/smack-experimental/src/main/java/org/jivesoftware/smackx/iot/control/element/IoTSetResponse.java
index a742355af..68fce1441 100644
--- a/smack-experimental/src/main/java/org/jivesoftware/smackx/iot/control/element/IoTSetResponse.java
+++ b/smack-experimental/src/main/java/org/jivesoftware/smackx/iot/control/element/IoTSetResponse.java
@@ -29,7 +29,7 @@ public class IoTSetResponse extends IQ {
public IoTSetResponse(IoTSetRequest iotSetRequest) {
this();
- initialzeAsResultFor(iotSetRequest);
+ initializeAsResultFor(iotSetRequest);
}
@Override
diff --git a/smack-experimental/src/main/java/org/jivesoftware/smackx/iot/control/element/SetData.java b/smack-experimental/src/main/java/org/jivesoftware/smackx/iot/control/element/SetData.java
index 4d9e29286..e2e004f00 100644
--- a/smack-experimental/src/main/java/org/jivesoftware/smackx/iot/control/element/SetData.java
+++ b/smack-experimental/src/main/java/org/jivesoftware/smackx/iot/control/element/SetData.java
@@ -32,7 +32,7 @@ public abstract class SetData implements NamedElement {
private final String toStringCache;
- private Type() {
+ Type() {
toStringCache = this.name().toLowerCase(Locale.US);
}
diff --git a/smack-experimental/src/main/java/org/jivesoftware/smackx/iot/data/ThingMomentaryReadOutRequest.java b/smack-experimental/src/main/java/org/jivesoftware/smackx/iot/data/ThingMomentaryReadOutRequest.java
index f7d2a1b59..9f3652054 100644
--- a/smack-experimental/src/main/java/org/jivesoftware/smackx/iot/data/ThingMomentaryReadOutRequest.java
+++ b/smack-experimental/src/main/java/org/jivesoftware/smackx/iot/data/ThingMomentaryReadOutRequest.java
@@ -18,6 +18,6 @@ package org.jivesoftware.smackx.iot.data;
public interface ThingMomentaryReadOutRequest {
- public void momentaryReadOutRequest(ThingMomentaryReadOutResult callback);
+ void momentaryReadOutRequest(ThingMomentaryReadOutResult callback);
}
diff --git a/smack-experimental/src/main/java/org/jivesoftware/smackx/iot/data/ThingMomentaryReadOutResult.java b/smack-experimental/src/main/java/org/jivesoftware/smackx/iot/data/ThingMomentaryReadOutResult.java
index 4662552af..0f8cb431a 100644
--- a/smack-experimental/src/main/java/org/jivesoftware/smackx/iot/data/ThingMomentaryReadOutResult.java
+++ b/smack-experimental/src/main/java/org/jivesoftware/smackx/iot/data/ThingMomentaryReadOutResult.java
@@ -22,6 +22,6 @@ import org.jivesoftware.smackx.iot.data.element.IoTDataField;
public interface ThingMomentaryReadOutResult {
- public void momentaryReadOut(List extends IoTDataField> results);
+ void momentaryReadOut(List extends IoTDataField> results);
}
diff --git a/smack-experimental/src/main/java/org/jivesoftware/smackx/iot/data/element/IoTDataRequest.java b/smack-experimental/src/main/java/org/jivesoftware/smackx/iot/data/element/IoTDataRequest.java
index 70f3df80d..7c370e10b 100644
--- a/smack-experimental/src/main/java/org/jivesoftware/smackx/iot/data/element/IoTDataRequest.java
+++ b/smack-experimental/src/main/java/org/jivesoftware/smackx/iot/data/element/IoTDataRequest.java
@@ -24,7 +24,7 @@ public class IoTDataRequest extends IQ {
public static final String NAMESPACE = Constants.IOT_SENSORDATA_NAMESPACE;
/**
- * The sequence nummber. According to XEP-0323 an xs:int.
+ * The sequence number. According to XEP-0323 an xs:int.
*/
private final int seqNr;
diff --git a/smack-experimental/src/main/java/org/jivesoftware/smackx/iot/discovery/ThingStateChangeListener.java b/smack-experimental/src/main/java/org/jivesoftware/smackx/iot/discovery/ThingStateChangeListener.java
index b64d67d21..7e688adaa 100644
--- a/smack-experimental/src/main/java/org/jivesoftware/smackx/iot/discovery/ThingStateChangeListener.java
+++ b/smack-experimental/src/main/java/org/jivesoftware/smackx/iot/discovery/ThingStateChangeListener.java
@@ -20,6 +20,6 @@ import org.jxmpp.jid.BareJid;
public interface ThingStateChangeListener {
- public void owned(BareJid owner);
+ void owned(BareJid owner);
}
diff --git a/smack-experimental/src/main/java/org/jivesoftware/smackx/iot/discovery/element/Tag.java b/smack-experimental/src/main/java/org/jivesoftware/smackx/iot/discovery/element/Tag.java
index 0ea8c6b4f..495e5019b 100644
--- a/smack-experimental/src/main/java/org/jivesoftware/smackx/iot/discovery/element/Tag.java
+++ b/smack-experimental/src/main/java/org/jivesoftware/smackx/iot/discovery/element/Tag.java
@@ -25,7 +25,7 @@ public class Tag implements NamedElement {
public enum Type {
str,
- num;
+ num
}
private final String name;
diff --git a/smack-experimental/src/main/java/org/jivesoftware/smackx/iot/provisioning/IoTProvisioningManager.java b/smack-experimental/src/main/java/org/jivesoftware/smackx/iot/provisioning/IoTProvisioningManager.java
index a1d2c9cfe..6e6177cba 100644
--- a/smack-experimental/src/main/java/org/jivesoftware/smackx/iot/provisioning/IoTProvisioningManager.java
+++ b/smack-experimental/src/main/java/org/jivesoftware/smackx/iot/provisioning/IoTProvisioningManager.java
@@ -161,8 +161,8 @@ public final class IoTProvisioningManager extends Manager {
// Notify the recommended friend that we will now accept his
// friendship requests.
final XMPPConnection connection = connection();
- Friend friendNotifiacation = new Friend(connection.getUser().asBareJid());
- Message notificationMessage = new Message(friendJid, friendNotifiacation);
+ Friend friendNotification = new Friend(connection.getUser().asBareJid());
+ Message notificationMessage = new Message(friendJid, friendNotification);
connection.sendStanza(notificationMessage);
} else {
// Check is the message was send from a thing we previously
@@ -236,7 +236,7 @@ public final class IoTProvisioningManager extends Manager {
}
catch (NoResponseException | XMPPErrorException | NotConnectedException | InterruptedException e) {
LOGGER.log(Level.WARNING,
- "Could not determine privisioning server. Ignoring friend request from " + from, e);
+ "Could not determine provisioning server. Ignoring friend request from " + from, e);
}
if (provisioningServer == null) {
return null;
@@ -420,7 +420,7 @@ public final class IoTProvisioningManager extends Manager {
if (!provisioningServer.equals(stanza.getFrom())) {
if (log) {
LOGGER.warning("Ignoring request '" + stanza
- + "' because not from provising server '" + provisioningServer
+ + "' because not from provisioning server '" + provisioningServer
+ "'.");
}
return false;
diff --git a/smack-experimental/src/main/java/org/jivesoftware/smackx/mam/MamManager.java b/smack-experimental/src/main/java/org/jivesoftware/smackx/mam/MamManager.java
index 9d800f73c..35abea501 100644
--- a/smack-experimental/src/main/java/org/jivesoftware/smackx/mam/MamManager.java
+++ b/smack-experimental/src/main/java/org/jivesoftware/smackx/mam/MamManager.java
@@ -239,11 +239,11 @@ public final class MamManager extends Manager {
/**
- * Query an message archive like a MUC archive or a pubsub node archive, addressed by an archiveAddress, applying
+ * Query an message archive like a MUC archive or a PubSub node archive, addressed by an archiveAddress, applying
* filters: max count, start date, end date, from/to JID and with additional fields. When archiveAddress is null the
* default, the server will be requested.
*
- * @param node The Pubsub node name, can be null
+ * @param node The PubSub node name, can be null
* @param max
* @param start
* @param end
@@ -346,7 +346,7 @@ public final class MamManager extends Manager {
/**
* Returns a page of the archive.
*
- * @param node The Pubsub node name, can be null
+ * @param node The PubSub node name, can be null
* @param dataForm
* @param rsmSet
* @return the MAM query result
@@ -498,7 +498,7 @@ public final class MamManager extends Manager {
/**
* Get the form fields supported by the server.
*
- * @param node The Pubsub node name, can be null
+ * @param node The PubSub node name, can be null
* @return the list of form fields.
* @throws NoResponseException
* @throws XMPPErrorException
@@ -521,7 +521,7 @@ public final class MamManager extends Manager {
private MamQueryResult queryArchive(MamQueryIQ mamQueryIq) throws NoResponseException, XMPPErrorException,
NotConnectedException, InterruptedException, NotLoggedInException {
final XMPPConnection connection = getAuthenticatedConnectionOrThrow();
- MamFinIQ mamFinIQ = null;
+ MamFinIQ mamFinIQ;
StanzaCollector mamFinIQCollector = connection.createStanzaCollector(new IQReplyFilter(mamQueryIq, connection));
diff --git a/smack-experimental/src/main/java/org/jivesoftware/smackx/muclight/MultiUserChatLight.java b/smack-experimental/src/main/java/org/jivesoftware/smackx/muclight/MultiUserChatLight.java
index 41f13b8e3..dee356819 100644
--- a/smack-experimental/src/main/java/org/jivesoftware/smackx/muclight/MultiUserChatLight.java
+++ b/smack-experimental/src/main/java/org/jivesoftware/smackx/muclight/MultiUserChatLight.java
@@ -82,7 +82,7 @@ public class MultiUserChatLight {
* Same as {@link #fromRoomFilter} together with
* {@link MessageTypeFilter#GROUPCHAT}.
*/
- private final StanzaFilter fromRoomGroupchatFilter;
+ private final StanzaFilter fromRoomGroupChatFilter;
private final StanzaListener messageListener;
@@ -93,7 +93,7 @@ public class MultiUserChatLight {
this.room = room;
fromRoomFilter = FromMatchesFilter.create(room);
- fromRoomGroupchatFilter = new AndFilter(fromRoomFilter, MessageTypeFilter.GROUPCHAT);
+ fromRoomGroupChatFilter = new AndFilter(fromRoomFilter, MessageTypeFilter.GROUPCHAT);
messageListener = new StanzaListener() {
@Override
@@ -105,7 +105,7 @@ public class MultiUserChatLight {
}
};
- connection.addSyncStanzaListener(messageListener, fromRoomGroupchatFilter);
+ connection.addSyncStanzaListener(messageListener, fromRoomGroupChatFilter);
}
/**
@@ -265,7 +265,7 @@ public class MultiUserChatLight {
throws Exception {
MUCLightCreateIQ createMUCLightIQ = new MUCLightCreateIQ(room, roomName, occupants);
- messageCollector = connection.createStanzaCollector(fromRoomGroupchatFilter);
+ messageCollector = connection.createStanzaCollector(fromRoomGroupChatFilter);
try {
connection.createStanzaCollectorAndSend(createMUCLightIQ).nextResultOrThrow();
diff --git a/smack-experimental/src/main/java/org/jivesoftware/smackx/muclight/MultiUserChatLightManager.java b/smack-experimental/src/main/java/org/jivesoftware/smackx/muclight/MultiUserChatLightManager.java
index 81f270c16..67e8fdd77 100644
--- a/smack-experimental/src/main/java/org/jivesoftware/smackx/muclight/MultiUserChatLightManager.java
+++ b/smack-experimental/src/main/java/org/jivesoftware/smackx/muclight/MultiUserChatLightManager.java
@@ -96,7 +96,7 @@ public final class MultiUserChatLightManager extends Manager {
private MultiUserChatLight createNewMucLightAndAddToMap(EntityBareJid jid) {
MultiUserChatLight multiUserChatLight = new MultiUserChatLight(connection(), jid);
- multiUserChatLights.put(jid, new WeakReference(multiUserChatLight));
+ multiUserChatLights.put(jid, new WeakReference<>(multiUserChatLight));
return multiUserChatLight;
}
@@ -193,11 +193,11 @@ public final class MultiUserChatLightManager extends Manager {
*/
public List getRoomsBlocked(DomainBareJid mucLightService)
throws NoResponseException, XMPPErrorException, NotConnectedException, InterruptedException {
- MUCLightBlockingIQ muclIghtBlockingIQResult = getBlockingList(mucLightService);
+ MUCLightBlockingIQ mucLightBlockingIQResult = getBlockingList(mucLightService);
List jids = new ArrayList<>();
- if (muclIghtBlockingIQResult.getRooms() != null) {
- jids.addAll(muclIghtBlockingIQResult.getRooms().keySet());
+ if (mucLightBlockingIQResult.getRooms() != null) {
+ jids.addAll(mucLightBlockingIQResult.getRooms().keySet());
}
return jids;
@@ -215,11 +215,11 @@ public final class MultiUserChatLightManager extends Manager {
*/
public List getUsersBlocked(DomainBareJid mucLightService)
throws NoResponseException, XMPPErrorException, NotConnectedException, InterruptedException {
- MUCLightBlockingIQ muclIghtBlockingIQResult = getBlockingList(mucLightService);
+ MUCLightBlockingIQ mucLightBlockingIQResult = getBlockingList(mucLightService);
List jids = new ArrayList<>();
- if (muclIghtBlockingIQResult.getUsers() != null) {
- jids.addAll(muclIghtBlockingIQResult.getUsers().keySet());
+ if (mucLightBlockingIQResult.getUsers() != null) {
+ jids.addAll(mucLightBlockingIQResult.getUsers().keySet());
}
return jids;
@@ -234,9 +234,9 @@ public final class MultiUserChatLightManager extends Manager {
StanzaFilter responseFilter = new IQReplyFilter(mucLightBlockingIQ, connection());
IQ responseIq = connection().createStanzaCollectorAndSend(responseFilter, mucLightBlockingIQ)
.nextResultOrThrow();
- MUCLightBlockingIQ muclIghtBlockingIQResult = (MUCLightBlockingIQ) responseIq;
+ MUCLightBlockingIQ mucLightBlockingIQResult = (MUCLightBlockingIQ) responseIq;
- return muclIghtBlockingIQResult;
+ return mucLightBlockingIQResult;
}
/**
diff --git a/smack-experimental/src/test/java/org/jivesoftware/smackx/ExperimentalInitializerTest.java b/smack-experimental/src/test/java/org/jivesoftware/smackx/ExperimentalInitializerTest.java
index 48cca1e63..dff548f50 100644
--- a/smack-experimental/src/test/java/org/jivesoftware/smackx/ExperimentalInitializerTest.java
+++ b/smack-experimental/src/test/java/org/jivesoftware/smackx/ExperimentalInitializerTest.java
@@ -27,7 +27,7 @@ import org.junit.Test;
public class ExperimentalInitializerTest {
@Test
- public void testExperimentalInitialzer() {
+ public void testExperimentalInitializer() {
ExperimentalInitializer epi = new ExperimentalInitializer();
List exceptions = epi.initialize();
assertTrue(exceptions.size() == 0);
diff --git a/smack-experimental/src/test/java/org/jivesoftware/smackx/carbons/CarbonTest.java b/smack-experimental/src/test/java/org/jivesoftware/smackx/carbons/CarbonTest.java
index acf139c6e..d0dbc2cf9 100644
--- a/smack-experimental/src/test/java/org/jivesoftware/smackx/carbons/CarbonTest.java
+++ b/smack-experimental/src/test/java/org/jivesoftware/smackx/carbons/CarbonTest.java
@@ -16,7 +16,7 @@
*/
package org.jivesoftware.smackx.carbons;
-import static org.jivesoftware.smack.test.util.CharsequenceEquals.equalsCharSequence;
+import static org.jivesoftware.smack.test.util.CharSequenceEquals.equalsCharSequence;
import static org.junit.Assert.assertEquals;
import static org.junit.Assert.assertThat;
diff --git a/smack-experimental/src/test/java/org/jivesoftware/smackx/chat_markers/AcknowledgedExtensionTest.java b/smack-experimental/src/test/java/org/jivesoftware/smackx/chat_markers/AcknowledgedExtensionTest.java
index 3ed4d3c12..b7d7eb595 100644
--- a/smack-experimental/src/test/java/org/jivesoftware/smackx/chat_markers/AcknowledgedExtensionTest.java
+++ b/smack-experimental/src/test/java/org/jivesoftware/smackx/chat_markers/AcknowledgedExtensionTest.java
@@ -49,7 +49,7 @@ public class AcknowledgedExtensionTest {
AcknowledgedExtension acknowledgedExtension1 = new AcknowledgedProvider().parse(parser);
Assert.assertEquals("message-1", acknowledgedExtension1.getId());
- Message message = (Message) PacketParserUtils.parseStanza(acknowledgedMessageStanza);
+ Message message = PacketParserUtils.parseStanza(acknowledgedMessageStanza);
AcknowledgedExtension acknowledgedExtension2 = AcknowledgedExtension.from(message);
Assert.assertEquals("message-1", acknowledgedExtension2.getId());
}
diff --git a/smack-experimental/src/test/java/org/jivesoftware/smackx/chat_markers/DisplayedExtensionTest.java b/smack-experimental/src/test/java/org/jivesoftware/smackx/chat_markers/DisplayedExtensionTest.java
index fd8161e8b..bba42c13c 100644
--- a/smack-experimental/src/test/java/org/jivesoftware/smackx/chat_markers/DisplayedExtensionTest.java
+++ b/smack-experimental/src/test/java/org/jivesoftware/smackx/chat_markers/DisplayedExtensionTest.java
@@ -49,7 +49,7 @@ public class DisplayedExtensionTest {
DisplayedExtension displayedExtension1 = new DisplayedProvider().parse(parser);
Assert.assertEquals("message-1", displayedExtension1.getId());
- Message message = (Message) PacketParserUtils.parseStanza(displayedMessageStanza);
+ Message message = PacketParserUtils.parseStanza(displayedMessageStanza);
DisplayedExtension displayedExtension2 = DisplayedExtension.from(message);
Assert.assertEquals("message-1", displayedExtension2.getId());
}
diff --git a/smack-experimental/src/test/java/org/jivesoftware/smackx/chat_markers/MarkableExtensionTest.java b/smack-experimental/src/test/java/org/jivesoftware/smackx/chat_markers/MarkableExtensionTest.java
index 3c28d10cb..e62e0cd98 100644
--- a/smack-experimental/src/test/java/org/jivesoftware/smackx/chat_markers/MarkableExtensionTest.java
+++ b/smack-experimental/src/test/java/org/jivesoftware/smackx/chat_markers/MarkableExtensionTest.java
@@ -51,7 +51,7 @@ public class MarkableExtensionTest {
MarkableExtension markableExtension1 = new MarkableProvider().parse(parser);
Assert.assertEquals(markableExtension, markableExtension1.toXML().toString());
- Message message = (Message) PacketParserUtils.parseStanza(markableMessageStanza);
+ Message message = PacketParserUtils.parseStanza(markableMessageStanza);
MarkableExtension markableExtension2 = MarkableExtension.from(message);
Assert.assertEquals(markableExtension, markableExtension2.toXML().toString());
}
diff --git a/smack-experimental/src/test/java/org/jivesoftware/smackx/chat_markers/ReceivedExtensionTest.java b/smack-experimental/src/test/java/org/jivesoftware/smackx/chat_markers/ReceivedExtensionTest.java
index d34dc8088..31d668571 100644
--- a/smack-experimental/src/test/java/org/jivesoftware/smackx/chat_markers/ReceivedExtensionTest.java
+++ b/smack-experimental/src/test/java/org/jivesoftware/smackx/chat_markers/ReceivedExtensionTest.java
@@ -49,7 +49,7 @@ public class ReceivedExtensionTest {
ReceivedExtension receivedExtension1 = new ReceivedProvider().parse(parser);
Assert.assertEquals("message-1", receivedExtension1.getId());
- Message message = (Message) PacketParserUtils.parseStanza(receivedMessageStanza);
+ Message message = PacketParserUtils.parseStanza(receivedMessageStanza);
ReceivedExtension receivedExtension2 = ReceivedExtension.from(message);
Assert.assertEquals("message-1", receivedExtension2.getId());
}
diff --git a/smack-experimental/src/test/java/org/jivesoftware/smackx/hoxt/provider/HttpOverXmppReqProviderTest.java b/smack-experimental/src/test/java/org/jivesoftware/smackx/hoxt/provider/HttpOverXmppReqProviderTest.java
index e1dc35b78..d64427dde 100644
--- a/smack-experimental/src/test/java/org/jivesoftware/smackx/hoxt/provider/HttpOverXmppReqProviderTest.java
+++ b/smack-experimental/src/test/java/org/jivesoftware/smackx/hoxt/provider/HttpOverXmppReqProviderTest.java
@@ -72,7 +72,6 @@ public class HttpOverXmppReqProviderTest {
XmlPullParser parser = PacketParserUtils.getParserFor(string);
IQ iq = provider.parse(parser);
assertTrue(iq instanceof HttpOverXmppReq);
- HttpOverXmppReq castedIq = (HttpOverXmppReq) iq;
- return castedIq;
+ return (HttpOverXmppReq) iq;
}
}
diff --git a/smack-experimental/src/test/java/org/jivesoftware/smackx/httpfileupload/FileTooLargeErrorCreateTest.java b/smack-experimental/src/test/java/org/jivesoftware/smackx/httpfileupload/FileTooLargeErrorCreateTest.java
index 157dc77c4..eb7333b6d 100644
--- a/smack-experimental/src/test/java/org/jivesoftware/smackx/httpfileupload/FileTooLargeErrorCreateTest.java
+++ b/smack-experimental/src/test/java/org/jivesoftware/smackx/httpfileupload/FileTooLargeErrorCreateTest.java
@@ -22,7 +22,7 @@ import org.junit.Assert;
import org.junit.Test;
public class FileTooLargeErrorCreateTest {
- String fileTooLargeErrorExtensionExample
+ private static final String fileTooLargeErrorExtensionExample
= ""
+ "20000"
+ "";
diff --git a/smack-experimental/src/test/java/org/jivesoftware/smackx/httpfileupload/SlotCreateTest.java b/smack-experimental/src/test/java/org/jivesoftware/smackx/httpfileupload/SlotCreateTest.java
index 151c0e015..73b71d93d 100644
--- a/smack-experimental/src/test/java/org/jivesoftware/smackx/httpfileupload/SlotCreateTest.java
+++ b/smack-experimental/src/test/java/org/jivesoftware/smackx/httpfileupload/SlotCreateTest.java
@@ -28,7 +28,7 @@ import org.junit.Test;
import org.xml.sax.SAXException;
public class SlotCreateTest {
- String testSlot
+ private static final String testSlot
= ""
+ ""
+ ""
diff --git a/smack-experimental/src/test/java/org/jivesoftware/smackx/httpfileupload/SlotRequestCreateTest.java b/smack-experimental/src/test/java/org/jivesoftware/smackx/httpfileupload/SlotRequestCreateTest.java
index 525322357..d49ebee73 100644
--- a/smack-experimental/src/test/java/org/jivesoftware/smackx/httpfileupload/SlotRequestCreateTest.java
+++ b/smack-experimental/src/test/java/org/jivesoftware/smackx/httpfileupload/SlotRequestCreateTest.java
@@ -29,14 +29,14 @@ import org.xml.sax.SAXException;
public class SlotRequestCreateTest {
- String testRequest
+ private static final String testRequest
= "";
- String testRequestWithoutContentType
+ private static final String testRequestWithoutContentType
= "XEP-0363: HTTP File Upload 5. Error conditions
*/
- String slotErrorFileToLarge
+ private static final String slotErrorFileToLarge
= "";
// @formatter:on
- IQ iq = (IQ) PacketParserUtils.parseStanza(IQ_LIMITED_RESULTS_EXAMPLE);
+ IQ iq = PacketParserUtils.parseStanza(IQ_LIMITED_RESULTS_EXAMPLE);
MamFinIQ mamFinIQ = (MamFinIQ) iq;
Assert.assertEquals(mamFinIQ.getType(), Type.result);
diff --git a/smack-experimental/src/test/java/org/jivesoftware/smackx/mam/MamPrefIQProviderTest.java b/smack-experimental/src/test/java/org/jivesoftware/smackx/mam/MamPrefIQProviderTest.java
index fe56ca81b..0e89b9b69 100644
--- a/smack-experimental/src/test/java/org/jivesoftware/smackx/mam/MamPrefIQProviderTest.java
+++ b/smack-experimental/src/test/java/org/jivesoftware/smackx/mam/MamPrefIQProviderTest.java
@@ -31,18 +31,18 @@ import org.xmlpull.v1.XmlPullParser;
public class MamPrefIQProviderTest extends MamTest {
- String exampleMamPrefsIQ1 = "" + ""
+ private static final String exampleMamPrefsIQ1 = "" + ""
+ "" + "romeo@montague.lit" + "" + ""
+ "montague@montague.lit" + "" + "" + "";
- String exampleMamPrefsIQ2 = "" + ""
+ private static final String exampleMamPrefsIQ2 = "" + ""
+ "" + "romeo@montague.lit" + "montague@montague.lit" + ""
+ "" + "" + "" + "";
- String exampleMamPrefsIQ3 = "" + "" + ""
+ private static final String exampleMamPrefsIQ3 = "" + "" + ""
+ "";
- String exampleMamPrefsResultIQ = ""
+ private static final String exampleMamPrefsResultIQ = ""
+ "" + "" + "romeo@montague.lit"
+ "" + "" + "sarasa@montague.lit" + "montague@montague.lit"
+ "" + "" + "";
@@ -53,14 +53,14 @@ public class MamPrefIQProviderTest extends MamTest {
MamPrefsIQ mamPrefIQ1 = new MamPrefsIQProvider().parse(parser1);
Assert.assertEquals(IQ.Type.set, mamPrefIQ1.getType());
- Assert.assertEquals(mamPrefIQ1.getAlwaysJids().get(0), "romeo@montague.lit");
- Assert.assertEquals(mamPrefIQ1.getNeverJids().get(0), "montague@montague.lit");
+ Assert.assertEquals(mamPrefIQ1.getAlwaysJids().get(0).toString(), "romeo@montague.lit");
+ Assert.assertEquals(mamPrefIQ1.getNeverJids().get(0).toString(), "montague@montague.lit");
XmlPullParser parser2 = PacketParserUtils.getParserFor(exampleMamPrefsIQ2);
MamPrefsIQ mamPrefIQ2 = new MamPrefsIQProvider().parse(parser2);
Assert.assertEquals(IQ.Type.set, mamPrefIQ2.getType());
- Assert.assertEquals(mamPrefIQ2.getAlwaysJids().get(0), "romeo@montague.lit");
- Assert.assertEquals(mamPrefIQ2.getAlwaysJids().get(1), "montague@montague.lit");
+ Assert.assertEquals(mamPrefIQ2.getAlwaysJids().get(0).toString(), "romeo@montague.lit");
+ Assert.assertEquals(mamPrefIQ2.getAlwaysJids().get(1).toString(), "montague@montague.lit");
Assert.assertTrue(mamPrefIQ2.getNeverJids().isEmpty());
XmlPullParser parser3 = PacketParserUtils.getParserFor(exampleMamPrefsIQ3);
@@ -70,7 +70,7 @@ public class MamPrefIQProviderTest extends MamTest {
@Test
public void checkMamPrefResult() throws Exception {
- IQ iq = (IQ) PacketParserUtils.parseStanza(exampleMamPrefsResultIQ);
+ IQ iq = PacketParserUtils.parseStanza(exampleMamPrefsResultIQ);
MamPrefsIQ mamPrefsIQ = (MamPrefsIQ) iq;
diff --git a/smack-experimental/src/test/java/org/jivesoftware/smackx/mam/MamQueryIQProviderTest.java b/smack-experimental/src/test/java/org/jivesoftware/smackx/mam/MamQueryIQProviderTest.java
index b9236ad08..2c62f988b 100644
--- a/smack-experimental/src/test/java/org/jivesoftware/smackx/mam/MamQueryIQProviderTest.java
+++ b/smack-experimental/src/test/java/org/jivesoftware/smackx/mam/MamQueryIQProviderTest.java
@@ -32,7 +32,7 @@ import org.junit.Test;
public class MamQueryIQProviderTest {
- String exampleMamQueryIQ1 = "" + ""
+ private static final String exampleMamQueryIQ1 = "" + ""
+ "" + ""
+ "urn:xmpp:mam:1" + ""
+ ""
@@ -41,7 +41,7 @@ public class MamQueryIQProviderTest {
+ "{http://jabber.org/protocol/mood}mood/lonely" + "" + "" + ""
+ "";
- String exampleMamQueryIQ2 = "" + ""
+ private static final String exampleMamQueryIQ2 = "" + ""
+ "" + ""
+ "urn:xmpp:mam:1" + "" + ""
+ "" + ""
@@ -51,7 +51,7 @@ public class MamQueryIQProviderTest {
@Test
public void checkMamQueryIQProvider() throws Exception {
// example 1
- IQ iq1 = (IQ) PacketParserUtils.parseStanza(exampleMamQueryIQ1);
+ IQ iq1 = PacketParserUtils.parseStanza(exampleMamQueryIQ1);
MamQueryIQ mamQueryIQ1 = (MamQueryIQ) iq1;
Assert.assertEquals(mamQueryIQ1.getType(), Type.set);
@@ -67,7 +67,7 @@ public class MamQueryIQProviderTest {
Assert.assertEquals(fields1.get(2).getValues().get(0), "{http://jabber.org/protocol/mood}mood/lonely");
// example2
- IQ iq2 = (IQ) PacketParserUtils.parseStanza(exampleMamQueryIQ2);
+ IQ iq2 = PacketParserUtils.parseStanza(exampleMamQueryIQ2);
MamQueryIQ mamQueryIQ2 = (MamQueryIQ) iq2;
Assert.assertEquals(mamQueryIQ2.getType(), Type.result);
diff --git a/smack-experimental/src/test/java/org/jivesoftware/smackx/mam/MamResultProviderTest.java b/smack-experimental/src/test/java/org/jivesoftware/smackx/mam/MamResultProviderTest.java
index 89535a1a5..4d0c0c145 100644
--- a/smack-experimental/src/test/java/org/jivesoftware/smackx/mam/MamResultProviderTest.java
+++ b/smack-experimental/src/test/java/org/jivesoftware/smackx/mam/MamResultProviderTest.java
@@ -33,14 +33,14 @@ import org.xmlpull.v1.XmlPullParser;
public class MamResultProviderTest {
- String exampleMamResultXml = ""
+ private static final String exampleMamResultXml = ""
+ "" + ""
+ ""
+ "Call me but love, and I'll be new baptized; Henceforth I never will be Romeo."
+ "" + "" + "";
- String exampleResultMessage = ""
+ private static final String exampleResultMessage = ""
+ ""
+ "" + ""
+ ""
@@ -62,15 +62,15 @@ public class MamResultProviderTest {
Assert.assertEquals(forwarded.getDelayInformation().getStamp(), date);
Message message = (Message) forwarded.getForwardedStanza();
- Assert.assertEquals(message.getFrom(), "romeo@montague.lit/orchard");
- Assert.assertEquals(message.getTo(), "juliet@capulet.lit/balcony");
+ Assert.assertEquals(message.getFrom().toString(), "romeo@montague.lit/orchard");
+ Assert.assertEquals(message.getTo().toString(), "juliet@capulet.lit/balcony");
Assert.assertEquals(message.getBody(),
"Call me but love, and I'll be new baptized; Henceforth I never will be Romeo.");
}
@Test
public void checkResultsParse() throws Exception {
- Message message = (Message) PacketParserUtils.parseStanza(exampleResultMessage);
+ Message message = PacketParserUtils.parseStanza(exampleResultMessage);
MamResultExtension mamResultExtension = MamResultExtension.from(message);
Assert.assertEquals(mamResultExtension.getQueryId(), "f27");
@@ -84,8 +84,8 @@ public class MamResultProviderTest {
Assert.assertEquals(forwarded.getDelayInformation().getStamp(), date);
Message forwardedMessage = (Message) forwarded.getForwardedStanza();
- Assert.assertEquals(forwardedMessage.getFrom(), "witch@shakespeare.lit");
- Assert.assertEquals(forwardedMessage.getTo(), "macbeth@shakespeare.lit");
+ Assert.assertEquals(forwardedMessage.getFrom().toString(), "witch@shakespeare.lit");
+ Assert.assertEquals(forwardedMessage.getTo().toString(), "macbeth@shakespeare.lit");
Assert.assertEquals(forwardedMessage.getBody(), "Hail to thee");
}
diff --git a/smack-experimental/src/test/java/org/jivesoftware/smackx/mam/PreferencesTest.java b/smack-experimental/src/test/java/org/jivesoftware/smackx/mam/PreferencesTest.java
index 52fe85822..fc5b9951c 100644
--- a/smack-experimental/src/test/java/org/jivesoftware/smackx/mam/PreferencesTest.java
+++ b/smack-experimental/src/test/java/org/jivesoftware/smackx/mam/PreferencesTest.java
@@ -30,10 +30,10 @@ import org.jxmpp.jid.impl.JidCreate;
public class PreferencesTest {
- String retrievePrefsStanzaExample = "" + "" + "" + "";
- String updatePrefsStanzaExample = "" + "" + "" + "" + "romeo@montague.lit" + "other@montague.lit"
+ "" + "" + "montague@montague.lit" + "" + "" + "";
diff --git a/smack-experimental/src/test/java/org/jivesoftware/smackx/mam/QueryArchiveTest.java b/smack-experimental/src/test/java/org/jivesoftware/smackx/mam/QueryArchiveTest.java
index 2603b7d63..af5d87a61 100644
--- a/smack-experimental/src/test/java/org/jivesoftware/smackx/mam/QueryArchiveTest.java
+++ b/smack-experimental/src/test/java/org/jivesoftware/smackx/mam/QueryArchiveTest.java
@@ -37,11 +37,11 @@ import org.jxmpp.jid.impl.JidCreate;
public class QueryArchiveTest extends MamTest {
- String mamSimpleQueryIQ = "" + ""
+ private static final String mamSimpleQueryIQ = "" + ""
+ "" + "" + ""
+ MamElements.NAMESPACE + "" + "" + "" + "" + "";
- String mamQueryResultExample = ""
+ private static final String mamQueryResultExample = ""
+ ""
+ ""
+ "" + ""
+ private static final String resultsLimitStanza = "" + ""
+ "" + "" + ""
+ MamElements.NAMESPACE + "" + "" + "" + ""
+ "10" + "" + "" + "";
diff --git a/smack-experimental/src/test/java/org/jivesoftware/smackx/muclight/MUCLightAffiliationsChangeExtensionTest.java b/smack-experimental/src/test/java/org/jivesoftware/smackx/muclight/MUCLightAffiliationsChangeExtensionTest.java
index ef67ddf77..bc7c74059 100644
--- a/smack-experimental/src/test/java/org/jivesoftware/smackx/muclight/MUCLightAffiliationsChangeExtensionTest.java
+++ b/smack-experimental/src/test/java/org/jivesoftware/smackx/muclight/MUCLightAffiliationsChangeExtensionTest.java
@@ -30,19 +30,19 @@ import org.jxmpp.jid.impl.JidCreate;
public class MUCLightAffiliationsChangeExtensionTest {
- String exampleMessageStanza = ""
+ private static final String exampleMessageStanza = ""
+ ""
+ "sarasa2@shakespeare.lit"
+ "sarasa1@shakespeare.lit"
+ "sarasa3@shakespeare.lit" + "" + "";
- String exampleMessageStanzaWithVersion = ""
+ "" + "qwerty"
+ "sarasa1@shakespeare.lit"
+ "sarasa3@shakespeare.lit" + "" + "" + "";
- String exampleMessageStanzaWithPrevVersion = ""
+ "" + "njiokm"
+ "qwerty" + "sarasa2@shakespeare.lit"
@@ -50,7 +50,7 @@ public class MUCLightAffiliationsChangeExtensionTest {
@Test
public void checkAffiliationsChangeExtension() throws Exception {
- Message changeAffiliationsMessage = (Message) PacketParserUtils.parseStanza(exampleMessageStanza);
+ Message changeAffiliationsMessage = PacketParserUtils.parseStanza(exampleMessageStanza);
AffiliationsChangeExtension affiliationsChangeExtension = AffiliationsChangeExtension
.from(changeAffiliationsMessage);
@@ -63,7 +63,7 @@ public class MUCLightAffiliationsChangeExtensionTest {
@Test
public void checkAffiliationsChangeExtensionWithVersion() throws Exception {
- Message changeAffiliationsMessage = (Message) PacketParserUtils.parseStanza(exampleMessageStanzaWithVersion);
+ Message changeAffiliationsMessage = PacketParserUtils.parseStanza(exampleMessageStanzaWithVersion);
AffiliationsChangeExtension affiliationsChangeExtension = AffiliationsChangeExtension
.from(changeAffiliationsMessage);
@@ -77,7 +77,7 @@ public class MUCLightAffiliationsChangeExtensionTest {
@Test
public void checkAffiliationsChangeExtensionWithPrevVersion() throws Exception {
- Message changeAffiliationsMessage = (Message) PacketParserUtils
+ Message changeAffiliationsMessage = PacketParserUtils
.parseStanza(exampleMessageStanzaWithPrevVersion);
AffiliationsChangeExtension affiliationsChangeExtension = AffiliationsChangeExtension
.from(changeAffiliationsMessage);
diff --git a/smack-experimental/src/test/java/org/jivesoftware/smackx/muclight/MUCLightBlockingTest.java b/smack-experimental/src/test/java/org/jivesoftware/smackx/muclight/MUCLightBlockingTest.java
index a92bb86de..db34f9548 100644
--- a/smack-experimental/src/test/java/org/jivesoftware/smackx/muclight/MUCLightBlockingTest.java
+++ b/smack-experimental/src/test/java/org/jivesoftware/smackx/muclight/MUCLightBlockingTest.java
@@ -31,25 +31,25 @@ import org.jxmpp.jid.impl.JidCreate;
public class MUCLightBlockingTest {
- String getBlockingListIQExample = ""
+ private static final String getBlockingListIQExample = ""
+ "" + "" + "";
- String getBlockingListIQResponse = ""
+ private static final String getBlockingListIQResponse = ""
+ ""
+ "coven@muclight.shakespeare.lit"
+ "sarasa@muclight.shakespeare.lit"
+ "hag77@shakespeare.lit" + "" + "";
- String blockingRoomsIQExample = ""
+ private static final String blockingRoomsIQExample = ""
+ ""
+ "coven@muclight.shakespeare.lit"
+ "chapel@shakespeare.lit" + "" + "";
- String blockingUsersIQExample = ""
+ private static final String blockingUsersIQExample = ""
+ "" + "hag77@shakespeare.lit"
+ "hag66@shakespeare.lit" + "" + "";
- String unblockingUsersAndRoomsExample = ""
+ private static final String unblockingUsersAndRoomsExample = ""
+ ""
+ "coven@muclight.shakespeare.lit"
+ "hag66@shakespeare.lit" + "" + "";
@@ -66,7 +66,7 @@ public class MUCLightBlockingTest {
@Test
public void checkGetBlockingListResponse() throws Exception {
- IQ iqInfoResult = (IQ) PacketParserUtils.parseStanza(getBlockingListIQResponse);
+ IQ iqInfoResult = PacketParserUtils.parseStanza(getBlockingListIQResponse);
MUCLightBlockingIQ mucLightBlockingIQ = (MUCLightBlockingIQ) iqInfoResult;
Assert.assertEquals(2, mucLightBlockingIQ.getRooms().size());
diff --git a/smack-experimental/src/test/java/org/jivesoftware/smackx/muclight/MUCLightChangeAffiliationsIQTest.java b/smack-experimental/src/test/java/org/jivesoftware/smackx/muclight/MUCLightChangeAffiliationsIQTest.java
index 7180bf873..44a9e067d 100644
--- a/smack-experimental/src/test/java/org/jivesoftware/smackx/muclight/MUCLightChangeAffiliationsIQTest.java
+++ b/smack-experimental/src/test/java/org/jivesoftware/smackx/muclight/MUCLightChangeAffiliationsIQTest.java
@@ -29,7 +29,7 @@ import org.jxmpp.jid.impl.JidCreate;
public class MUCLightChangeAffiliationsIQTest {
- String stanza = ""
+ private static final String stanza = ""
+ ""
+ "sarasa2@shakespeare.lit"
+ "sarasa1@shakespeare.lit"
diff --git a/smack-experimental/src/test/java/org/jivesoftware/smackx/muclight/MUCLightConfigurationsChangeExtensionTest.java b/smack-experimental/src/test/java/org/jivesoftware/smackx/muclight/MUCLightConfigurationsChangeExtensionTest.java
index e4002c221..0b95af0d3 100644
--- a/smack-experimental/src/test/java/org/jivesoftware/smackx/muclight/MUCLightConfigurationsChangeExtensionTest.java
+++ b/smack-experimental/src/test/java/org/jivesoftware/smackx/muclight/MUCLightConfigurationsChangeExtensionTest.java
@@ -26,23 +26,23 @@ import org.junit.Test;
public class MUCLightConfigurationsChangeExtensionTest {
- String messageWithSubjectChangeExample = ""
+ private static final String messageWithSubjectChangeExample = ""
+ "" + ""
+ "asdfghj000" + "asdfghj"
+ "To be or not to be?" + "" + "";
- String messageWithRoomNameChangeExample = ""
+ private static final String messageWithRoomNameChangeExample = ""
+ "" + "" + "zaqwsx"
+ "zxcvbnm" + "A Darker Cave" + "" + "";
- String messageWithConfigsChangeExample = ""
+ private static final String messageWithConfigsChangeExample = ""
+ "" + "" + "zaqwsx"
+ "zxcvbnm" + "A Darker Cave" + "blue" + ""
+ "";
@Test
public void checkSubjectChangeExtension() throws Exception {
- Message configurationsMessage = (Message) PacketParserUtils.parseStanza(messageWithSubjectChangeExample);
+ Message configurationsMessage = PacketParserUtils.parseStanza(messageWithSubjectChangeExample);
ConfigurationsChangeExtension configurationsChangeExtension = ConfigurationsChangeExtension
.from(configurationsMessage);
@@ -56,7 +56,7 @@ public class MUCLightConfigurationsChangeExtensionTest {
@Test
public void checkRoomNameChangeExtension() throws Exception {
- Message configurationsMessage = (Message) PacketParserUtils.parseStanza(messageWithRoomNameChangeExample);
+ Message configurationsMessage = PacketParserUtils.parseStanza(messageWithRoomNameChangeExample);
ConfigurationsChangeExtension configurationsChangeExtension = ConfigurationsChangeExtension
.from(configurationsMessage);
@@ -70,7 +70,7 @@ public class MUCLightConfigurationsChangeExtensionTest {
@Test
public void checkConfigsChangeExtension() throws Exception {
- Message configurationsMessage = (Message) PacketParserUtils.parseStanza(messageWithConfigsChangeExample);
+ Message configurationsMessage = PacketParserUtils.parseStanza(messageWithConfigsChangeExample);
ConfigurationsChangeExtension configurationsChangeExtension = ConfigurationsChangeExtension
.from(configurationsMessage);
diff --git a/smack-experimental/src/test/java/org/jivesoftware/smackx/muclight/MUCLightCreateIQTest.java b/smack-experimental/src/test/java/org/jivesoftware/smackx/muclight/MUCLightCreateIQTest.java
index 4a5ba7067..036d3ad7c 100644
--- a/smack-experimental/src/test/java/org/jivesoftware/smackx/muclight/MUCLightCreateIQTest.java
+++ b/smack-experimental/src/test/java/org/jivesoftware/smackx/muclight/MUCLightCreateIQTest.java
@@ -29,7 +29,7 @@ import org.jxmpp.jid.impl.JidCreate;
public class MUCLightCreateIQTest {
- String stanza = ""
+ private static final String stanza = ""
+ "" + "" + "test"
+ "" + "" + "charlie@test.com"
+ "pep@test.com" + "" + "" + "";
diff --git a/smack-experimental/src/test/java/org/jivesoftware/smackx/muclight/MUCLightDestroyTest.java b/smack-experimental/src/test/java/org/jivesoftware/smackx/muclight/MUCLightDestroyTest.java
index cafc9264b..b00c5a0d4 100644
--- a/smack-experimental/src/test/java/org/jivesoftware/smackx/muclight/MUCLightDestroyTest.java
+++ b/smack-experimental/src/test/java/org/jivesoftware/smackx/muclight/MUCLightDestroyTest.java
@@ -24,7 +24,7 @@ import org.jxmpp.jid.impl.JidCreate;
public class MUCLightDestroyTest {
- String stanza = ""
+ private static final String stanza = ""
+ "" + "";
@Test
diff --git a/smack-experimental/src/test/java/org/jivesoftware/smackx/muclight/MUCLightGetAffiliationsTest.java b/smack-experimental/src/test/java/org/jivesoftware/smackx/muclight/MUCLightGetAffiliationsTest.java
index 95d9fc19b..679772ea3 100644
--- a/smack-experimental/src/test/java/org/jivesoftware/smackx/muclight/MUCLightGetAffiliationsTest.java
+++ b/smack-experimental/src/test/java/org/jivesoftware/smackx/muclight/MUCLightGetAffiliationsTest.java
@@ -31,10 +31,10 @@ import org.jxmpp.jid.impl.JidCreate;
public class MUCLightGetAffiliationsTest {
- String getAffiliationsIQExample = ""
+ private static final String getAffiliationsIQExample = ""
+ "" + "abcdefg" + "" + "";
- String getAffiliationsResponseExample = ""
+ private static final String getAffiliationsResponseExample = ""
+ "" + "123456"
+ "user1@shakespeare.lit"
+ "user2@shakespeare.lit"
@@ -50,7 +50,7 @@ public class MUCLightGetAffiliationsTest {
@Test
public void checkGetAffiliationsResponse() throws Exception {
- IQ iqInfoResult = (IQ) PacketParserUtils.parseStanza(getAffiliationsResponseExample);
+ IQ iqInfoResult = PacketParserUtils.parseStanza(getAffiliationsResponseExample);
MUCLightAffiliationsIQ mucLightAffiliationsIQ = (MUCLightAffiliationsIQ) iqInfoResult;
Assert.assertEquals("123456", mucLightAffiliationsIQ.getVersion());
diff --git a/smack-experimental/src/test/java/org/jivesoftware/smackx/muclight/MUCLightGetConfigsTest.java b/smack-experimental/src/test/java/org/jivesoftware/smackx/muclight/MUCLightGetConfigsTest.java
index 1d92832b7..5b97c21c1 100644
--- a/smack-experimental/src/test/java/org/jivesoftware/smackx/muclight/MUCLightGetConfigsTest.java
+++ b/smack-experimental/src/test/java/org/jivesoftware/smackx/muclight/MUCLightGetConfigsTest.java
@@ -30,15 +30,15 @@ import org.jxmpp.jid.impl.JidCreate;
public class MUCLightGetConfigsTest {
- String getConfigsIQExample = ""
+ private static final String getConfigsIQExample = ""
+ "" + "abcdefg" + "" + "";
- String getConfigsResponseExample = "" + ""
+ "123456" + "A Dark Cave" + "A subject"
+ "" + "";
- String getConfigsResponseExampleWithCustomConfigs = "" + ""
+ "123456" + "A Dark Cave" + "blue"
+ "20" + "" + "";
@@ -53,7 +53,7 @@ public class MUCLightGetConfigsTest {
@Test
public void checkGetConfigsResponse() throws Exception {
- IQ iqInfoResult = (IQ) PacketParserUtils.parseStanza(getConfigsResponseExample);
+ IQ iqInfoResult = PacketParserUtils.parseStanza(getConfigsResponseExample);
MUCLightConfigurationIQ mucLightConfigurationIQ = (MUCLightConfigurationIQ) iqInfoResult;
Assert.assertEquals("123456", mucLightConfigurationIQ.getVersion());
@@ -64,7 +64,7 @@ public class MUCLightGetConfigsTest {
@Test
public void checkGetConfigsResponseWithCustomConfigs() throws Exception {
- IQ iqInfoResult = (IQ) PacketParserUtils.parseStanza(getConfigsResponseExampleWithCustomConfigs);
+ IQ iqInfoResult = PacketParserUtils.parseStanza(getConfigsResponseExampleWithCustomConfigs);
MUCLightConfigurationIQ mucLightConfigurationIQ = (MUCLightConfigurationIQ) iqInfoResult;
Assert.assertEquals("123456", mucLightConfigurationIQ.getVersion());
diff --git a/smack-experimental/src/test/java/org/jivesoftware/smackx/muclight/MUCLightInfoTest.java b/smack-experimental/src/test/java/org/jivesoftware/smackx/muclight/MUCLightInfoTest.java
index 64e798ab9..f29d1e11b 100644
--- a/smack-experimental/src/test/java/org/jivesoftware/smackx/muclight/MUCLightInfoTest.java
+++ b/smack-experimental/src/test/java/org/jivesoftware/smackx/muclight/MUCLightInfoTest.java
@@ -28,13 +28,13 @@ import org.jxmpp.jid.impl.JidCreate;
public class MUCLightInfoTest {
- String exampleWithVersion = ""
+ private static final String exampleWithVersion = ""
+ "" + "abcdefg" + "" + "";
- String exampleWithoutVersion = ""
+ private static final String exampleWithoutVersion = ""
+ "" + "" + "";
- String exampleInfoResult = ""
+ private static final String exampleInfoResult = ""
+ "" + "123456" + ""
+ "test" + "" + ""
+ "john@test.com" + "charlie@test.com"
@@ -58,7 +58,7 @@ public class MUCLightInfoTest {
@Test
public void checkMUCLightInfoResult() throws Exception {
- IQ iqInfoResult = (IQ) PacketParserUtils.parseStanza(exampleInfoResult);
+ IQ iqInfoResult = PacketParserUtils.parseStanza(exampleInfoResult);
MUCLightInfoIQ mucLightInfoResponseIQ = (MUCLightInfoIQ) iqInfoResult;
Assert.assertEquals(mucLightInfoResponseIQ.getVersion(), "123456");
Assert.assertEquals(mucLightInfoResponseIQ.getConfiguration().getRoomName(), "test");
diff --git a/smack-experimental/src/test/java/org/jivesoftware/smackx/muclight/MUCLightSetConfigsIQTest.java b/smack-experimental/src/test/java/org/jivesoftware/smackx/muclight/MUCLightSetConfigsIQTest.java
index 17ea91522..69a66c755 100644
--- a/smack-experimental/src/test/java/org/jivesoftware/smackx/muclight/MUCLightSetConfigsIQTest.java
+++ b/smack-experimental/src/test/java/org/jivesoftware/smackx/muclight/MUCLightSetConfigsIQTest.java
@@ -26,15 +26,15 @@ import org.jxmpp.jid.impl.JidCreate;
public class MUCLightSetConfigsIQTest {
- String setConfigsIQExample = ""
+ private static final String setConfigsIQExample = ""
+ "" + "A Darker Cave"
+ "blue" + "" + "";
- String changeRoomNameIQExample = ""
+ private static final String changeRoomNameIQExample = ""
+ "" + "A Darker Cave" + ""
+ "";
- String changeSubjectIQExample = ""
+ private static final String changeSubjectIQExample = ""
+ "" + "To be or not to be?"
+ "" + "";
diff --git a/smack-experimental/src/test/java/org/jivesoftware/smackx/push_notifications/DisablePushNotificationsIQTest.java b/smack-experimental/src/test/java/org/jivesoftware/smackx/push_notifications/DisablePushNotificationsIQTest.java
index 0a607c806..76bd1de25 100644
--- a/smack-experimental/src/test/java/org/jivesoftware/smackx/push_notifications/DisablePushNotificationsIQTest.java
+++ b/smack-experimental/src/test/java/org/jivesoftware/smackx/push_notifications/DisablePushNotificationsIQTest.java
@@ -24,10 +24,10 @@ import org.jxmpp.jid.impl.JidCreate;
public class DisablePushNotificationsIQTest {
- String disableAllNotificationsIQExample = ""
+ private static final String disableAllNotificationsIQExample = ""
+ "" + "" + "";
- String disableNodeNotificationsIQExample = ""
+ private static final String disableNodeNotificationsIQExample = ""
+ "" + ""
+ "";
diff --git a/smack-experimental/src/test/java/org/jivesoftware/smackx/push_notifications/EnablePushNotificationsIQTest.java b/smack-experimental/src/test/java/org/jivesoftware/smackx/push_notifications/EnablePushNotificationsIQTest.java
index c418d7cea..3b21ffe79 100644
--- a/smack-experimental/src/test/java/org/jivesoftware/smackx/push_notifications/EnablePushNotificationsIQTest.java
+++ b/smack-experimental/src/test/java/org/jivesoftware/smackx/push_notifications/EnablePushNotificationsIQTest.java
@@ -26,11 +26,11 @@ import org.jxmpp.jid.impl.JidCreate;
public class EnablePushNotificationsIQTest {
- String exampleEnableIQ = ""
+ private static final String exampleEnableIQ = ""
+ "" + ""
+ "";
- String exampleEnableIQWithPublishOptions = ""
+ private static final String exampleEnableIQWithPublishOptions = ""
+ ""
+ ""
+ "http://jabber.org/protocol/pubsub#publish-options"
diff --git a/smack-experimental/src/test/java/org/jivesoftware/smackx/push_notifications/RemoteDisablingPushNotificationsTest.java b/smack-experimental/src/test/java/org/jivesoftware/smackx/push_notifications/RemoteDisablingPushNotificationsTest.java
index 75f9cc177..96d3ee64d 100644
--- a/smack-experimental/src/test/java/org/jivesoftware/smackx/push_notifications/RemoteDisablingPushNotificationsTest.java
+++ b/smack-experimental/src/test/java/org/jivesoftware/smackx/push_notifications/RemoteDisablingPushNotificationsTest.java
@@ -27,24 +27,24 @@ import org.jxmpp.jid.impl.JidCreate;
public class RemoteDisablingPushNotificationsTest {
- String remoteDisablingExample = ""
+ private static final String remoteDisablingExample = ""
+ ""
+ "" + "" + "";
- String wrongRemoteDisabling1 = ""
+ private static final String wrongRemoteDisabling1 = ""
+ ""
+ "" + "" + "";
- String wrongRemoteDisabling2 = ""
+ private static final String wrongRemoteDisabling2 = ""
+ ""
+ "" + "" + "";
- String wrongRemoteDisabling3 = ""
+ private static final String wrongRemoteDisabling3 = ""
+ "" + "" + "";
@Test
public void checkRemoteDisablingPushNotificationsParse() throws Exception {
- Message message = (Message) PacketParserUtils.parseStanza(remoteDisablingExample);
+ Message message = PacketParserUtils.parseStanza(remoteDisablingExample);
RemoteDisablingExtension remoteDisablingExtension = RemoteDisablingExtension.from(message);
Assert.assertEquals("yxs32uqsflafdk3iuqo", remoteDisablingExtension.getNode());
@@ -53,15 +53,15 @@ public class RemoteDisablingPushNotificationsTest {
@Test
public void checkWrongRemoteDisablighPushNotifications() throws Exception {
- Message message1 = (Message) PacketParserUtils.parseStanza(wrongRemoteDisabling1);
+ Message message1 = PacketParserUtils.parseStanza(wrongRemoteDisabling1);
RemoteDisablingExtension remoteDisablingExtension1 = RemoteDisablingExtension.from(message1);
Assert.assertNull(remoteDisablingExtension1);
- Message message2 = (Message) PacketParserUtils.parseStanza(wrongRemoteDisabling1);
+ Message message2 = PacketParserUtils.parseStanza(wrongRemoteDisabling1);
RemoteDisablingExtension remoteDisablingExtension2 = RemoteDisablingExtension.from(message2);
Assert.assertNull(remoteDisablingExtension2);
- Message message3 = (Message) PacketParserUtils.parseStanza(wrongRemoteDisabling1);
+ Message message3 = PacketParserUtils.parseStanza(wrongRemoteDisabling1);
RemoteDisablingExtension remoteDisablingExtension3 = RemoteDisablingExtension.from(message3);
Assert.assertNull(remoteDisablingExtension3);
}
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/address/MultipleRecipientManager.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/address/MultipleRecipientManager.java
index 9dd6e0189..b91e10731 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/address/MultipleRecipientManager.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/address/MultipleRecipientManager.java
@@ -112,7 +112,7 @@ public class MultipleRecipientManager {
connection.sendStanza(packet);
return;
}
- DomainBareJid serviceAddress = getMultipleRecipienServiceAddress(connection);
+ DomainBareJid serviceAddress = getMultipleRecipientServiceAddress(connection);
if (serviceAddress != null) {
// Send packet to target users using multiple recipient service provided by the server
sendThroughService(connection, packet, to, cc, bcc, replyTo, replyRoom, noReply,
@@ -133,8 +133,8 @@ public class MultipleRecipientManager {
/**
* Sends a reply to a previously received stanza(/packet) that was sent to multiple recipients. Before
- * attempting to send the reply message some checkings are performed. If any of those checkings
- * fail then an XMPPException is going to be thrown with the specific error detail.
+ * attempting to send the reply message some checks are performed. If any of those checks
+ * fails, then an XMPPException is going to be thrown with the specific error detail.
*
* @param connection the connection to use to send the reply.
* @param original the previously received stanza(/packet) that was sent to multiple recipients.
@@ -201,8 +201,7 @@ public class MultipleRecipientManager {
* if none was found.
*/
public static MultipleRecipientInfo getMultipleRecipientInfo(Stanza packet) {
- MultipleAddresses extension = (MultipleAddresses) packet
- .getExtension(MultipleAddresses.ELEMENT, MultipleAddresses.NAMESPACE);
+ MultipleAddresses extension = packet.getExtension(MultipleAddresses.ELEMENT, MultipleAddresses.NAMESPACE);
return extension == null ? null : new MultipleRecipientInfo(extension);
}
@@ -283,7 +282,7 @@ public class MultipleRecipientManager {
* @throws NotConnectedException
* @throws InterruptedException
*/
- private static DomainBareJid getMultipleRecipienServiceAddress(XMPPConnection connection) throws NoResponseException, XMPPErrorException, NotConnectedException, InterruptedException {
+ private static DomainBareJid getMultipleRecipientServiceAddress(XMPPConnection connection) throws NoResponseException, XMPPErrorException, NotConnectedException, InterruptedException {
ServiceDiscoveryManager sdm = ServiceDiscoveryManager.getInstanceFor(connection);
return sdm.findService(MultipleAddresses.NAMESPACE, true);
}
@@ -296,7 +295,7 @@ public class MultipleRecipientManager {
*/
private static class PacketCopy extends Stanza {
- private CharSequence text;
+ private final CharSequence text;
/**
* Create a copy of a stanza(/packet) with the text to send. The passed text must be a valid text to
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/address/packet/MultipleAddresses.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/address/packet/MultipleAddresses.java
index 373daba9e..ab1f5c6de 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/address/packet/MultipleAddresses.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/address/packet/MultipleAddresses.java
@@ -53,7 +53,7 @@ public class MultipleAddresses implements ExtensionElement {
ofrom,
}
- private List addresses = new ArrayList();
+ private final List addresses = new ArrayList<>();
/**
* Adds a new address to which the stanza(/packet) is going to be sent or was sent.
@@ -68,7 +68,7 @@ public class MultipleAddresses implements ExtensionElement {
*/
public void addAddress(Type type, Jid jid, String node, String desc, boolean delivered,
String uri) {
- // Create a new address with the specificed configuration
+ // Create a new address with the specified configuration
Address address = new Address(type);
address.setJid(jid);
address.setNode(node);
@@ -83,7 +83,7 @@ public class MultipleAddresses implements ExtensionElement {
* Indicate that the stanza(/packet) being sent should not be replied.
*/
public void setNoReply() {
- // Create a new address with the specificed configuration
+ // Create a new address with the specified configuration
Address address = new Address(Type.noreply);
// Add the new address to the list of multiple recipients
addresses.add(address);
@@ -97,7 +97,7 @@ public class MultipleAddresses implements ExtensionElement {
* @return the list of addresses that matches the specified type.
*/
public List getAddressesOfType(Type type) {
- List answer = new ArrayList(addresses.size());
+ List answer = new ArrayList<>(addresses.size());
for (Address address : addresses) {
if (address.getType().equals(type)) {
answer.add(address);
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/amp/AMPDeliverCondition.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/amp/AMPDeliverCondition.java
index 84d15860c..46acf6a1f 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/amp/AMPDeliverCondition.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/amp/AMPDeliverCondition.java
@@ -43,7 +43,7 @@ public class AMPDeliverCondition implements AMPExtension.Condition {
private final Value value;
/**
- * Create new amp deliver condition with value setted to one of defined by XEP-0079.
+ * Create new amp deliver condition with value set to one of defined by XEP-0079.
* See http://xmpp.org/extensions/xep-0079.html#conditions-def-deliver
* @param value AMPDeliveryCondition.Value instance that will be used as value parameter. Can't be null.
*/
@@ -67,7 +67,7 @@ public class AMPDeliverCondition implements AMPExtension.Condition {
* Value for amp deliver condition as defined by XEP-0079.
* See http://xmpp.org/extensions/xep-0079.html#conditions-def-deliver
*/
- public static enum Value {
+ public enum Value {
/**
* The message would be immediately delivered to the intended recipient or routed to the next hop.
*/
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/amp/AMPExpireAtCondition.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/amp/AMPExpireAtCondition.java
index 8779c2820..53fc409a3 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/amp/AMPExpireAtCondition.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/amp/AMPExpireAtCondition.java
@@ -48,7 +48,7 @@ public class AMPExpireAtCondition implements AMPExtension.Condition {
private final String value;
/**
- * Create new expire-at amp condition with value setted as XEP-0082 formatted date.
+ * Create new expire-at amp condition with value set as XEP-0082 formatted date.
* @param utcDateTime Date instance of time
* that will be used as value parameter after formatting to XEP-0082 format. Can't be null.
*/
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/amp/AMPMatchResourceCondition.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/amp/AMPMatchResourceCondition.java
index 0445359f3..2bae2ad87 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/amp/AMPMatchResourceCondition.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/amp/AMPMatchResourceCondition.java
@@ -43,7 +43,7 @@ public class AMPMatchResourceCondition implements AMPExtension.Condition {
private final Value value;
/**
- * Create new amp match-resource condition with value setted to one of defined by XEP-0079.
+ * Create new amp match-resource condition with value set to one of defined by XEP-0079.
* See http://xmpp.org/extensions/xep-0079.html#conditions-def-match
* @param value AMPDeliveryCondition.Value instance that will be used as value parameter. Can't be null.
*/
@@ -67,7 +67,7 @@ public class AMPMatchResourceCondition implements AMPExtension.Condition {
* match-resource amp condition value as defined by XEP-0079.
* See http://xmpp.org/extensions/xep-0079.html#conditions-def-match
*/
- public static enum Value {
+ public enum Value {
/**
* Destination resource matches any value, effectively ignoring the intended resource.
* Example: "home/laptop" matches "home", "home/desktop" or "work/desktop"
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/amp/packet/AMPExtension.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/amp/packet/AMPExtension.java
index 6d842e04f..c8b696cc3 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/amp/packet/AMPExtension.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/amp/packet/AMPExtension.java
@@ -31,7 +31,7 @@ public class AMPExtension implements ExtensionElement {
public static final String NAMESPACE = "http://jabber.org/protocol/amp";
public static final String ELEMENT = "amp";
- private CopyOnWriteArrayList rules = new CopyOnWriteArrayList();
+ private final CopyOnWriteArrayList rules = new CopyOnWriteArrayList<>();
private boolean perHop = false;
private final String from;
@@ -225,18 +225,18 @@ public class AMPExtension implements ExtensionElement {
* @see AMPExpireAtCondition
* @see AMPMatchResourceCondition
**/
- public static interface Condition {
+ public interface Condition {
String getName();
String getValue();
- static final String ATTRIBUTE_NAME = "condition";
+ String ATTRIBUTE_NAME = "condition";
}
/**
* amp action attribute.
* See http://xmpp.org/extensions/xep-0079.html#actions-def
**/
- public static enum Action {
+ public enum Action {
/**
* The "alert" action triggers a reply stanza to the sending entity.
* This stanza MUST contain the element ,
@@ -272,7 +272,7 @@ public class AMPExtension implements ExtensionElement {
/**
* amp notification status as defined by XEP-0079.
*/
- public static enum Status {
+ public enum Status {
alert,
error,
notify
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/blocking/BlockingCommandManager.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/blocking/BlockingCommandManager.java
index 4be9dce33..a5347c311 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/blocking/BlockingCommandManager.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/blocking/BlockingCommandManager.java
@@ -103,7 +103,7 @@ public final class BlockingCommandManager extends Manager {
BlockContactsIQ blockContactIQ = (BlockContactsIQ) iqRequest;
if (blockListCached == null) {
- blockListCached = new ArrayList();
+ blockListCached = new ArrayList<>();
}
List blockedJids = blockContactIQ.getJids();
@@ -125,7 +125,7 @@ public final class BlockingCommandManager extends Manager {
UnblockContactsIQ unblockContactIQ = (UnblockContactsIQ) iqRequest;
if (blockListCached == null) {
- blockListCached = new ArrayList();
+ blockListCached = new ArrayList<>();
}
List unblockedJids = unblockContactIQ.getJids();
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/bookmarks/BookmarkManager.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/bookmarks/BookmarkManager.java
index 6346683c6..45ed9ab2b 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/bookmarks/BookmarkManager.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/bookmarks/BookmarkManager.java
@@ -45,7 +45,7 @@ import org.jxmpp.jid.parts.Resourcepart;
* @author Alexander Wenckus
*/
public final class BookmarkManager {
- private static final Map bookmarkManagerMap = new WeakHashMap();
+ private static final Map bookmarkManagerMap = new WeakHashMap<>();
static {
PrivateDataManager.addPrivateDataProvider("storage", "storage:bookmarks",
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/bookmarks/BookmarkedConference.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/bookmarks/BookmarkedConference.java
index 9037f01aa..555af7e2c 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/bookmarks/BookmarkedConference.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/bookmarks/BookmarkedConference.java
@@ -21,7 +21,7 @@ import org.jxmpp.jid.EntityBareJid;
import org.jxmpp.jid.parts.Resourcepart;
/**
- * Respresents a Conference Room bookmarked on the server using XEP-0048 Bookmark Storage XEP.
+ * Represents a Conference Room bookmarked on the server using XEP-0048 Bookmark Storage XEP.
*
* @author Derek DeMoro
*/
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/bookmarks/BookmarkedURL.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/bookmarks/BookmarkedURL.java
index a0e438bb5..1f8f14318 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/bookmarks/BookmarkedURL.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/bookmarks/BookmarkedURL.java
@@ -18,7 +18,7 @@
package org.jivesoftware.smackx.bookmarks;
/**
- * Respresents one instance of a URL defined using XEP-0048 Bookmark Storage XEP.
+ * Represents one instance of a URL defined using XEP-0048 Bookmark Storage XEP.
*
* @author Derek DeMoro
*/
@@ -41,9 +41,9 @@ public class BookmarkedURL implements SharedBookmark {
/**
* Returns the name representing the URL (eg. Jive Software). This can be used in as a label, or
- * identifer in applications.
+ * identifier in applications.
*
- * @return the name reprenting the URL.
+ * @return the name representing the URL.
*/
public String getName() {
return name;
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/bookmarks/Bookmarks.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/bookmarks/Bookmarks.java
index f046be1b7..e3937f957 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/bookmarks/Bookmarks.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/bookmarks/Bookmarks.java
@@ -68,15 +68,15 @@ public class Bookmarks implements PrivateData {
public static final String NAMESPACE = "storage:bookmarks";
public static final String ELEMENT = "storage";
- private List bookmarkedURLS;
- private List bookmarkedConferences;
+ private final List bookmarkedURLS;
+ private final List bookmarkedConferences;
/**
* Required Empty Constructor to use Bookmarks.
*/
public Bookmarks() {
- bookmarkedURLS = new ArrayList();
- bookmarkedConferences = new ArrayList();
+ bookmarkedURLS = new ArrayList<>();
+ bookmarkedConferences = new ArrayList<>();
}
/**
@@ -280,7 +280,7 @@ public class Bookmarks implements PrivateData {
BookmarkedConference conf = new BookmarkedConference(jid);
conf.setName(name);
- conf.setAutoJoin(Boolean.valueOf(autojoin).booleanValue());
+ conf.setAutoJoin(Boolean.valueOf(autojoin));
// Check for nickname
boolean done = false;
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/bookmarks/SharedBookmark.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/bookmarks/SharedBookmark.java
index 45d77ba60..d618f8ad1 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/bookmarks/SharedBookmark.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/bookmarks/SharedBookmark.java
@@ -29,5 +29,5 @@ public interface SharedBookmark {
*
* @return returns true if this bookmark is shared.
*/
- public boolean isShared();
+ boolean isShared();
}
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/BytestreamListener.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/BytestreamListener.java
index b5c13ff8e..13d3169dd 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/BytestreamListener.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/BytestreamListener.java
@@ -45,6 +45,6 @@ public interface BytestreamListener {
*
* @param request the incoming bytestream request
*/
- public void incomingBytestreamRequest(BytestreamRequest request);
+ void incomingBytestreamRequest(BytestreamRequest request);
}
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/BytestreamRequest.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/BytestreamRequest.java
index 3edada382..d4b8cba36 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/BytestreamRequest.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/BytestreamRequest.java
@@ -41,14 +41,14 @@ public interface BytestreamRequest {
*
* @return the sender of the bytestream open request
*/
- public Jid getFrom();
+ Jid getFrom();
/**
* Returns the session ID of the bytestream open request.
*
* @return the session ID of the bytestream open request
*/
- public String getSessionID();
+ String getSessionID();
/**
* Accepts the bytestream open request and returns the session to send/receive data.
@@ -60,13 +60,13 @@ public interface BytestreamRequest {
* @throws NoResponseException
* @throws SmackException
*/
- public BytestreamSession accept() throws InterruptedException, NoResponseException, XMPPErrorException, SmackException;
+ BytestreamSession accept() throws InterruptedException, XMPPErrorException, SmackException;
/**
* Rejects the bytestream request by sending a reject error to the initiator.
* @throws NotConnectedException
* @throws InterruptedException
*/
- public void reject() throws NotConnectedException, InterruptedException;
+ void reject() throws NotConnectedException, InterruptedException;
}
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/BytestreamSession.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/BytestreamSession.java
index 4e57d257d..b38357021 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/BytestreamSession.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/BytestreamSession.java
@@ -39,7 +39,7 @@ public interface BytestreamSession {
* @return the InputStream associated with this session to send data
* @throws IOException if an error occurs while retrieving the input stream
*/
- public InputStream getInputStream() throws IOException;
+ InputStream getInputStream() throws IOException;
/**
* Returns the OutputStream associated with this session to receive data.
@@ -47,7 +47,7 @@ public interface BytestreamSession {
* @return the OutputStream associated with this session to receive data
* @throws IOException if an error occurs while retrieving the output stream
*/
- public OutputStream getOutputStream() throws IOException;
+ OutputStream getOutputStream() throws IOException;
/**
* Closes the bytestream session.
@@ -57,7 +57,7 @@ public interface BytestreamSession {
*
* @throws IOException if an error occurs while closing the session
*/
- public void close() throws IOException;
+ void close() throws IOException;
/**
* Returns the timeout for read operations of the input stream associated with this session. 0
@@ -66,7 +66,7 @@ public interface BytestreamSession {
* @return the timeout for read operations
* @throws IOException if there is an error in the underlying protocol
*/
- public int getReadTimeout() throws IOException;
+ int getReadTimeout() throws IOException;
/**
* Sets the specified timeout, in milliseconds. With this option set to a non-zero timeout, a
@@ -79,6 +79,6 @@ public interface BytestreamSession {
* @param timeout the specified timeout, in milliseconds
* @throws IOException if there is an error in the underlying protocol
*/
- public void setReadTimeout(int timeout) throws IOException;
+ void setReadTimeout(int timeout) throws IOException;
}
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/ibb/InBandBytestreamManager.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/ibb/InBandBytestreamManager.java
index f9bcf6969..743caabd9 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/ibb/InBandBytestreamManager.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/ibb/InBandBytestreamManager.java
@@ -181,7 +181,7 @@ public final class InBandBytestreamManager extends Manager implements Bytestream
* list containing session IDs of In-Band Bytestream open packets that should be ignored by the
* InitiationListener
*/
- private List ignoredBytestreamRequests = Collections.synchronizedList(new LinkedList());
+ private final List ignoredBytestreamRequests = Collections.synchronizedList(new LinkedList());
/**
* Returns the InBandBytestreamManager to handle In-Band Bytestreams for a given
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/ibb/InBandBytestreamSession.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/ibb/InBandBytestreamSession.java
index 79a5b29e8..3b925e91a 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/ibb/InBandBytestreamSession.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/ibb/InBandBytestreamSession.java
@@ -532,7 +532,7 @@ public class InBandBytestreamSession implements BytestreamSession {
@Override
public void processStanza(Stanza packet) {
// get data packet extension
- DataPacketExtension data = (DataPacketExtension) packet.getExtension(
+ DataPacketExtension data = packet.getExtension(
DataPacketExtension.ELEMENT,
DataPacketExtension.NAMESPACE);
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/ibb/provider/DataPacketProvider.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/ibb/provider/DataPacketProvider.java
index 124652b4e..fb0c9dd43 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/ibb/provider/DataPacketProvider.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/ibb/provider/DataPacketProvider.java
@@ -40,8 +40,7 @@ public class DataPacketProvider {
public Data parse(XmlPullParser parser, int initialDepth)
throws Exception {
DataPacketExtension data = packetExtensionProvider.parse(parser);
- Data iq = new Data(data);
- return iq;
+ return new Data(data);
}
}
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/ibb/provider/OpenIQProvider.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/ibb/provider/OpenIQProvider.java
index 1b68bd70c..53c9e9864 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/ibb/provider/OpenIQProvider.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/ibb/provider/OpenIQProvider.java
@@ -40,7 +40,7 @@ public class OpenIQProvider extends IQProvider {
int blockSize = Integer.parseInt(parser.getAttributeValue("", "block-size"));
String stanzaValue = parser.getAttributeValue("", "stanza");
- StanzaType stanza = null;
+ StanzaType stanza;
if (stanzaValue == null) {
stanza = StanzaType.IQ;
}
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/socks5/Socks5BytestreamManager.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/socks5/Socks5BytestreamManager.java
index 38c0a6261..25cd936df 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/socks5/Socks5BytestreamManager.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/socks5/Socks5BytestreamManager.java
@@ -152,7 +152,7 @@ public final class Socks5BytestreamManager extends Manager implements Bytestream
* list containing session IDs of SOCKS5 Bytestream initialization packets that should be
* ignored by the InitiationListener
*/
- private List ignoredBytestreamRequests = Collections.synchronizedList(new LinkedList());
+ private final List ignoredBytestreamRequests = Collections.synchronizedList(new LinkedList());
/**
* Returns the Socks5BytestreamManager to handle SOCKS5 Bytestreams for a given
@@ -411,13 +411,12 @@ public final class Socks5BytestreamManager extends Manager implements Bytestream
* @return the Socket to send/receive data to/from the user
* @throws IOException if the bytestream could not be established
* @throws InterruptedException if the current thread was interrupted while waiting
- * @throws NoResponseException
* @throws SmackException if the target does not support SOCKS5.
* @throws XMPPException
*/
@Override
public Socks5BytestreamSession establishSession(Jid targetJID, String sessionID)
- throws IOException, InterruptedException, NoResponseException, SmackException, XMPPException {
+ throws IOException, InterruptedException, SmackException, XMPPException {
XMPPConnection connection = connection();
XMPPErrorException discoveryException = null;
// check if target supports SOCKS5 Bytestream
@@ -589,7 +588,7 @@ public final class Socks5BytestreamManager extends Manager implements Bytestream
*/
private List determineStreamHostInfos(List proxies) {
XMPPConnection connection = connection();
- List streamHosts = new ArrayList();
+ List streamHosts = new ArrayList<>();
// add local proxy on first position if exists
List localProxies = getLocalStreamHost();
@@ -601,7 +600,7 @@ public final class Socks5BytestreamManager extends Manager implements Bytestream
for (Jid proxy : proxies) {
Bytestream streamHostRequest = createStreamHostRequest(proxy);
try {
- Bytestream response = (Bytestream) connection.createStanzaCollectorAndSend(
+ Bytestream response = connection.createStanzaCollectorAndSend(
streamHostRequest).nextResultOrThrow();
streamHosts.addAll(response.getStreamHosts());
}
@@ -650,7 +649,7 @@ public final class Socks5BytestreamManager extends Manager implements Bytestream
}
final int port = socks5Server.getPort();
- List streamHosts = new ArrayList();
+ List streamHosts = new ArrayList<>();
outerloop: for (String address : addresses) {
// Prevent loopback addresses from appearing as streamhost
final String[] loopbackAddresses = { "127.0.0.1", "0:0:0:0:0:0:0:1", "::1" };
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/socks5/Socks5Client.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/socks5/Socks5Client.java
index 1c7b43670..1d3b89fdc 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/socks5/Socks5Client.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/socks5/Socks5Client.java
@@ -34,9 +34,7 @@ import java.util.logging.Logger;
import org.jivesoftware.smack.SmackException;
import org.jivesoftware.smack.XMPPException;
-import org.jivesoftware.smack.XMPPException.XMPPErrorException;
import org.jivesoftware.smack.util.StringUtils;
-
import org.jivesoftware.smackx.bytestreams.socks5.packet.Bytestream.StreamHost;
/**
@@ -74,16 +72,15 @@ class Socks5Client {
* @param timeout timeout to connect to SOCKS5 proxy in milliseconds
* @return socket the initialized socket
* @throws IOException if initializing the socket failed due to a network error
- * @throws XMPPErrorException if establishing connection to SOCKS5 proxy failed
* @throws TimeoutException if connecting to SOCKS5 proxy timed out
* @throws InterruptedException if the current thread was interrupted while waiting
- * @throws SmackException if the connection to the SOC
+ * @throws SmackException if the connection to the SOCKS5 proxy failed
* @throws XMPPException
*/
- public Socket getSocket(int timeout) throws IOException, XMPPErrorException, InterruptedException,
+ public Socket getSocket(int timeout) throws IOException, InterruptedException,
TimeoutException, SmackException, XMPPException {
// wrap connecting in future for timeout
- FutureTask futureTask = new FutureTask(new Callable() {
+ FutureTask futureTask = new FutureTask<>(new Callable() {
@Override
public Socket call() throws IOException, SmackException {
@@ -173,7 +170,7 @@ class Socks5Client {
// check if server responded with correct version and no-authentication method
if (response[0] != (byte) 0x05 || response[1] != (byte) 0x00) {
- throw new SmackException("Remote SOCKS5 server responsed with unexpected version: " + response[0] + ' ' + response[1] + ". Should be 0x05 0x00.");
+ throw new SmackException("Remote SOCKS5 server responded with unexpected version: " + response[0] + ' ' + response[1] + ". Should be 0x05 0x00.");
}
// request SOCKS5 connection with given address/digest
@@ -188,7 +185,7 @@ class Socks5Client {
connectionRequest[1] = (byte) 0x00; // set expected return status to 0
if (!Arrays.equals(connectionRequest, connectionResponse)) {
throw new SmackException(
- "Connection request does not equal connection reponse. Response: "
+ "Connection request does not equal connection response. Response: "
+ Arrays.toString(connectionResponse) + ". Request: "
+ Arrays.toString(connectionRequest));
}
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/socks5/Socks5ClientForInitiator.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/socks5/Socks5ClientForInitiator.java
index 53d744776..447b3750e 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/socks5/Socks5ClientForInitiator.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/socks5/Socks5ClientForInitiator.java
@@ -74,7 +74,7 @@ class Socks5ClientForInitiator extends Socks5Client {
@Override
public Socket getSocket(int timeout) throws IOException, InterruptedException,
TimeoutException, XMPPException, SmackException {
- Socket socket = null;
+ Socket socket;
// check if stream host is the local SOCKS5 proxy
if (this.streamHost.getJID().equals(this.connection.get().getUser())) {
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/socks5/Socks5Proxy.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/socks5/Socks5Proxy.java
index 6f1b4bc3b..0a0046af4 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/socks5/Socks5Proxy.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/socks5/Socks5Proxy.java
@@ -93,12 +93,12 @@ public final class Socks5Proxy {
private ServerSocket serverSocket;
/* assigns a connection to a digest */
- private final Map connectionMap = new ConcurrentHashMap();
+ private final Map connectionMap = new ConcurrentHashMap<>();
/* list of digests connections should be stored */
private final List allowedConnections = Collections.synchronizedList(new LinkedList());
- private final Set localAddresses = new LinkedHashSet(4);
+ private final Set localAddresses = new LinkedHashSet<>(4);
/**
* Private constructor.
@@ -112,7 +112,7 @@ public final class Socks5Proxy {
} catch (SocketException e) {
throw new IllegalStateException(e);
}
- Set localHostAddresses = new HashSet();
+ Set localHostAddresses = new HashSet<>();
for (NetworkInterface networkInterface : Collections.list(networkInterfaces)) {
// We can't use NetworkInterface.getInterfaceAddresses here, which
// would return a List instead the deprecated Enumeration, because
@@ -293,7 +293,7 @@ public final class Socks5Proxy {
*/
public List getLocalAddresses() {
synchronized (localAddresses) {
- return new LinkedList(localAddresses);
+ return new LinkedList<>(localAddresses);
}
}
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/socks5/packet/Bytestream.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/socks5/packet/Bytestream.java
index 8b022d9fc..a5d0ed7f1 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/socks5/packet/Bytestream.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/bytestreams/socks5/packet/Bytestream.java
@@ -46,7 +46,7 @@ public class Bytestream extends IQ {
private Mode mode = Mode.tcp;
- private final List streamHosts = new ArrayList();
+ private final List streamHosts = new ArrayList<>();
private StreamHostUsed usedHost;
diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/caps/EntityCapsManager.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/caps/EntityCapsManager.java
index b28eb5ff4..fb862591b 100644
--- a/smack-extensions/src/main/java/org/jivesoftware/smackx/caps/EntityCapsManager.java
+++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/caps/EntityCapsManager.java
@@ -96,7 +96,7 @@ public final class EntityCapsManager extends Manager {
private static boolean autoEnableEntityCaps = true;
- private static Map instances = new WeakHashMap<>();
+ private static final Map instances = new WeakHashMap<>();
private static final StanzaFilter PRESENCES_WITH_CAPS = new AndFilter(new StanzaTypeFilter(Presence.class), new StanzaExtensionFilter(
ELEMENT, NAMESPACE));
@@ -104,7 +104,7 @@ public final class EntityCapsManager extends Manager {
/**
* Map of "node + '#' + hash" to DiscoverInfo data
*/
- static final LruCache CAPS_CACHE = new LruCache(1000);
+ static final LruCache CAPS_CACHE = new LruCache<>(1000);
/**
* Map of Full JID -> DiscoverInfo/null. In case of c2s connection the
@@ -417,8 +417,8 @@ public final class EntityCapsManager extends Manager {
}
/**
- * Get our own caps version. The version depends on the enabled features. A
- * caps version looks like '66/0NaeaBKkwk85efJTGmU47vXI='
+ * Get our own caps version. The version depends on the enabled features.
+ * A caps version looks like '66/0NaeaBKkwk85efJTGmU47vXI='
*
* @return our own caps version
*/
@@ -497,7 +497,7 @@ public final class EntityCapsManager extends Manager {
if (connection != null)
JID_TO_NODEVER_CACHE.put(connection.getUser(), new NodeVerHash(entityNode, currentCapsVersion));
- final List identities = new LinkedList(ServiceDiscoveryManager.getInstanceFor(connection).getIdentities());
+ final List identities = new LinkedList<>(ServiceDiscoveryManager.getInstanceFor(connection).getIdentities());
sdm.setNodeInformationProvider(localNodeVer, new AbstractNodeInformationProvider() {
List features = sdm.getFeatures();
List packetExtensions = sdm.getExtendedInfoAsList();
@@ -531,7 +531,7 @@ public final class EntityCapsManager extends Manager {
}
/**
- * Verify DisoverInfo and Caps Node as defined in XEP-0115 5.4 Processing
+ * Verify DiscoverInfo and Caps Node as defined in XEP-0115 5.4 Processing
* Method.
*
* @see XEP-0115
@@ -569,7 +569,7 @@ public final class EntityCapsManager extends Manager {
* @return true if the stanza(/packet) extensions is ill-formed
*/
protected static boolean verifyPacketExtensions(DiscoverInfo info) {
- List foundFormTypes = new LinkedList();
+ List foundFormTypes = new LinkedList<>();
for (ExtensionElement pe : info.getExtensions()) {
if (pe.getNamespace().equals(DataForm.NAMESPACE)) {
DataForm df = (DataForm) pe;
@@ -628,10 +628,9 @@ public final class EntityCapsManager extends Manager {
// [NAME]. Note that each slash is included even if the LANG or
// NAME is not included (in accordance with XEP-0030, the category and
// type MUST be included.
- SortedSet sortedIdentities = new TreeSet();
+ SortedSet sortedIdentities = new TreeSet<>();
- for (DiscoverInfo.Identity i : discoverInfo.getIdentities())
- sortedIdentities.add(i);
+ sortedIdentities.addAll(discoverInfo.getIdentities());
// 3. For each identity, append the 'category/type/lang/name' to S,
// followed by the '<' character.
@@ -647,7 +646,7 @@ public final class EntityCapsManager extends Manager {
}
// 4. Sort the supported service discovery features.
- SortedSet features = new TreeSet();
+ SortedSet features = new TreeSet<>();
for (Feature f : discoverInfo.getFeatures())
features.add(f.getVar());
@@ -666,7 +665,7 @@ public final class EntityCapsManager extends Manager {
// 6. If the service discovery information response includes
// XEP-0128 data forms, sort the forms by the FORM_TYPE (i.e.,
// by the XML character data of the element).
- SortedSet fs = new TreeSet(new Comparator() {
+ SortedSet fs = new TreeSet<>(new Comparator() {
@Override
public int compare(FormField f1, FormField f2) {
return f1.getVariable().compareTo(f2.getVariable());
@@ -727,10 +726,8 @@ public final class EntityCapsManager extends Manager {
}
private static void formFieldValuesToCaps(List i, StringBuilder sb) {
- SortedSet fvs = new TreeSet