From ec456399b584968ec22892a3c03e8c80e0d0d06f Mon Sep 17 00:00:00 2001 From: Florian Schmaus Date: Mon, 27 Sep 2021 14:14:01 +0200 Subject: [PATCH] [carbons] Remove erroneous assert statement in connectionClosed() The assert statement in CarbonManager's connectionClosed() connection listener callback was erroneous. A connection may be connected, but never was authenticated. If now the connection is closed, then carbonsListener was never setup (via the authenticated() callback), causing the assert to throw an exception. --- .../java/org/jivesoftware/smackx/carbons/CarbonManager.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/smack-experimental/src/main/java/org/jivesoftware/smackx/carbons/CarbonManager.java b/smack-experimental/src/main/java/org/jivesoftware/smackx/carbons/CarbonManager.java index 196484c97..f5b231d1e 100644 --- a/smack-experimental/src/main/java/org/jivesoftware/smackx/carbons/CarbonManager.java +++ b/smack-experimental/src/main/java/org/jivesoftware/smackx/carbons/CarbonManager.java @@ -154,8 +154,7 @@ public final class CarbonManager extends Manager { // because we also reset in authenticated() if the stream got not resumed, but for maximum correctness, // also reset here. enabled_state = false; - boolean removed = connection().removeSyncStanzaListener(carbonsListener); - assert removed; + connection().removeSyncStanzaListener(carbonsListener); } @Override public void authenticated(XMPPConnection connection, boolean resumed) {