From fe85ab3b832491fdea1322285fca59b2c050c75b Mon Sep 17 00:00:00 2001 From: adiaholic Date: Tue, 9 Jul 2019 22:12:26 +0530 Subject: [PATCH 1/2] Correcting mini typing error --- .../src/main/java/org/jivesoftware/smack/util/NumberUtil.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/smack-core/src/main/java/org/jivesoftware/smack/util/NumberUtil.java b/smack-core/src/main/java/org/jivesoftware/smack/util/NumberUtil.java index 140fff4e3..9e914f884 100644 --- a/smack-core/src/main/java/org/jivesoftware/smack/util/NumberUtil.java +++ b/smack-core/src/main/java/org/jivesoftware/smack/util/NumberUtil.java @@ -40,7 +40,7 @@ public class NumberUtil { throw new IllegalArgumentException("unsigned 32-bit integers can't be negative"); } if (value > ((1L << 32) - 1)) { - throw new IllegalArgumentException("unsigned 32-bit integers can't be greater then 2^32 - 1"); + throw new IllegalArgumentException("unsigned 32-bit integers can't be greater than 2^32 - 1"); } return value; } From 41a3ec05c74a8dbc5b1faa003f04caa6f5bace5a Mon Sep 17 00:00:00 2001 From: adiaholic Date: Sun, 28 Jul 2019 16:36:12 +0530 Subject: [PATCH 2/2] Returning obtained XmlStringBuilder instead of null --- .../jivesoftware/smackx/mediaelement/element/MediaElement.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/smack-extensions/src/main/java/org/jivesoftware/smackx/mediaelement/element/MediaElement.java b/smack-extensions/src/main/java/org/jivesoftware/smackx/mediaelement/element/MediaElement.java index b831933e5..08ebeba32 100644 --- a/smack-extensions/src/main/java/org/jivesoftware/smackx/mediaelement/element/MediaElement.java +++ b/smack-extensions/src/main/java/org/jivesoftware/smackx/mediaelement/element/MediaElement.java @@ -90,7 +90,7 @@ public class MediaElement implements FormFieldChildElement { xml.append(uris, xmlEnvironment); xml.closeElement(this); - return null; + return xml; } public MediaElement from(FormField formField) {